1. 01 May, 2019 1 commit
  2. 30 Apr, 2019 1 commit
  3. 01 May, 2019 2 commits
  4. 30 Apr, 2019 1 commit
  5. 01 May, 2019 3 commits
  6. 30 Apr, 2019 1 commit
  7. 01 May, 2019 7 commits
  8. 30 Apr, 2019 1 commit
  9. 01 May, 2019 3 commits
  10. 30 Apr, 2019 4 commits
  11. 01 May, 2019 2 commits
    • Drew Willcoxon's avatar
      Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and... · 539ae1ed
      Drew Willcoxon authored
      Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak
      
      This test uncovered a couple of problems:
      
      (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key.
      
      handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event.
      
      So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys.
      
      (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results.
      
      It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433
      
      Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled.
      
      Differential Revision: https://phabricator.services.mozilla.com/D29300
      
      --HG--
      extra : moz-landing-system : lando
      539ae1ed
    • Doug Thayer's avatar
      Bug 1546498 - Split out MaybePrefetchMemory's check into two functions r=aklotz · 5f3d1ecd
      Doug Thayer authored
      Temporarily just sidestep the issue in bug 1546498 (crash with latest SDK
      on startup in Windows 7) by just continuing to use the old method in
      Windows 7. We saw no wins in telemetry for Windows 7 anyway, so we should
      investigate why that is, and why we see a mysterious crash in the fallback
      code, in a followup bug.
      
      Differential Revision: https://phabricator.services.mozilla.com/D29239
      
      --HG--
      extra : moz-landing-system : lando
      5f3d1ecd
  12. 30 Apr, 2019 2 commits
  13. 01 May, 2019 1 commit
  14. 30 Apr, 2019 11 commits