Skip to content
GitLab
Switch branch/tag
  1. 05 Dec, 2019 1 commit
  3. 04 Dec, 2019 1 commit
  5. 03 Dec, 2019 1 commit
  7. 25 Nov, 2019 1 commit
  9. 14 Nov, 2019 1 commit
  11. 12 Nov, 2019 1 commit
  13. 07 Nov, 2019 1 commit
  15. 04 Nov, 2019 1 commit
  17. 01 Nov, 2019 1 commit
  19. 31 Oct, 2019 1 commit
  21. 25 Oct, 2019 1 commit
  23. 11 Oct, 2019 1 commit
  25. 17 Oct, 2019 1 commit
  27. 11 Oct, 2019 2 commits
  29. 10 Oct, 2019 1 commit
    • Mike Conley's avatar
      Bug 1585769 - Create a fresh <video> element for the Picture-in-Picture player... · 51b7a876
      Mike Conley authored 
      Bug 1585769 - Create a fresh <video> element for the Picture-in-Picture player window rather than cloning the original element. r=JSON_voorhees

Cloning the original node was needed when we needed the MediaInfo copied over, but
HTMLVideoElement::CloneElementVisually copies it over for us, so we can create a
fresh <video> element. This should also be a much healthier thing to do
security-wise, since we're not cloning strange nodes from the web.

Differential Revision: https://phabricator.services.mozilla.com/D48123

--HG--
extra : moz-landing-system : lando
      51b7a876
  31. 01 Oct, 2019 3 commits
    • Mike Conley's avatar
      Bug 1582502 - Don't interpret a click at 0,0 of a fullscreen video as a click... · 7429e303
      Mike Conley authored 
      Bug 1582502 - Don't interpret a click at 0,0 of a fullscreen video as a click on the Picture-in-Picture toggle. r=JSON_voorhees

We weren't handling the case where the toggle has no dimensions, so its X and Y
coordinate would be at 0,0, which would match a click in the top-left corner of
the screen for a video that was fullscreened.

This adds a check that ensures that the toggle has both width and height before
checking whether or not a mouse event occurred within it.

Differential Revision: https://phabricator.services.mozilla.com/D47789

--HG--
extra : moz-landing-system : lando
      7429e303
    • Mike Conley's avatar
      Bug 1549442 - Make sure to hide the Picture-in-Picture toggle when the mouse... · 5794ef14
      Mike Conley authored 
      Bug 1549442 - Make sure to hide the Picture-in-Picture toggle when the mouse cursor leaves the window. r=JSON_voorhees

Originally, we were using the :hover pseudoclass to show the Picture-in-Picture toggle,
and using the DevTools InspectorUtils module to manually apply that :hover pseudoclass
in PictureInPictureToggleChild in the event that the <video> element wasn't able to get
the :hover element "naturally".

Removing this pseudoclass when the mouse leaves the browser window (without first
leaving the toggle) doesn't work, since the mouseout event (which we use to detect
the mouse leaving the window) fires _after_ :hover states would normally be cleared,
so it's too late to "unlock" it.

The solution ended up being replacing the :hover pseudoclass with a .hovering class
that PictureInPictureToggleChild continues to manage on its own.

Differential Revision: https://phabricator.services.mozilla.com/D47677

--HG--
extra : moz-landing-system : lando
      5794ef14
    • Mike Conley's avatar
      Bug 1583882 - Close Picture-in-Picture player window if the originating... · cf8d0284
      Mike Conley authored 
      Bug 1583882 - Close Picture-in-Picture player window if the originating <video> is removed from the DOM. r=JSON_voorhees

Differential Revision: https://phabricator.services.mozilla.com/D47613

--HG--
extra : moz-landing-system : lando
      cf8d0284
  33. 14 Sep, 2019 1 commit
  35. 11 Sep, 2019 3 commits
  37. 05 Sep, 2019 3 commits
  39. 04 Sep, 2019 1 commit
    • Mike Conley's avatar
      Bug 1548296 - Attach Picture-in-Picture toggle on UAWidgetSetupOrChange event... · db962775
      Mike Conley authored 
      Bug 1548296 - Attach Picture-in-Picture toggle on UAWidgetSetupOrChange event rather than canplay. r=JSON_voorhees

Videos can fire their "canplay" events even when they're not part of the DOM. This
means that videos that have already fired that event won't get the
PictureInPictureToggleChild properly attached after being inserted.

The UAWidgetSetupOrChange event, however, is fired for video events once they've
been bound to the DOM, so we can use that instead.

Differential Revision: https://phabricator.services.mozilla.com/D44541

--HG--
extra : moz-landing-system : lando
      db962775
  41. 21 Aug, 2019 1 commit
  43. 13 Aug, 2019 2 commits
  45. 02 Aug, 2019 1 commit
  47. 01 Aug, 2019 1 commit
    • Mike Conley's avatar
      Bug 1570406 - Ensure that we properly detach window root event listeners in... · 681b8ccd
      Mike Conley authored 
      Bug 1570406 - Ensure that we properly detach window root event listeners in PictureInPictureToggleChild. r=JSON_voorhees

We were using the pagehide event before incorrectly: the pagehide event target
was being inspected to see if it was the top-level frame, and only then, would
we remove the mouse event handlers on the window root.

The problem is that event.target.top on a pagehide event is undefined, since the
event target is a Document.

Further, we probably want to remove any window root event listeners that were
registered for subframes as well. I'm not sure why I decided to try to filter
out subframes, but that definitely can keep windows alive.

So instead, I'm using the "cleanup" method that ActorManagerChild calls if
defined on an ActorChild, which runs when the associated frame unloads. This
way, if a subframe happened to have registered a window root event listener,
it'll get unregistered.

Differential Revision: https://phabricator.services.mozilla.com/D40090

--HG--
extra : moz-landing-system : lando
      681b8ccd
  49. 18 Jul, 2019 2 commits
  51. 05 Jul, 2019 1 commit
  53. 02 Jul, 2019 1 commit
  55. 02 May, 2019 1 commit
  57. 01 May, 2019 1 commit
  59. 25 Apr, 2019 2 commits