Skip to content
GitLab
  1. 14 Nov, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Post: Cull unused variables; guard more with... · a8fd11ad
      Nick Alexander authored 
      Bug 1411654 - Post: Cull unused variables; guard more with MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE. r=maliu

MozReview-Commit-ID: 8EGzVISIEQZ

--HG--
extra : rebase_source : 300f6a6656b87a4b487ec7ec331446b326371665
extra : source : cfad693be9185ae858a29a715b3e5a6d2d3d6fbf
      a8fd11ad
  3. 15 Nov, 2017 1 commit
  5. 14 Nov, 2017 2 commits
  7. 08 Nov, 2017 1 commit
  9. 10 Nov, 2017 1 commit
  11. 09 Nov, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Part 3: Make each variant handle source from moz.build. r=maliu · 0a042187
      Nick Alexander authored 
      The advantage of doing this per-variant is that we can really separate
the 'local' behaviour (re-generate via re-entrant |mach build|
invocations) from the 'official' behaviour (never re-generate via
re-entrance).

This also uses new Android-Gradle plugin 3.0+ APIs to integrate the
generated resources and Java code.

MozReview-Commit-ID: 4pd2iw1nJSb

--HG--
extra : rebase_source : 205080d3822f59bcdd5d3b44de2898ff775f5746
extra : source : 730a70767743b74a7e3a1fcf4018540edfdf30a3
      0a042187
  13. 08 Nov, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Part 2: Update Robolectric to 3.5.1. r=mcomella · ea45b765
      Nick Alexander authored 
      There were a few API changes, mostly around explicitly creating
Services/Activities/ContentProvider instances, but they were pretty
easy to address.

Sadly, Robolectric doesn't really work with the new aapt2 processing
in Android-Gradle plugin 3.0+ -- see in particular
https://github.com/robolectric/robolectric/issues/3333#issuecomment-324300418
-- so we have to opt-out of the new implementation for now.  Hopefully
plugin 3.1+ will address these issues, which are widespread.

MozReview-Commit-ID: dlbd32kMs6

--HG--
extra : rebase_source : fe30729161e5dc91ea9173f9b7aaa9135d096791
extra : source : 690e265c684ce70ecb89355314fd1574bb421f0b
      ea45b765
  15. 26 Oct, 2017 1 commit
  17. 15 Nov, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Part 0: Add rudimentary documentation about Gradle integration. r=maliu · e4a04926
      Nick Alexander authored 
      This sketches the flavor dimensions.  The important ones are
`audience` and `geckoBinaries`, which I think simplify the situation
greatly.  Coupled with Bug 1417232 centralizing most everything in
`mobile/android/gradle.configure`, the Gradle configuration shouldn't
be so hard to evolve.

MozReview-Commit-ID: DILjVrnLA3F

--HG--
extra : rebase_source : a4ea96a49308f457a406716662d9b64d4ba749fe
extra : source : cec2b8828cc8800fa269d290ce38ea82c454b445
      e4a04926
  19. 09 Jan, 2018 1 commit
  21. 15 Nov, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Pre: Remove unused HomeExpandableListView. r=mcomella · f6dad2bb
      Nick Alexander authored 
      This was added for the Remote Tabs panel in Bug 785199.  That code has
now morphed into the combined history panel, which uses a
RecyclerView.

MozReview-Commit-ID: J6KsVCn8mzh

--HG--
extra : rebase_source : 2d8a43b6697367f9fec1db760dd1e36ca12e31d0
extra : source : 2b37201606f5a921d91339e2c8a2ec86885b68e8
      f6dad2bb
  23. 04 Jan, 2018 1 commit
  25. 15 Nov, 2017 2 commits
  27. 08 Nov, 2017 3 commits
    • Nick Alexander's avatar
      Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella · 6f1f726e
      Nick Alexander authored 
      Newer versions of Robolectric seem to have different semantics about
clearing disk caches, so this is necessary.  But for older versions,
it shouldn't hurt, and is slightly more clear than relying on an
implicit clear.

MozReview-Commit-ID: LRcaEPasXj8

--HG--
extra : rebase_source : 4d6bb4916cde61f198004661bed58025e91ffa9c
extra : source : 373c9a71d9451498462594b302b4fe2648431fef
      6f1f726e
    • Nick Alexander's avatar
      Bug 1411654 - Pre: Remove unused PerProfileDatabaseProvider. r=mcomella · 34d3e93f
      Nick Alexander authored 
      No idea what is going on with this hierarchy, but this isn't used and
isn't helping anything.

MozReview-Commit-ID: Ir3LxLYHR6M

--HG--
extra : rebase_source : f1726d37fa285de1042fed76a722f941380cbf63
extra : source : 3dc3beab95f83b2f08ff9ff305fdd4b85cc05d9d
      34d3e93f
    • Nick Alexander's avatar
      Bug 1411654 - Pre: Fix dangling resource. r=mcomella · 830afb59
      Nick Alexander authored 
      This is just wrong.

MozReview-Commit-ID: EBtKTD07aNu

--HG--
rename : mobile/android/base/resources/values-v17/themes.xml => mobile/android/app/src/main/res/values-v17/themes.xml
extra : rebase_source : c6e58c6be966dd8ace6aa796b5a5e6000ee9c65e
extra : source : 22a861db1573364916ab2c5b6d0c6321ba08ff55
      830afb59
  29. 27 Oct, 2017 1 commit
    • Nick Alexander's avatar
      Bug 1411654 - Pre: Don't block Google's maven repository. r=maliu · cb03a352
      Nick Alexander authored 
      Turns out Google's maven repository doesn't publish checksums.  I
can't imagine why not, but there it is.  We have to think more about
whether to trust the artifacts downloaded from maven.google.com.

MozReview-Commit-ID: CdWijorq1IV

--HG--
extra : rebase_source : 6c66cf1444876624f10409ea6437863e2c2ea9b0
extra : source : 0850b319efd43ac8f4d61485451722975da55ca1
      cb03a352
  31. 25 Oct, 2017 1 commit
  33. 04 Jan, 2018 1 commit
  35. 07 Dec, 2017 1 commit
  37. 08 Dec, 2017 4 commits
  39. 07 Dec, 2017 1 commit
  41. 04 Jan, 2018 1 commit
  43. 25 Jan, 2018 1 commit
  45. 31 Jan, 2018 1 commit
  47. 19 Jan, 2018 1 commit
  49. 31 Jan, 2018 1 commit
    • Nick Alexander's avatar
      Bug 1368699 - Write .purgecaches sentinels every |mach build|. r=gps · 41616795
      Nick Alexander authored 
      This adds a new `post_build` step to each `BuildBackend`
implementation, and uses it to write .purgecaches after every |mach
build| invocation -- including after |mach build TARGET| invocations.
This approach should be more robust than the existing recursive-Make
based solution, which seems to not write the .purgecaches files in
some situations.

In addition, the recursive-Make solution does not generalize to other
backends, in particular Tup.  It is possible that the Tup backend will
handle writing the .purgecaches sentinel as part of its regular build
process, but discussions with mshal suggest that there's no convenient
way for Tup to write .purgecaches only when something *changes* during
the build.  That is, Tup can achieve the behaviour implemented by this
patch, but it's not easier to do better by not writing .purgecaches
when the caches do not in fact need to be purged.

I elected to bake in the special knowledge of
--enable-application=browser and macOS here since this whole process
is special.  If we need to generalize, we could add a moz.configure
option specifying the purgecaches directories, but it doesn't seem
worth it right now.

The ideal approach would be to determine FINAL_TARGET from the
application directory, but that is determined by DIST_SUBDIR.  In
addition, it's not clear how to present that information to the
post-build step in a build-backend agnostic manner.

This will require tweaking as we migrate the macOS bundle handling to
moz.build, especially in browser/app.  See
https://bugzilla.mozilla.org/show_bug.cgi?id=1223748, which could
improve this significantly.

MozReview-Commit-ID: 63KZy18D23i

--HG--
extra : rebase_source : e973d065cd91e965f4103ed2732858e2e7a9c546
      41616795
  51. 19 Jan, 2018 1 commit
    • Nick Alexander's avatar
      Bug 1368699 - Pre: Remove MY_{CONFIG,RULES} Makefile customization hooks. r=gps · 6729d9a4
      Nick Alexander authored 
      I very much doubt these are used, but even if we are -- we shouldn't
support this type of local customization, since it doesn't extend to
non-Make-based backends.

With the customization point removed, there's no way to set ETAGS, so
we remove what little support there was for generating Emacs tags.

MozReview-Commit-ID: IEF2Q4tISEn

--HG--
extra : rebase_source : 3bc8e651c03517edb797032db6ce60ed8852d9fa
      6729d9a4
  53. 31 Jan, 2018 3 commits
  55. 04 Jan, 2018 1 commit
  57. 07 Dec, 2017 1 commit
  59. 08 Dec, 2017 2 commits