GitLab

Differential Revision: https://phabricator.services.mozilla.com/D29238

--HG--
extra : moz-landing-system : lando

Bug 1533955 - Move the current message manager actors to a legacy list, and create a new list of JS Window Actors. r=NeilDeakin

Differential Revision: https://phabricator.services.mozilla.com/D29237

--HG--
extra : moz-landing-system : lando

Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak

This test uncovered a couple of problems:

(1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key.

handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event.

So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys.

(2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results.

It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433

Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled.

Differential Revision: https://phabricator.services.mozilla.com/D29300

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29411

--HG--
extra : moz-landing-system : lando

Backed out changeset 9242458b79d5 (bug 1539804) for high frequency browser/browser_urlbarStopSearchOnSelection.js failures CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D28347

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29430

--HG--
extra : moz-landing-system : lando

# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando

remove subsuite=clipboard from manifests

Differential Revision: https://phabricator.services.mozilla.com/D28521

--HG--
extra : moz-landing-system : lando

Bug 1545395 - Handle Search Engine urls properly where the search terms are in the url rather than as parameters. r=daleharvey

Differential Revision: https://phabricator.services.mozilla.com/D29014

--HG--
extra : moz-landing-system : lando

Backed out 2 changesets (bug 1545766, bug 1546633) for causing browser_PanelMultiView_keyboard.js to perma fail CLOSED TREE

Backed out changeset 041741ce1646 (bug 1546633)
Backed out changeset fbc294a6fe78 (bug 1545766)

Previously, we sent a command event and a click event.
Normally, the command event executes the action, then the click event closes the menu.
However, in some cases (e.g. the Library button), there is no command event handler and the mousedown event executes the action instead.

Differential Revision: https://phabricator.services.mozilla.com/D29151

--HG--
extra : moz-landing-system : lando

Extension panels contain embedded documents; i.e. a <browser> element.
We want users to be able to tab to these and we want them to be focused automatically if a subview is opened from the keyboard, so treat them as tabbable.
However, once an embedded document is focused, we can't manage keyboard navigation inside it, so don't try.
Previously, we tried, which meant keys were overridden even though they didn't do anything, breaking keyboard navigation in extensions altogether.

Differential Revision: https://phabricator.services.mozilla.com/D28442

--HG--
extra : moz-landing-system : lando

Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak

This test uncovered a couple of problems:

(1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key.

handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event.

So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys.

(2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results.

It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433

Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled.

Differential Revision: https://phabricator.services.mozilla.com/D29300

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29432

--HG--
extra : moz-landing-system : lando

Temporary workaround to prevent wrapper assertions in torn-down
window.

Differential Revision: https://phabricator.services.mozilla.com/D29410

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D22442

--HG--
extra : moz-landing-system : lando

Bug 1547496 - remove warning for minimum font sizes being big as internal pages are no longer affected, r=mconley,flod

This warning was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1047586 .
As a result of https://bugzilla.mozilla.org/show_bug.cgi?id=1528712 , internal pages
are no longer affected by this change. Instead, they obey the OS font size
configuration, in which we cannot warn. So let's remove the now-inaccurate warning dialog.

Differential Revision: https://phabricator.services.mozilla.com/D29218

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D28093

--HG--
extra : moz-landing-system : lando

Bug 1482809 - Move non-browser-specific parts of browser/components/enterprisepolicies to toolkit r=mkaply,Felipe

Differential Revision: https://phabricator.services.mozilla.com/D28309

--HG--
rename : browser/components/enterprisepolicies/EnterprisePolicies.js => toolkit/components/enterprisepolicies/EnterprisePolicies.js
rename : browser/components/enterprisepolicies/EnterprisePolicies.manifest => toolkit/components/enterprisepolicies/EnterprisePolicies.manifest
rename : browser/components/enterprisepolicies/EnterprisePoliciesContent.js => toolkit/components/enterprisepolicies/EnterprisePoliciesContent.js
rename : browser/components/enterprisepolicies/WindowsGPOParser.jsm => toolkit/components/enterprisepolicies/WindowsGPOParser.jsm
rename : browser/components/enterprisepolicies/macOSPoliciesParser.jsm => toolkit/components/enterprisepolicies/macOSPoliciesParser.jsm
rename : browser/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm => toolkit/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js
rename : browser/components/enterprisepolicies/tests/browser/config_broken_json.json => toolkit/components/enterprisepolicies/tests/browser/config_broken_json.json
extra : moz-landing-system : lando

--HG--
rename : toolkit/components/enterprisepolicies/EnterprisePolicies.js => browser/components/enterprisepolicies/EnterprisePolicies.js
rename : toolkit/components/enterprisepolicies/EnterprisePolicies.manifest => browser/components/enterprisepolicies/EnterprisePolicies.manifest
rename : toolkit/components/enterprisepolicies/EnterprisePoliciesContent.js => browser/components/enterprisepolicies/EnterprisePoliciesContent.js
rename : toolkit/components/enterprisepolicies/WindowsGPOParser.jsm => browser/components/enterprisepolicies/WindowsGPOParser.jsm
rename : toolkit/components/enterprisepolicies/macOSPoliciesParser.jsm => browser/components/enterprisepolicies/macOSPoliciesParser.jsm
rename : toolkit/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm => browser/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm
rename : toolkit/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js => browser/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js
rename : toolkit/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js => browser/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js
rename : toolkit/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js => browser/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js
rename : toolkit/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js => browser/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js
rename : toolkit/components/enterprisepolicies/tests/browser/config_broken_json.json => browser/components/enterprisepolicies/tests/browser/config_broken_json.json

Bug 1482809 - Move non-browser-specific parts of browser/components/enterprisepolicies to toolkit r=mkaply,Felipe

Differential Revision: https://phabricator.services.mozilla.com/D28309

--HG--
rename : browser/components/enterprisepolicies/EnterprisePolicies.js => toolkit/components/enterprisepolicies/EnterprisePolicies.js
rename : browser/components/enterprisepolicies/EnterprisePolicies.manifest => toolkit/components/enterprisepolicies/EnterprisePolicies.manifest
rename : browser/components/enterprisepolicies/EnterprisePoliciesContent.js => toolkit/components/enterprisepolicies/EnterprisePoliciesContent.js
rename : browser/components/enterprisepolicies/WindowsGPOParser.jsm => toolkit/components/enterprisepolicies/WindowsGPOParser.jsm
rename : browser/components/enterprisepolicies/macOSPoliciesParser.jsm => toolkit/components/enterprisepolicies/macOSPoliciesParser.jsm
rename : browser/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm => toolkit/components/enterprisepolicies/tests/EnterprisePolicyTesting.jsm
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_basic_tests.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_broken_json.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_enterprise_only.js
rename : browser/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js => toolkit/components/enterprisepolicies/tests/browser/browser_policies_mistyped_json.js
rename : browser/components/enterprisepolicies/tests/browser/config_broken_json.json => toolkit/components/enterprisepolicies/tests/browser/config_broken_json.json
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29340

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D20425

--HG--
rename : testing/web-platform/meta/mediacapture-streams/MediaDevices-getSupportedConstraints.html.ini => testing/web-platform/meta/mediacapture-streams/MediaDevices-getSupportedConstraints.https.html.ini
rename : testing/web-platform/tests/mediacapture-streams/MediaDevices-getSupportedConstraints.html => testing/web-platform/tests/mediacapture-streams/MediaDevices-getSupportedConstraints.https.html
extra : moz-landing-system : lando

Depends on D21554

Differential Revision: https://phabricator.services.mozilla.com/D29109

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21554

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21553

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21552

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D21551

--HG--
extra : moz-landing-system : lando

Backed out 4 changesets (bug 1501108) for causing very frequent leaks in macOS debug wpt tests. a=backout

Backed out changeset 23a77e063257 (bug 1501108)
Backed out changeset 335cec0aacd8 (bug 1501108)
Backed out changeset 99ba286125d1 (bug 1501108)
Backed out changeset 8f2d511ad49f (bug 1501108)

--HG--
extra : rebase_source : 01925c24ac47b37135fcfebab8ae7e9876d5b90e

Differential Revision: https://phabricator.services.mozilla.com/D27099

--HG--
extra : moz-landing-system : lando

Bug 1546019 - When a focused browser changes remoteness, make sure to activate the remote browser if needed. r=qdot

Not quite sure what's a good way to add a test for this... Ideas?

Differential Revision: https://phabricator.services.mozilla.com/D29104

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29191

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29118

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29012

--HG--
extra : moz-landing-system : lando

Bug 1512171 - Provide better error message when attempt is made to add bookmark folder to root folder. r=robwu,rpl

Differential Revision: https://phabricator.services.mozilla.com/D28337

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D29086

--HG--
extra : moz-landing-system : lando

Backed out changeset f706ae697922 (bug 1541317) for failures in test_ext_settings_overrides_search.js

Differential Revision: https://phabricator.services.mozilla.com/D28265

--HG--
extra : moz-landing-system : lando

Differential Revision: https://phabricator.services.mozilla.com/D28523

--HG--
extra : moz-landing-system : lando