Skip to content
GitLab
  1. 24 Oct, 2019 1 commit
  3. 10 Jul, 2019 2 commits
  5. 08 Jul, 2019 2 commits
  7. 17 May, 2019 1 commit
  9. 27 Apr, 2019 1 commit
  11. 01 Apr, 2019 1 commit
    • Makoto Kato's avatar
      Bug 1149300 - zoomToFocusedInput should make focused content visible. r=kats · e336b78c
      Makoto Kato authored 
      ZoomToFocusedInput currently does not properly handle the
case where the input element is inside a nested scrollable subframe,
as it only asks APZ to pan/zoom the root content document, and
the root content document might not be zoomable or scrollable to
make the input element visible. To handle this case properly we need
to ask the main thread to scroll the element into view first.

Differential Revision: https://phabricator.services.mozilla.com/D20983

--HG--
extra : rebase_source : 21d2b66bb657b1165820d76fe86badb7838035da
extra : histedit_source : 996b4eebf9855445c11135f5f7a3789209b720f8%2C183ffc9ae30c1df4813204dd1bedf5b9f5608518
      e336b78c
  13. 05 Mar, 2019 1 commit
  15. 27 Feb, 2019 1 commit
  17. 12 Feb, 2019 1 commit
  19. 10 Feb, 2019 1 commit
  21. 12 Feb, 2019 1 commit
  23. 25 Jan, 2019 1 commit
  25. 28 Jan, 2019 1 commit
  27. 21 Jan, 2019 1 commit
  29. 23 Oct, 2018 1 commit
  31. 10 Oct, 2018 1 commit
  33. 01 Oct, 2018 1 commit
  35. 26 Jun, 2018 1 commit
  37. 15 Jun, 2018 1 commit
  39. 10 Jun, 2018 1 commit
  41. 07 Jun, 2018 2 commits
    • Kartikaya Gupta's avatar
      Bug 1465935 - Handle another edge case with hit-testing inside fixed-pos items. r=mstange · 829cd991
      Kartikaya Gupta authored 
      Transforms are containing blocks for fixed-pos items, so if a fixed-pos
item is inside a scrolled transform, then it should use that scrollframe
as the scroll target for hit-testing. This patch handles this case for
WebRender by stashing the appropriate ASR on the nsDisplayFixedPosition
item and using it instead of the presShell's root scrollframe in this
scenario.

The patch also adds a mochitest (which is basically a mochitested
version of the reftest in fixed-pos-scrolled-clip-3.html, with a
hit-test check to ensure that it's hitting the right scrollframe).

MozReview-Commit-ID: 7YQAeOiMMuP

--HG--
extra : rebase_source : 8d1c89d0c03c3e7d9383d0731f65a327a2c11a8d
      829cd991
    • Kartikaya Gupta's avatar
      Bug 1465935 - Fix hit-testing for fixed-pos items inside iframes. r=mstange · 9b664db1
      Kartikaya Gupta authored 
      Without this patch, the scrollId for display items inside a fixed-pos
item end as the ASR of the item. In the case of fixed-pos items that are
inside iframes, the ASR is the outer document's root scrollframe. This
means that e.g. wheel-scrolling while over a fixed-pos item inside an
iframe ends up scrolling the outer document's root scrollframe instead
of the iframe's root scrollframe.

In the non-WR codepath, there some APZ machinery that walks up in the
HitTestingTreeNode tree from the hit result, looking to see if that node
has a fixed-pos ancestor, and if so, uses the fixed-pos item's target
APZ as the real hit result. This machinery doesn't exist in WR, because
we don't use the HitTestingTreeNode tree for hit-testing in APZ.
Instead, we need to make sure that the item tag for those display items
already has the appropriate scrollid set.

This patch accomplishes this by introducing a new RAII class that is
pushed into the wr::DisplayListBuilder while we are building display
items inside a nsDisplayFixedPosition, and allows the desired scroll id to
be set on the hit-testing display items.

This behaviour is exercised by test_group_wheelevents, which can now be
enabled with this fix.

MozReview-Commit-ID: L2erPVzJeql

--HG--
extra : rebase_source : 1db630513cb1dc16d4e38649812e81f62c8da99c
      9b664db1
  43. 01 Jun, 2018 1 commit
  45. 11 Jun, 2018 1 commit
    • Kartikaya Gupta's avatar
      Bug 1421384 - Inherit touch-action flags down in the compositor hit-test infos. r=miko · 42941621
      Kartikaya Gupta authored 
      Per the touch-action spec, the effective touch-action on an element includes
touch-action restrictions from ancestor elements up to and including the
element that has the "default action". This patch implements that behaviour
so that WebRender gets correct touch-action values on its display items.

MozReview-Commit-ID: Cw5uqAsE9qm

--HG--
extra : rebase_source : ef6e24a66385e097d50b3a03c06091464b1bb5b9
      42941621
  47. 21 Jun, 2018 1 commit
  49. 05 Jun, 2018 2 commits
    • Hiroyuki Ikezoe's avatar
      Bug 1464568 - Set the shadow base transform value for the case where opacity... · a39a4ba1
      Hiroyuki Ikezoe authored 
      Bug 1464568 - Set the shadow base transform value for the case where opacity animations' calculation was skipped. r=kats

And make DOMWindowUtils.getOMTCTransform work for opacity animations' layer.

MozReview-Commit-ID: 7P99WjYqPr0

--HG--
extra : rebase_source : cf87e8da40cf9febdb4188f4ef8ebe3b64eabe53
      a39a4ba1
    • Hiroyuki Ikezoe's avatar
      Bug 1464568 - Set the shadow base transform for animation explicitly even if... · 602a0753
      Hiroyuki Ikezoe authored 
      Bug 1464568 - Set the shadow base transform for animation explicitly even if the transform value hasn't changed. r=kats

That's because the shadow base transform value might have been changed by APZC.

The test case in this patch fail without this fix on non-WebRender and the test
case is skipped on WebRender since the bug should never happen on WebRender
because WebRender manages animation transform value and APZ transform value
separately.

MozReview-Commit-ID: Itgh0QL1su6

--HG--
extra : rebase_source : c6f498947ce0be81bfd89f8190f4676f00aa6355
      602a0753
  51. 23 Apr, 2018 1 commit
  53. 28 Mar, 2018 1 commit
    • Botond Ballo's avatar
      Bug 1449759 - Add an APZ mochitest for bug 1443518. r=kats · f733b4a0
      Botond Ballo authored 
      MozReview-Commit-ID: 1t6wpYo9n3P

--HG--
rename : gfx/layers/apz/test/mochitest/helper_hittest_subframe_float.html => gfx/layers/apz/test/mochitest/helper_hittest_float_bug1434846.html
extra : rebase_source : 11d9a120f1b1fdd841a7e7cb59b92975e08205df
      f733b4a0
  55. 04 Apr, 2018 1 commit
  57. 28 Mar, 2018 1 commit
  59. 14 Mar, 2018 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 1445478: Make pointerevents/test_bug1414336.html more reliable. r=kats · 222d41c9
      Emilio Cobos Álvarez authored 
      There can be something shuffling the iframe between the mouse event is sent and
the mouse event is received which makes us end up targeting the <body> instead
of the test target.

This can be reproduced with enough persistence either with and without the
patches from bug 1439875, at least on a headless build with rr chaos mode.

Move it to test_group_pointerevents in the apz tests to run it in a new window
and make it a bit more reliable.

MozReview-Commit-ID: BS6Es8iEmMY
      222d41c9
  61. 06 Mar, 2018 1 commit
  63. 26 Feb, 2018 1 commit
  65. 21 Mar, 2018 1 commit
    • Botond Ballo's avatar
      Bug 1425603 - APZ mochitest for obeying overscroll-behavior when scrolling... · af24ea01
      Botond Ballo authored 
      Bug 1425603 - APZ mochitest for obeying overscroll-behavior when scrolling over a checkerboarded area. r=kats

MozReview-Commit-ID: JMWBVf2bKKP

--HG--
rename : gfx/layers/apz/test/mochitest/helper_scroll_overscroll_behavior.html => gfx/layers/apz/test/mochitest/helper_overscroll_behavior_bug1425573.html
extra : rebase_source : be9f67885ef2fd13b6e3bc377903da7878d53ed1
      af24ea01
  67. 02 Feb, 2018 1 commit
    • Kartikaya Gupta's avatar
      Bug 1435282 - Make SetTestSampleTime force a sync flush. r=sotaro · 42945c90
      Kartikaya Gupta authored 
      SetTestSampleTime is called from tests via the advanceTimeAndRefresh API
on DOMWindowUtils, and the expectation is that after it is done, the
time has been advanced and a composite has happened. So we need to
ensure that is the case with WebRender as well. This fixes the issue I
was seeing with test_group_hittest.html and makes it pass.

MozReview-Commit-ID: 86l9mTTwD2v

--HG--
extra : rebase_source : d2921fb0f9b09f4366fb516e4a6254a7f13f3e4e
      42945c90
  69. 12 Feb, 2018 1 commit
  71. 29 Jan, 2018 1 commit