1. 20 May, 2022 1 commit
  2. 27 Apr, 2022 39 commits
    • Richard Pospesel's avatar
      fixup! TB4: Tor Browser's Firefox preference overrides. · 46c2ca70
      Richard Pospesel authored
      Bug 21484: Remove or hide "What's New" link from About dialog
      46c2ca70
    • Pier Angelo Vendrame's avatar
      fixup! Bug 21952: Implement Onion-Location · 43429bce
      Pier Angelo Vendrame authored and Richard Pospesel's avatar Richard Pospesel committed
      Keep fragments in redirects, to fix #34366
      43429bce
    • Georg Koppen's avatar
      Revert "Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 a=RyanVM" · 3dc963cb
      Georg Koppen authored and Richard Pospesel's avatar Richard Pospesel committed
      This reverts commit 1eb13643.
      
      This fixes tor-browser#40721, tor-browser#40698, and #40706.
      3dc963cb
    • Matthew Finkel's avatar
      Bug 40253: Explicitly allow NoScript in Private Browsing mode. · 95c38088
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      95c38088
    • Richard Pospesel's avatar
      Bug 40597: Implement TorSettings module · c62ccbe5
      Richard Pospesel authored
      - migrated in-page settings read/write implementation from about:preferences#tor
        to the TorSettings module
      - TorSettings initially loads settings from the tor daemon, and saves them to
        firefox prefs
      - TorSettings notifies observers when a setting has changed; currently only
        QuickStart notification is implemented for parity with previous preference
        notify logic in about:torconnect and about:preferences#tor
      - about:preferences#tor, and about:torconnect now read and write settings
        thorugh the TorSettings module
      - all tor settings live in the torbrowser.settings.* preference branch
      - removed unused pref modify permission for about:torconnect content page from
        AsyncPrefs.jsm
      c62ccbe5
    • Gaba's avatar
      Adding issue template for bugs. · 94a32bb8
      Gaba authored and Richard Pospesel's avatar Richard Pospesel committed
      94a32bb8
    • Richard Pospesel's avatar
      Bug 27476: Implement about:torconnect captive portal within Tor Browser · 412813d6
      Richard Pospesel authored
      - implements new about:torconnect page as tor-launcher replacement
      - adds tor connection status to url bar and tweaks UX when not online
      - adds new torconnect component to browser
      - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
      - the onion pattern from about:tor migrated to an .inc.xhtml file now used by both about:tor and about:torconnect
      - various design tweaks and resusability fixes to onion pattern
      - adds warning/error box to about:preferences#tor when not connected to tor
      - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP)
      - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
      412813d6
    • sanketh's avatar
      40209: Implement Basic Crypto Safety · 998ac31c
      sanketh authored and Richard Pospesel's avatar Richard Pospesel committed
      Adds a CryptoSafety actor which detects when you've copied a crypto
      address from a HTTP webpage and shows a warning.
      
      Closes #40209.
      
      Bug 40428: Fix string attribute names
      998ac31c
    • Matthew Finkel's avatar
      Bug 40432: Prevent probing installed applications · 4eecc98f
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      4eecc98f
    • Alex Catarineu's avatar
      Bug 40309: Avoid using regional OS locales · 37314312
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      Only use regional OS locales if the pref
      `intl.regional_prefs.use_os_locales` is set to true.
      37314312
    • Alex Catarineu's avatar
      Bug 40171: Make WebRequest and GeckoWebExecutor First-Party aware · dac3a8d6
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      dac3a8d6
    • Alex Catarineu's avatar
      Bug 40198: Expose privacy.spoof_english pref in GeckoView · 322b524f
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      322b524f
    • Alex Catarineu's avatar
      2cc46a16
    • Alex Catarineu's avatar
      Bug 30605: Honor privacy.spoof_english in Android · c73c1f41
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      This checks `privacy.spoof_english` whenever `setLocales` is
      called from Fenix side and sets `intl.accept_languages`
      accordingly.
      c73c1f41
    • Alex Catarineu's avatar
      68d1e9b1
    • Matthew Finkel's avatar
      Bug 40125: Expose Security Level pref in GeckoView · 42975ae1
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      42975ae1
    • Alex Catarineu's avatar
      Bug 40091: Load HTTPS Everywhere as a builtin addon in desktop · 511a2448
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      This loads HTTPS Everywhere as a builtin addon from a hardcoded
      resource:// URI in desktop. It also ensures that the non-builtin
      HTTPS Everywhere addon is always uninstalled on browser startup.
      
      The reason of making this desktop-only is that there are some issues
      when installing a builtin extension from geckoview side, making
      the extension not available on first startup. So, at least for
      now we handle the Fenix case separately. See #40118 for a followup
      for investigating these.
      511a2448
    • Kathleen Brade's avatar
      Bug 40002: Remove about:ion · c22089c5
      Kathleen Brade authored and Richard Pospesel's avatar Richard Pospesel committed
      Firefox Ion (previously Firefox Pioneer) is an opt-in program in which people
      volunteer to participate in studies that collect detailed, sensitive data about
      how they use their browser.
      c22089c5
    • Alex Catarineu's avatar
      Bug 40073: Disable remote Public Suffix List fetching · c9f9b577
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      In https://bugzilla.mozilla.org/show_bug.cgi?id=1563246 Firefox implemented
      fetching the Public Suffix List via RemoteSettings and replacing the default
      one at runtime, which we do not want.
      c9f9b577
    • Alex Catarineu's avatar
      Bug 40025: Remove Mozilla add-on install permissions · c3b87502
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      c3b87502
    • Kathleen Brade's avatar
      Bug 33852: Clean up about:logins (LockWise) to avoid mentioning sync, etc. · 04e407d1
      Kathleen Brade authored and Richard Pospesel's avatar Richard Pospesel committed
      Hide elements on about:logins that mention sync, "Firefox LockWise", and
      Mozilla's LockWise mobile apps.
      
      Disable the "Create New Login" button when security.nocertdb is true.
      04e407d1
    • Kathleen Brade's avatar
      Bug 32418: Allow updates to be disabled via an enterprise policy. · 893bfa4f
      Kathleen Brade authored and Richard Pospesel's avatar Richard Pospesel committed
      Restrict the Enterprise Policies mechanism to only consult a
      policies.json file (avoiding the Windows Registry and macOS's
      file system attributes).
      
      Add a few disabledByPolicy() checks to the update service to
      avoid extraneous (and potentially confusing) log messages when
      updates are disabled by policy.
      
      Sample content for distribution/policies.json:
      {
        "policies": {
          "DisableAppUpdate": true
        }
      }
      
      On Linux, avoid reading policies from /etc/firefox/policies/policies.json
      893bfa4f
    • Alex Catarineu's avatar
      Bug 21952: Implement Onion-Location · 00c4cf99
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      Whenever a valid Onion-Location HTTP header (or corresponding HTML
      <meta> http-equiv attribute) is found in a document load, we either
      redirect to it (if the user opted-in via preference) or notify the
      presence of an onionsite alternative with a badge in the urlbar.
      00c4cf99
    • Alex Catarineu's avatar
      Bug 28005: Implement .onion alias urlbar rewrites · 1837d13b
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      A custom HTTPS Everywhere update channel is installed,
      which provides rules for locally redirecting some memorable
      .tor.onion URLs to non-memorable .onion URLs.
      
      When these redirects occur, we also rewrite the URL in the urlbar
      to display the human-memorable hostname instead of the actual
      .onion.
      
      Bug 34196: Update site info URL with the onion name
      
      Bug 40456: Update the SecureDrop HTTPS-Everywhere update channel
      Bug 40478: Onion alias url rewrite is broken
      1837d13b
    • Alex Catarineu's avatar
      Bug 33342: Avoid disconnect search addon error after removal. · 4921afef
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      We removed the addon in #32767, but it was still being loaded
      from addonStartup.json.lz4 and throwing an error on startup
      because its resource: location is not available anymore.
      4921afef
    • Matthew Finkel's avatar
      Bug 28125 - Prevent non-Necko network connections · bd1fe166
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      bd1fe166
    • Matthew Finkel's avatar
      Bug 25741 - TBA: Disable GeckoNetworkManager · 5d2f3ac6
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      The browser should not need information related to the network
      interface or network state, tor should take care of that.
      5d2f3ac6
    • Amogh Pradeep's avatar
      Orfox: Centralized proxy applied to AbstractCommunicator and BaseResources. · ab75a8d6
      Amogh Pradeep authored and Richard Pospesel's avatar Richard Pospesel committed
      See Bug 1357997 for partial uplift.
      
      Also:
      Bug 28051 - Use our Orbot for proxying our connections
      
      Bug 31144 - ESR68 Network Code Review
      ab75a8d6
    • Matthew Finkel's avatar
      Bug 24796 - Comment out excess permissions from GeckoView · 9240b301
      Matthew Finkel authored and Richard Pospesel's avatar Richard Pospesel committed
      The GeckoView AndroidManifest.xml is not preprocessed unlike Fennec's
      manifest, so we can't use the ifdef preprocessor guards around the
      permissions we do not want. Commenting the permissions is the
      next-best-thing.
      9240b301
    • Georg Koppen's avatar
      Bug 32658: Create a new MAR signing key · 276a66f1
      Georg Koppen authored and Richard Pospesel's avatar Richard Pospesel committed
      It's time for our rotation again: Move the backup key in the front
      position and add a new backup key.
      
      Bug 33803: Move our primary nightly MAR signing key to tor-browser
      
      Bug 33803: Add a secondary nightly MAR signing key
      276a66f1
    • Kathleen Brade's avatar
      Bug 30237: Add v3 onion services client authentication prompt · b807c4b2
      Kathleen Brade authored and Richard Pospesel's avatar Richard Pospesel committed
      When Tor informs the browser that client authentication is needed,
      temporarily load about:blank instead of about:neterror and prompt
      for the user's key.
      
      If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
      control port command to add the key (via Torbutton's control port
      module) and reload the page.
      
      If the user cancels the prompt, display the standard about:neterror
      "Unable to connect" page. This requires a small change to
      browser/actors/NetErrorChild.jsm to account for the fact that the
      docShell no longer has the failedChannel information. The failedChannel
      is used to extract TLS-related error info, which is not applicable
      in the case of a canceled .onion authentication prompt.
      
      Add a leaveOpen option to PopupNotifications.show so we can display
      error messages within the popup notification doorhanger without
      closing the prompt.
      
      Add support for onion services strings to the TorStrings module.
      
      Add support for Tor extended SOCKS errors (Tor proposal 304) to the
      socket transport and SOCKS layers. Improved display of all of these
      errors will be implemented as part of bug 30025.
      
      Also fixes bug 19757:
       Add a "Remember this key" checkbox to the client auth prompt.
      
       Add an "Onion Services Authentication" section within the
       about:preferences "Privacy & Security section" to allow
       viewing and removal of v3 onion client auth keys that have
       been stored on disk.
      
      Also fixes bug 19251: use enhanced error pages for onion service errors.
      b807c4b2
    • Richard Pospesel's avatar
      Bug 32220: Improve the letterboxing experience · 18ab13ec
      Richard Pospesel authored
      CSS and JS changes to alter the UX surrounding letterboxing. The
      browser element containing page content is now anchored to the bottom
      of the toolbar, and the remaining letterbox margin is the same color
      as the firefox chrome. The letterbox margin and border are tied to
      the currently selected theme.
      
      Also adds a 'needsLetterbox' property to tabbrowser.xml to fix a race
      condition present when using the 'isEmpty' property. Using 'isEmpty'
      as a proxy for 'needsLetterbox' resulted in over-zealous/unnecessary
      letterboxing of about:blank tabs.
      18ab13ec
    • Alex Catarineu's avatar
      Bug 27604: Fix addon issues when moving TB directory · 171f4c44
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      171f4c44
    • Alex Catarineu's avatar
      Bug 31740: Remove some unnecessary RemoteSettings instances · fa21b9e3
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      More concretely, SearchService.jsm 'hijack-blocklists' and
      url-classifier-skip-urls.
      
      Avoid creating instance for 'anti-tracking-url-decoration'.
      
      If prefs are disabling their usage, avoid creating instances for
      'cert-revocations' and 'intermediates'.
      
      Do not ship JSON dumps for collections we do not expect to need. For
      the ones in the 'main' bucket, this prevents them from being synced
      unnecessarily (the code in remote-settings does so for collections
      in the main bucket for which a dump or local data exists). For the
      collections in the other buckets, we just save some size by not
      shipping their dumps.
      
      We also clear the collections database on the v2 -> v3 migration.
      fa21b9e3
    • Alex Catarineu's avatar
      Bug 32092: Fix Tor Browser Support link in preferences · db50d1c6
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      db50d1c6
    • Richard Pospesel's avatar
      Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#tor · 44f5162c
      Richard Pospesel authored
      This patch adds a new about:preferences#tor page which allows modifying
      bridge, proxy, and firewall settings from within Tor Browser. All of the
      functionality present in tor-launcher's Network Configuration panel is
      present:
      
       - Setting built-in bridges
       - Requesting bridges from BridgeDB via moat
       - Using user-provided bridges
       - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
       - Setting firewall ports
       - Viewing and Copying Tor's logs
       - The Networking Settings in General preferences has been removed
      44f5162c
    • Kathleen Brade's avatar
      Bug 26961: New user onboarding. · ec0cd713
      Kathleen Brade authored and Richard Pospesel's avatar Richard Pospesel committed
      Reuse the Firefox onboarding mechanism with minimal changes.
      Localizable strings are pulled in from Torbutton (if Torbutton is
        not installed, we lack about:tor and no tour will be shown).
      Replace SVG images with PNGs (see bug 27002),
      For defense in depth, omit include OnboardingTelemetry.jsm entirely.
      Added support for the following UITour page event:
        torBrowserOpenSecuritySettings
      
      Also fix bug 27403: the onboarding bubble is not always displayed.
      
      Arthur suggested to make the onboarding bubble visible on displays with
      less than 960px width available, so we choose 200px instead.
      
      Also fix bug 28628: Change onboarding Security panel to open new
      Security Level panel.
      
      Also fix bug 27484: Improve navigation within onboarding.
      
      Bug 27082: enable a limited UITour
      
      Disallow access to UITour functionality from all pages other than
        about:home, about:newtab, and about:tor.
      Implement a whitelist mechanism for page actions.
      
      Bug 26962 - implement new features onboarding (part 1).
      
      Add an "Explore" button to the "Circuit Display" panel within new user
      onboarding which opens the DuckDuckGo .onion and then guides users through
      a short circuit display tutorial.
      
      Allow a few additional UITour actions while limiting as much as possible
      how it can be used.
      
      Tweak the UITour styles to match the Tor Browser branding.
      
      All user interface strings are retrieved from Torbutton's
      browserOnboarding.properties file.
      
      Bug 27486 Avoid about:blank tabs when opening onboarding pages.
      
      Instead of using a simple <a href>, programmatically open onboarding
      web pages by using tabBrowser.addTab(). The same technique is now
      used for "See My Path", "See FAQs", and "Visit an Onion".
      
      Bug 29768: Introduce new features to users
      
      Add an "update" tour for the Tor Browser 8.5 release that contains two
      panels: Toolbar and Security (with appropriate description text and
      images).
      
      Display an attention-grabbing dot on the onboarding text bubble when
      the update tour is active. The animation lasts for 14 seconds.
      
      Bug 31768: Introduce toolbar and network settings changes in onboarding
      
      Update the "Tor Network" onboarding page to include a note that
      settings can now be accessed via the application preferences and
      add an "Adjust Your Tor Network Settings" action button which opens
      about:preferences#tor.
      
      Replace the Tor Browser 8.5 "update" onboarding tour with a 9.0 one
      that includes the revised "Tor Network" page and a revised "Toolbar"
      page. The latter explains that Torbutton's toolbar item has been
      removed ("Goodbye Onion Button") and explains how to access the
      New Identity feature using the hamburger menu and new toolbar item.
      
      Bug 34321 - Add Learn More onboarding item
      
      Bug 40429: Update Onboarding for 10.5
      ec0cd713
    • Alex Catarineu's avatar
      Bring back old Firefox onboarding · 47f623aa
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      Revert "Bug 1462415 - Delete onboarding system add-on r=Standard8,k88hudson"
      
      This reverts commit f7ffd78b.
      
      Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
      
      This reverts commit 057fe36f.
      
      Bug 28822: Convert onboarding to webextension
      
      Partially revert 1564367 (controlCenter in UITour.jsm)
      47f623aa
    • Alex Catarineu's avatar
      Bug 27511: Add new identity button to toolbar · 82b1bbd5
      Alex Catarineu authored and Richard Pospesel's avatar Richard Pospesel committed
      Also added 'New circuit for this site' button to CustomizableUI, but
      not visible by default.
      82b1bbd5