- 24 Dec, 2020 1 commit
-
-
harry authored
Bug 1680022 - Add idMap property to getViewUpdate and prohibit dynamic results from setting their own IDs. r=adw, a=jcristau Differential Revision: https://phabricator.services.mozilla.com/D100402
-
- 12 Jan, 2021 1 commit
-
-
Dale Harvey authored
Differential Revision: https://phabricator.services.mozilla.com/D101230
-
- 21 Dec, 2020 2 commits
-
-
Marco Bonardo authored
Differential Revision: https://phabricator.services.mozilla.com/D99955
-
Marco Bonardo authored
Differential Revision: https://phabricator.services.mozilla.com/D99954
-
- 11 Dec, 2020 1 commit
-
-
kanishk509 authored
Differential Revision: https://phabricator.services.mozilla.com/D96729
-
- 06 Dec, 2020 1 commit
-
-
Marco Bonardo authored
Bug 1673669 - Fix Address Bar IME composition interaction with Search Mode and the Event Bufferer. r=adw, a=RyanVM Fix a race condition with Korean IME, where it may submit delayed text after Enter has been handled. The patch delays events if composition is still ongoing and avoids using the selected element or the last resultForValue if it's not yet complete by the time we submit the text. Unfortunately this cannot be tested automatically in mochitests because it depends on a native behavior of the IME that synthesize methods can't reproduce. Additionally this fixes Bug 1679697 by ensuring Search Mode is not dismissed by IME and the urlbar value is proper when confirming Tab-to-search. This part comes with tests. Differential Revision: https://phabricator.services.mozilla.com/D98768
-
- 17 Nov, 2020 1 commit
-
-
Ryan VanderMeulen authored
Backed out changeset 4cf859c2cad2 (bug 1577539) Backed out changeset 693a84154f2f (bug 1577539)
-
- 13 Nov, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D97023
-
- 06 Dec, 2020 1 commit
-
-
Marco Bonardo authored
Bug 1673669 - Fix Address Bar IME composition interaction with Search Mode and the Event Bufferer. r=adw Fix a race condition with Korean IME, where it may submit delayed text after Enter has been handled. The patch delays events if composition is still ongoing and avoids using the selected element or the last resultForValue if it's not yet complete by the time we submit the text. Unfortunately this cannot be tested automatically in mochitests because it depends on a native behavior of the IME that synthesize methods can't reproduce. Additionally this fixes Bug 1679697 by ensuring Search Mode is not dismissed by IME and the urlbar value is proper when confirming Tab-to-search. This part comes with tests. Differential Revision: https://phabricator.services.mozilla.com/D98768
-
- 27 Oct, 2020 1 commit
-
-
Harry Twyford authored
Bug 1671803 - Part 2 - Add localized name for Baidu's OpenSearch engine to WEB_ENGINE_NAMES. r=mak, a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D94838
-
- 19 Oct, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D94012
-
- 16 Oct, 2020 1 commit
-
-
Marco Bonardo authored
Differential Revision: https://phabricator.services.mozilla.com/D92818
-
- 15 Oct, 2020 6 commits
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D93113
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D93112
-
Dão Gottwald authored
Bug 1671364 - Set "Sponsored" label for sponsored top sites in the address bar. r=mikedeboer,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D93637
-
Butkovits Atila authored
Backed out changeset 342354dfd594 (bug 1665934) Backed out changeset 56946d59bf0a (bug 1665934) Backed out changeset 1b03418a14f6 (bug 1665934) Backed out changeset 8c1edb639aa6 (bug 1665934)
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D93113
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D93112
-
- 14 Oct, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D93411
-
- 10 Oct, 2020 1 commit
-
-
Marco Bonardo authored
Bug 1668939 - Make tab-to-search origin autofill comparison more lenient when matching autofilled hosts. r=harry,Standard8 Differential Revision: https://phabricator.services.mozilla.com/D92978
-
- 29 Sep, 2020 1 commit
-
-
Harry Twyford authored
This adds tab-to-search telemetry, both for the new tabtosearch search mode entry point and for tabtosearch results in our usual Urlbar result-selection scalars. I also added a subtest in browser_urlbar_event_telemetry, but realized as I was writing it that it was not useful. We don't consider entering search more as the end of an engagement, so tab-to-search results will not appear in event telemetry. We already considered this in bug 1654680 and resolved it by adding detailed urlbar.searchmode.* scalars, so I don't consider it a blocker. I left the new subtest in since it was mostly done anyways and it can't hurt. Differential Revision: https://phabricator.services.mozilla.com/D91469
-
- 17 Nov, 2020 1 commit
-
-
Ryan VanderMeulen authored
Backed out changeset 4cf859c2cad2 (bug 1577539) Backed out changeset 693a84154f2f (bug 1577539)
-
- 20 Nov, 2020 1 commit
-
-
Drew Willcoxon authored
* Add prefs for each local search shortcut * Remove the `update2.localOneOffs` pref since it's not necessary with the three new prefs * Modify preferences UI by adding a new row in the engines tree for each local shortcut * Add `UrlbarUtils.LOCAL_SEARCH_MODES` so we have a single place where local search modes and their properties are defined * Add a new test file for the preferences UI * Modify browser_oneOffs.js to test the three new preferences Differential Revision: https://phabricator.services.mozilla.com/D97376
-
- 18 Nov, 2020 1 commit
-
-
Marco Bonardo authored
Bug 1676038 - Change partial tab-to-search matching to avoid autofilling unexpected subdomains. r=adw The previous approach was autofilling partial subdomains from search engines. Having a search engine pointing to "developer.mozilla.org, when "moz" was typed we ended up autofilling "moz[illa.org]" but pointing to "developer.mozilla.org". Unfortunately that made impossible to actually go to "mozilla.org" by typing it. The new approach instead allows tab-to-search results to appear even if there's no autofill, because the provider checks autonomously the autofill threshold. There's a downside though, with the old approach we could return more partial matches, and the Muxer would pick one, depending on the autofilled host. For example we could return "rover.ebay.com" and match it to "eb[ay.it]". With the new approach we don't have an autofilled host, and fetching it would be expensive, we can only compare the search string with the engine's host. For this reason the patch also tries to partially match against the searchForm host, that often points to a page the user visits more often. Differential Revision: https://phabricator.services.mozilla.com/D96942
-
- 04 Nov, 2020 1 commit
-
-
Daisuke Akatsuka authored
Depends on D93187 Differential Revision: https://phabricator.services.mozilla.com/D94821
-
- 27 Oct, 2020 1 commit
-
-
Marco Bonardo authored
This converts FX_URLBAR_SELECTED_RESULT_TYPE_2, FX_URLBAR_SELECTED_RESULT_INDEX and the correlation between them FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE_2 to keyed scalars, that are nicer to use and analyze. They are converted to one keyed scalar per result type, tracking the number of times that type was picked per urlbar index. The sums (count per type or per index) can still be derived from this structure. Differential Revision: https://phabricator.services.mozilla.com/D94498
-
- 25 Sep, 2020 2 commits
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D91077
-
Harry Twyford authored
Bug 1665076 - Call setSearchMode directly from search(), fix search mode handoff, and introduce new search mode probes. r=adw This patch calls setSearchMode directly from search(). This sets up a solution for the problem in the bug and also fixes the issue where a call to search() with a restriction token would flicker the token before it was replaced with the search mode indicator. I added new tabmenu and bookmarkmenu entry points to take advantage of this new functionality. This also fixes the issues with handoff. Besides the problem of search() recording typed for handoff, `handoff` wasn't even registered as a Telemetry probe! That was my mistake. I added a test for handoff telemetry. It was only practical to test it in PBM since it uses a different implementation than about:home that's easier to test. I wrote a lengthy comment above the subtest about why I think this is okay. Differential Revision: https://phabricator.services.mozilla.com/D91076
-
- 21 Aug, 2020 1 commit
-
-
Dão Gottwald authored
Bug 1660448 - Rename sendTopSiteAttributionRequest, TOP_SITES_ATTRIBUTION for consistency with PartnerLinkAttribution.jsm. r=Standard8 Differential Revision: https://phabricator.services.mozilla.com/D87856
-
- 17 Sep, 2020 1 commit
-
-
Dorel Luca authored
Backed out changeset b445d02b1367 (bug 1657676) for Browser-chrome failures in newtab/test/browser/browser_topsites_section.js. CLOSED TREE
-
- 16 Sep, 2020 1 commit
-
-
Brindusan Cristian authored
Backed out changeset 6e3078121a13 (bug 1657676) for bc failures at browser_oneOffs_keyModifiers.js. CLOSED TREE
-
- 17 Sep, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D89964
-
- 15 Sep, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D89964
-
- 16 Sep, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D89964
-
- 13 Aug, 2020 1 commit
-
-
Drew Willcoxon authored
Bug 1657918 - Don't add a heuristic result for empty searches in local search modes, and modify the view to allow it to stay open when empty. r=harry This excludes the heuristic for empty searches when in search mode. I haven't heard back from Verdi yet about excluding it for all searches in search mode. We can add that in a follow-up if necessary. Since we're now excluding the heuristic but we want the view to remain open, it's possible for the view to be empty while it's open. I had to make some changes to allow that to happen. There are three cases I want to call out: 1. When the search string is empty, the view shows top sites. If you then enter search mode and the resulting search doesn't return any results, we previously closed the view. This patch keeps it open. An example of this scenario is when you don't have any bookmarks and you click the bookmarks one-off. 2. When the urlbar isn't focused, it's in search mode, the input is empty, and the search didn't return any results, then focusing the urlbar didn't do anything previously. This patch auto-opens the view. 3. When the input contains a single char and it's in search mode, deleting the char previously closed the view if the empty search didn't return any results. This patch keeps the view open. When the view is empty, we also need to hide the one-offs' top border that usually separates them from the results. Otherwise there are two separator lines right next to each other, the one above the one-offs and the one at the bottom edge of the input. I don't think there's any CSS selector that will let us easily do this due to the DOM structure, so I added a new `noresults` attribute on the view for this. I had to call `context.searchString.trim()` to tell whether the search string is empty. Since we do that in a bunch of places, I added `context.trimmedSearchString`, and a lot of this patch is replacing those `trim` calls. Differential Revision: https://phabricator.services.mozilla.com/D86908
-
- 12 Aug, 2020 1 commit
-
-
Drew Willcoxon authored
Bug 1647889 - Show different Urlbar placeholder while visual indicator is showing. r=harry,fluent-reviewers,flod This is the simplest possible way to fix this bug in the interest of landing ASAP. It keeps a hardcoded list of engines that search the web. Differential Revision: https://phabricator.services.mozilla.com/D86664
-
- 08 Aug, 2020 1 commit
-
-
Marco Bonardo authored
Differential Revision: https://phabricator.services.mozilla.com/D86170
-
- 27 Oct, 2020 1 commit
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D94838
-
- 19 Oct, 2020 2 commits
-
-
Harry Twyford authored
Differential Revision: https://phabricator.services.mozilla.com/D94012
-
Cosmin Sabou authored
-