1. 07 May, 2020 1 commit
    • Timothy Nikkel's avatar
      Bug 1635658. Fix how CSS filters render with webrender that are represented as... · fe56adee
      Timothy Nikkel authored
      Bug 1635658. Fix how CSS filters render with webrender that are represented as component transfer when they are required to be represented as SVG filters. r=mstange a=pascalc
      
      The brightness, contrast, and invert css filters are represented as component transfer filters when they required to be represented as an svg filter (ie when an element has a combination of CSS and SVG filters specified).
      
      https://hg.mozilla.org/mozilla-central/rev/4f3360c4f104 (bug 1417699) used the value SVG_FECOMPONENTTRANSFER_TYPE_UNKNOWN for the function type in the G and B channels to specify that the R channel function should be used. As we know from https://hg.mozilla.org/mozilla-central/rev/a1ff0af83ad2 (bug 1605223) SVG_FECOMPONENTTRANSFER_TYPE_UNKNOWN is the value we get if the function is not specified, and by spec that is to be interpreted as the identity function.
      
      To fix this use a special function type that is not exposed to content, SVG_FECOMPONENTTRANSFER_SAME_AS_R, when we want to do this optimization. And then teach the webrender filter code to understand it.
      
      Differential Revision: https://phabricator.services.mozilla.com/D74189
      fe56adee
  2. 09 Mar, 2020 1 commit
    • Andrew Osmond's avatar
      Bug 1618345 - Enforce proper color management by splitting gfx::Color into... · 91b071ed
      Andrew Osmond authored
      Bug 1618345 - Enforce proper color management by splitting gfx::Color into sRGBColor and DeviceColor types. r=jrmuizel
      
      gfx::Color is currently misused in many places. The DrawTargets expect
      the color space to be in device space, e.g. what we are actually going
      to draw using. Everything sitting above generally deals with sRGB, as
      specified in CSS. Sometimes we missed the conversion from sRGB to device
      space when issuing draw calls, and similarly sometimes we converted the
      color to device space twice.
      
      This patch splits the type in two. sRGBColor and DeviceColor now
      represent sRGB and device color spaces respectively. DrawTarget only
      accepts DeviceColor, and one can get a DeviceColor from an sRGBColor via
      the ToDeviceColor helper API. The reftests now pass with color
      management enabled for everything (e.g. CSS) instead of just tagged
      raster images.
      
      There will be a follow up patch to enable color management everywhere by
      default on all supported platforms.
      
      Differential Revision: https://phabricator.services.mozilla.com/D64771
      
      --HG--
      extra : moz-landing-system : lando
      91b071ed
  3. 28 Feb, 2020 1 commit
  4. 25 Feb, 2020 2 commits
  5. 24 Feb, 2020 1 commit
  6. 28 Jan, 2020 1 commit
  7. 08 Jan, 2020 1 commit
  8. 06 Jan, 2020 1 commit
  9. 23 Oct, 2019 1 commit
    • Daniel Holbert's avatar
      Bug 1590639 part 5: Fix non-unified build issues in layout/svg. r=emilio · ff09c9db
      Daniel Holbert authored
      This patch:
      - Gives SVGFELeafFrame.cpp and SVGFEUnstyledLeafFrame.cpp the correct
        namespace-prefixing in some static_cast operation, and changes the capturing
        variable to be "auto*" to avoid repeating the long typename.
      - Gives nsSVGContainerFrame.cpp, nsSVGIntegrationUtils.cpp, and
        nsSVGSwitchFrame.cpp a "using namespace mozilla::dom" decl, so that their
        multiple unprefixed SVGElement* usages become valid.
      - Gives nsFilterInstance.h a forward-decl for WrFiltersHolder (which it uses in
        function declarations)
      - Gives nsFilterInstance.cpp an include for nsSVGIntegrationUtils.h to provide
        the WrFiltersHolder type (which it uses).
      - Gives nsSVGPatternFrame.h mozilla-namespace prefixes before all its
        SVGAniated* type usages, to make them valid.
      
      Depends on D50166
      
      Differential Revision: https://phabricator.services.mozilla.com/D50167
      
      --HG--
      extra : moz-landing-system : lando
      ff09c9db
  10. 23 Sep, 2019 1 commit
  11. 13 Aug, 2019 1 commit
  12. 26 Jul, 2019 1 commit
    • Nicholas Nethercote's avatar
      Bug 1563139 - Remove StaticPrefs.h. r=glandium · 18fae65f
      Nicholas Nethercote authored
      This requires replacing inclusions of it with inclusions of more specific prefs
      files.
      
      The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
      and is used in `Codegen.py` because doing something smarter is tricky and
      suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
      still trigger recompilation of all the generated DOM bindings files, but that's
      still a big improvement over trigger recompilation of every file that uses
      static prefs.
      
      Most of the changes in this commit are very boring. The only changes that are
      not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.
      
      Differential Revision: https://phabricator.services.mozilla.com/D39138
      
      --HG--
      extra : moz-landing-system : lando
      18fae65f
  13. 26 Jun, 2019 1 commit
  14. 31 May, 2019 1 commit
  15. 29 May, 2019 1 commit
  16. 26 May, 2019 2 commits
  17. 25 May, 2019 1 commit
    • Gurzau Raul's avatar
      Backed out 31 changesets (bug 1552643, bug 1550422) for xpcshell crash on a CLOSED TREE. · 967bc2a7
      Gurzau Raul authored
      Backed out changeset e30c1aa75529 (bug 1552643)
      Backed out changeset caadcd7e02d3 (bug 1552643)
      Backed out changeset aa7086ab09be (bug 1552643)
      Backed out changeset 0b4029671710 (bug 1550422)
      Backed out changeset a16295296035 (bug 1550422)
      Backed out changeset 3b70307c0db5 (bug 1550422)
      Backed out changeset 69df7818d4a3 (bug 1550422)
      Backed out changeset d98dfc565927 (bug 1550422)
      Backed out changeset 6f0997976944 (bug 1550422)
      Backed out changeset 0edd264464c2 (bug 1550422)
      Backed out changeset 9ea6da7a74ec (bug 1550422)
      Backed out changeset f855f9309c8b (bug 1550422)
      Backed out changeset 1033546224a7 (bug 1550422)
      Backed out changeset ade7384c6186 (bug 1550422)
      Backed out changeset 75b04de7e99c (bug 1550422)
      Backed out changeset 91c3acdb2454 (bug 1550422)
      Backed out changeset 77d2f80257d1 (bug 1550422)
      Backed out changeset e0cd10d35327 (bug 1550422)
      Backed out changeset 097091082423 (bug 1550422)
      Backed out changeset 2f328853c1ab (bug 1550422)
      Backed out changeset f92f2cc29cb1 (bug 1550422)
      Backed out changeset 6dc82f88333d (bug 1550422)
      Backed out changeset c20f66494d69 (bug 1550422)
      Backed out changeset 2ba22cddeb6f (bug 1550422)
      Backed out changeset 3aa72f89e295 (bug 1550422)
      Backed out changeset ab4c4e806977 (bug 1550422)
      Backed out changeset 72e5de040dda (bug 1550422)
      Backed out changeset 7d3c2d486706 (bug 1550422)
      Backed out changeset 132e0b8d8468 (bug 1550422)
      Backed out changeset 54c85ac75dd0 (bug 1550422)
      Backed out changeset d7ba4a18dd54 (bug 1550422)
      967bc2a7
  18. 24 May, 2019 1 commit
  19. 25 May, 2019 1 commit
  20. 23 May, 2019 1 commit
    • Gurzau Raul's avatar
      Backed out 28 changesets (bug 1550422) for marionette AssertionError and... · 74c55553
      Gurzau Raul authored
      Backed out 28 changesets (bug 1550422) for marionette AssertionError and failing browser_policy_hardware_acceleration.js on a CLOSED TREE.
      
      Backed out changeset 5dd10a365ba9 (bug 1550422)
      Backed out changeset 529f5be01ab9 (bug 1550422)
      Backed out changeset b6861d3badf8 (bug 1550422)
      Backed out changeset 059cff1a3dde (bug 1550422)
      Backed out changeset 6ada1116b241 (bug 1550422)
      Backed out changeset ca67e8e45262 (bug 1550422)
      Backed out changeset a1961a51ae44 (bug 1550422)
      Backed out changeset 1c90b9cb3ad4 (bug 1550422)
      Backed out changeset 285fa46e4f26 (bug 1550422)
      Backed out changeset e2938a444234 (bug 1550422)
      Backed out changeset 7a930fc51125 (bug 1550422)
      Backed out changeset 898ed02804fe (bug 1550422)
      Backed out changeset e1b7abc99ae9 (bug 1550422)
      Backed out changeset f781d415cef6 (bug 1550422)
      Backed out changeset 2fef10a7cce5 (bug 1550422)
      Backed out changeset ea64b4d8d4ff (bug 1550422)
      Backed out changeset 86a8ba1b755c (bug 1550422)
      Backed out changeset 9c0c9e80f309 (bug 1550422)
      Backed out changeset 10c153ddbaea (bug 1550422)
      Backed out changeset 60fe635ec2c9 (bug 1550422)
      Backed out changeset a38796266b28 (bug 1550422)
      Backed out changeset 2db647dcdf1c (bug 1550422)
      Backed out changeset 952ddac02972 (bug 1550422)
      Backed out changeset ba46b53643ec (bug 1550422)
      Backed out changeset ca47ef6c59f7 (bug 1550422)
      Backed out changeset f45f471a1a40 (bug 1550422)
      Backed out changeset 371b4da5b771 (bug 1550422)
      Backed out changeset 02fc78890032 (bug 1550422)
      74c55553
  21. 22 May, 2019 2 commits
  22. 27 May, 2019 2 commits
  23. 10 May, 2019 1 commit
  24. 05 Apr, 2019 1 commit
  25. 06 Apr, 2019 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam · 7980a72d
      Emilio Cobos Álvarez authored
      We don't have lossy currentcolor in the style system anymore, except for a
      single property -moz-font-smoothing-background-color.
      
      I could've converted it into a proper StyleColor and thread down all the
      necessary information to the font metrics code.
      
      But it doesn't really seem worth it given it's not exposed to the web, so I just
      did the simplest thing, which is making currentcolor compute to transparent to
      that specific property.
      
      This patch also removes the stores_complex_colors_lossily code and related,
      since now we always can cache computed colors.
      
      Differential Revision: https://phabricator.services.mozilla.com/D26187
      
      --HG--
      extra : moz-landing-system : lando
      7980a72d
  26. 05 Apr, 2019 1 commit
  27. 04 Apr, 2019 1 commit
    • Emilio Cobos Álvarez's avatar
      Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam · 993731e4
      Emilio Cobos Álvarez authored
      We don't have lossy currentcolor in the style system anymore, except for a
      single property -moz-font-smoothing-background-color.
      
      I could've converted it into a proper StyleColor and thread down all the
      necessary information to the font metrics code.
      
      But it doesn't really seem worth it given it's not exposed to the web, so I just
      did the simplest thing, which is making currentcolor compute to transparent to
      that specific property.
      
      This patch also removes the stores_complex_colors_lossily code and related,
      since now we always can cache computed colors.
      
      Differential Revision: https://phabricator.services.mozilla.com/D26187
      
      --HG--
      extra : moz-landing-system : lando
      993731e4
  28. 13 Mar, 2019 1 commit
  29. 26 Feb, 2019 5 commits
  30. 27 Jan, 2019 1 commit
  31. 24 Jan, 2019 1 commit
  32. 21 Jan, 2019 1 commit