1. 20 Dec, 2022 3 commits
  2. 17 Dec, 2022 3 commits
  3. 16 Dec, 2022 2 commits
  4. 15 Dec, 2022 2 commits
  5. 13 Dec, 2022 1 commit
  6. 12 Dec, 2022 4 commits
  7. 08 Dec, 2022 1 commit
  8. 06 Dec, 2022 24 commits
    • henry's avatar
      Bug 41483: Remove the firefox override for appstrings.properties · 1a390e9f
      henry authored and Richard Pospesel's avatar Richard Pospesel committed
      Remove this patch after upstream bugzilla bug 1790187
      1a390e9f
    • henry's avatar
      fixup! Bug 40925: Implemented the Security Level component · 1add8d34
      henry authored
      Make the security level panel and button more accessible:
      
      + We use semantic elements if possible and otherwise set aria attributes. In
        particular, we give the panel a dialog role.
      + We set the "Restore Defaults" button as default if it is shown since
        it is the recommended action.
      + We focus the default button when showing the popup.
      + We handle the case where the security level button is in the overflow
        menu by closing the overflow menu first. Before this key navigation in
        the sub-panel could disrupt the position in the parent panel.
      
      We also simplify the code in general and use HTML for the main content
      of the panel.
      1add8d34
    • henry's avatar
      fixup! Bug 40925: Implemented the Security Level component · bdcaeec7
      henry authored
      Remove SecurityLevels from global scope, no longer try and account for
      missing preference values and stop using the int values outside of
      SecurityLevelPrefs
      bdcaeec7
    • henry's avatar
      fixup! Bug 40925: Implemented the Security Level component · d2b71fb5
      henry authored
      Clean up some unnecessary imports and use var instead of const for
      exported variables.
      d2b71fb5
    • Pier Angelo Vendrame's avatar
      fixup! Bug 40926: Implemented the New Identity feature · b9200609
      Pier Angelo Vendrame authored
      Bug 41448: Use `danger` style for primary button in new identity modal
      b9200609
    • Pier Angelo Vendrame's avatar
      Bug 41435: Add a Tor Browser migration function · 031b265c
      Pier Angelo Vendrame authored
      For now this function only deletes old language packs for which we are
      already packaging the strings with the application.
      031b265c
    • Pier Angelo Vendrame's avatar
      Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser · 67ec3e1f
      Pier Angelo Vendrame authored
      This patch associates the about:manual page to a translated page that
      must be injected to browser/omni.ja after the build.
      The content must be placed in chrome/browser/content/browser/manual/, so
      that is then available at chrome://browser/content/manual/.
      We preferred giving absolute freedom to the web team, rather than having
      to change the patch in case of changes on the documentation.
      67ec3e1f
    • Pier Angelo Vendrame's avatar
      Bug 40458: Implement .tor.onion aliases · e232087c
      Pier Angelo Vendrame authored
      We have enabled HTTPS-Only mode, therefore we do not need
      HTTPS-Everywhere anymore.
      However, we want to keep supporting .tor.onion aliases (especially for
      securedrop).
      Therefore, in this patch we implemented the parsing of HTTPS-Everywhere
      rulesets, and the redirect of .tor.onion domains.
      Actually, Tor Browser believes they are actual domains. We change them
      on the fly on the SOCKS proxy requests to resolve the domain, and on
      the code that verifies HTTPS certificates.
      e232087c
    • Alex Catarineu's avatar
      Bug 21952: Implement Onion-Location · 91f015b8
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Whenever a valid Onion-Location HTTP header (or corresponding HTML
      <meta> http-equiv attribute) is found in a document load, we either
      redirect to it (if the user opted-in via preference) or notify the
      presence of an onionsite alternative with a badge in the urlbar.
      91f015b8
    • Kathleen Brade's avatar
      Bug 30237: Add v3 onion services client authentication prompt · 9c21c3dd
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      When Tor informs the browser that client authentication is needed,
      temporarily load about:blank instead of about:neterror and prompt
      for the user's key.
      
      If a correctly formatted key is entered, use Tor's ONION_CLIENT_AUTH_ADD
      control port command to add the key (via Torbutton's control port
      module) and reload the page.
      
      If the user cancels the prompt, display the standard about:neterror
      "Unable to connect" page. This requires a small change to
      browser/actors/NetErrorChild.jsm to account for the fact that the
      docShell no longer has the failedChannel information. The failedChannel
      is used to extract TLS-related error info, which is not applicable
      in the case of a canceled .onion authentication prompt.
      
      Add a leaveOpen option to PopupNotifications.show so we can display
      error messages within the popup notification doorhanger without
      closing the prompt.
      
      Add support for onion services strings to the TorStrings module.
      
      Add support for Tor extended SOCKS errors (Tor proposal 304) to the
      socket transport and SOCKS layers. Improved display of all of these
      errors will be implemented as part of bug 30025.
      
      Also fixes bug 19757:
       Add a "Remember this key" checkbox to the client auth prompt.
      
       Add an "Onion Services Authentication" section within the
       about:preferences "Privacy & Security section" to allow
       viewing and removal of v3 onion client auth keys that have
       been stored on disk.
      
      Also fixes bug 19251: use enhanced error pages for onion service errors.
      9c21c3dd
    • Richard Pospesel's avatar
      Bug 23247: Communicating security expectations for .onion · 400e6350
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Encrypting pages hosted on Onion Services with SSL/TLS is redundant
      (in terms of hiding content) as all traffic within the Tor network is
      already fully encrypted.  Therefore, serving HTTP pages from an Onion
      Service is more or less fine.
      
      Prior to this patch, Tor Browser would mostly treat pages delivered
      via Onion Services as well as pages delivered in the ordinary fashion
      over the internet in the same way.  This created some inconsistencies
      in behaviour and misinformation presented to the user relating to the
      security of pages delivered via Onion Services:
      
       - HTTP Onion Service pages did not have any 'lock' icon indicating
         the site was secure
       - HTTP Onion Service pages would be marked as unencrypted in the Page
         Info screen
       - Mixed-mode content restrictions did not apply to HTTP Onion Service
         pages embedding Non-Onion HTTP content
      
      This patch fixes the above issues, and also adds several new 'Onion'
      icons to the mix to indicate all of the various permutations of Onion
      Services hosted HTTP or HTTPS pages with HTTP or HTTPS content.
      
      Strings for Onion Service Page Info page are pulled from Torbutton's
      localization strings.
      400e6350
    • Mike Perry's avatar
      Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing · 3054a9a8
      Mike Perry authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      eBay and Amazon don't treat Tor users very well. Accounts often get locked and
      payments reversed.
      
      Also:
      Bug 16322: Update DuckDuckGo search engine
      
      We are replacing the clearnet URL with an onion service one (thanks to a
      patch by a cypherpunk) and are removing the duplicated DDG search
      engine. Duplicating DDG happend due to bug 1061736 where Mozilla
      included DDG itself into Firefox. Interestingly, this caused breaking
      the DDG search if JavaScript is disabled as the Mozilla engine, which
      gets loaded earlier, does not use the html version of the search page.
      Moreover, the Mozilla engine tracked where the users were searching from
      by adding a respective parameter to the search query. We got rid of that
      feature as well.
      
      Also:
      This fixes bug 20809: the DuckDuckGo team has changed its server-side
      code in a way that lets users with JavaScript enabled use the default
      landing page while those without JavaScript available get redirected
      directly to the non-JS page. We adapt the search engine URLs
      accordingly.
      
      Also fixes bug 29798 by making sure we only specify the Google search
      engine we actually ship an .xml file for.
      
      Also regression tests.
      
      squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
      
      Bug 40494: Update Startpage search provider
      
      squash! Omnibox: Add DDG, Startpage, Disconnect, Youtube, Twitter; remove Amazon, eBay, bing
      
      Bug 40438: Add Blockchair as a search engine
      
      Bug 33342: Avoid disconnect search addon error after removal.
      
      We removed the addon in #32767, but it was still being loaded
      from addonStartup.json.lz4 and throwing an error on startup
      because its resource: location is not available anymore.
      3054a9a8
    • Georg Koppen's avatar
      Bug 32658: Create a new MAR signing key · aac96d23
      Georg Koppen authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      It's time for our rotation again: Move the backup key in the front
      position and add a new backup key.
      
      Bug 33803: Move our primary nightly MAR signing key to tor-browser
      
      Bug 33803: Add a secondary nightly MAR signing key
      aac96d23
    • Kathleen Brade's avatar
      Bug 16940: After update, load local change notes. · 98db2b01
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Add an about:tbupdate page that displays the first section from
      TorBrowser/Docs/ChangeLog.txt and includes a link to the remote
      post-update page (typically our blog entry for the release).
      
      Always load about:tbupdate in a content process, but implement the
      code that reads the file system (changelog) in the chrome process
      for compatibility with future sandboxing efforts.
      
      Also fix bug 29440. Now about:tbupdate is styled as a fairly simple
      changelog page that is designed to be displayed via a link that is on
      about:tor.
      98db2b01
    • Kathleen Brade's avatar
      Bug 13379: Sign our MAR files. · 1c92dda2
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Configure with --enable-verify-mar (when updating, require a valid
        signature on the MAR file before it is applied).
      Use the Tor Browser version instead of the Firefox version inside the
        MAR file info block (necessary to prevent downgrade attacks).
      Use NSS on all platforms for checking MAR signatures (instead of using
        OS-native APIs, which Mozilla does on Mac OS and Windows). So that the
        NSS and NSPR libraries the updater depends on can be found at runtime,
        we add the firefox directory to the shared library search path on macOS.
        On Linux, rpath is used by Mozilla to solve that problem, but that
        approach won't work on macOS because the updater executable is copied
        during the update process to a location that is under TorBrowser-Data,
        and the location of TorBrowser-Data varies.
      
      Also includes the fix for bug 18900.
      
      Bug 19121: reinstate the update.xml hash check
      
      Revert most changes from Mozilla Bug 1373267 "Remove hashFunction and
      hashValue attributes from ns...
      1c92dda2
    • Kathleen Brade's avatar
      Bug 4234: Use the Firefox Update Process for Tor Browser. · cc476c1e
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      The following files are never updated:
        TorBrowser/Data/Browser/profiles.ini
        TorBrowser/Data/Browser/profile.default/bookmarks.html
        TorBrowser/Data/Tor/torrc
      Mac OS: Store update metadata under TorBrowser/UpdateInfo.
      Removed the %OS_VERSION% component from the update URL (13047) and
        added support for minSupportedOSVersion, an attribute of the
        <update> element that may be used to trigger Firefox's
        "unsupported platform" behavior.
      Hide the "What's new" links (set app.releaseNotesURL value to about:blank).
      Windows: disable "runas" code path in updater (15201).
      Windows: avoid writing to the registry (16236).
      Also includes fixes for tickets 13047, 13301, 13356, 13594, 15406,
        16014, 16909, 24476, and 25909.
      
      Also fix Bug 26049: reduce the delay before the update prompt is displayed.
      Instead of Firefox's 2 days, we use 1 hour (after which time the update
      doorhanger will be displayed).
      
      Also fix bug 27221: purge the startup cache if the Tor Browser
      version changed (even if the Firefox version and build ID did
      not change), e.g., after a minor Tor Browser update.
      
      Also fix 32616: Disable GetSecureOutputDirectoryPath() functionality.
      
      Bug 26048: potentially confusing "restart to update" message
      
      Within the update doorhanger, remove the misleading message that mentions
      that windows will be restored after an update is applied, and replace the
      "Restart and Restore" button label with an existing
      "Restart to update Tor Browser" string.
      
      Bug 28885: notify users that update is downloading
      
      Add a "Downloading Tor Browser update" item which appears in the
      hamburger (app) menu while the update service is downloading a MAR
      file. Before this change, the browser did not indicate to the user
      that an update was in progress, which is especially confusing in
      Tor Browser because downloads often take some time. If the user
      clicks on the new menu item, the about dialog is opened to allow
      the user to see download progress.
      
      As part of this fix, the update service was changed to always show
      update-related messages in the hamburger menu, even if the update
      was started in the foreground via the about dialog or via the
      "Check for Tor Browser Update" toolbar menu item. This change is
      consistent with the Tor Browser goal of making sure users are
      informed about the update process.
      
      Removed #28885 parts of this patch which have been uplifted to Firefox.
      cc476c1e
    • Arthur Edelstein's avatar
      Bug 12620: TorBrowser regression tests · bfe4ac10
      Arthur Edelstein authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Regression tests for Bug #2950: Make Permissions Manager memory-only
      
      Regression tests for TB4: Tor Browser's Firefox preference overrides.
      
      Note: many more functional tests could be made here
      
      Regression tests for #2874: Block Components.interfaces from content
      
      Bug 18923: Add a script to run all Tor Browser specific tests
      
      Regression tests for Bug #16441: Suppress "Reset Tor Browser" prompt.
      bfe4ac10
    • Richard Pospesel's avatar
      Bug 27476: Implement about:torconnect captive portal within Tor Browser · 6d3dd9b6
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      - implements new about:torconnect page as tor-launcher replacement
      - adds tor connection status to url bar and tweaks UX when not online
      - adds new torconnect component to browser
      - tor process management functionality remains implemented in tor-launcher through the TorProtocolService module
      - adds warning/error box to about:preferences#tor when not connected to tor
      - explicitly allows about:torconnect URIs to ignore Resist Fingerprinting (RFP)
      - various tweaks to info-pages.inc.css for about:torconnect (also affects other firefox info pages)
      
      Bug 40773: Update the about:torconnect frontend page to match additional UI flows
      6d3dd9b6
    • Richard Pospesel's avatar
      Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection · 748130a9
      Richard Pospesel authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      This patch adds a new about:preferences#connection page which allows
      modifying bridge, proxy, and firewall settings from within Tor Browser.
      All of the functionality present in tor-launcher's Network
      Configuration panel is present:
      
       - Setting built-in bridges
       - Requesting bridges from BridgeDB via moat
       - Using user-provided bridges
       - Configuring SOCKS4, SOCKS5, and HTTP/HTTPS proxies
       - Setting firewall ports
       - Viewing and Copying Tor's logs
       - The Networking Settings in General preferences has been removed
      
      Bug 40774: Update about:preferences page to match new UI designs
      748130a9
    • Pier Angelo Vendrame's avatar
      833c3819
    • Kathleen Brade's avatar
      Bug 19273: Avoid JavaScript patching of the external app helper dialog. · 974692d9
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      When handling an external URI or downloading a file, invoke Torbutton's
      external app blocker component (which will present a download warning
      dialog unless the user has checked the "Automatically download files
      from now on" box).
      
      For e10s compatibility, avoid using a modal dialog and instead use
      a callback interface (nsIHelperAppWarningLauncher) to allow Torbutton
      to indicate the user's desire to cancel or continue each request.
      
      Other bugs fixed:
       Bug 21766: Crash with e10s enabled while trying to download a file
       Bug 21886: Download is stalled in non-e10s mode
       Bug 22471: Downloading files via the PDF viewer download button is broken
       Bug 22472: Fix FTP downloads when external helper app dialog is shown
       Bug 22610: Avoid crashes when canceling external helper app downloads
       Bug 22618: Downloading pdf file via file:/// is stalling
      974692d9
    • sanketh's avatar
      Bug 40209: Implement Basic Crypto Safety · 9311ed4f
      sanketh authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Adds a CryptoSafety actor which detects when you've copied a crypto
      address from a HTTP webpage and shows a warning.
      
      Closes #40209.
      
      Bug 40428: Fix string attribute names
      9311ed4f
    • Kathleen Brade's avatar
      Bug 14631: Improve profile access error messages. · d7ae3a46
      Kathleen Brade authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      Instead of always reporting that the profile is locked, display specific
      messages for "access denied" and "read-only file system".
      
      To allow for localization, get profile-related error strings from Torbutton.
      Use app display name ("Tor Browser") in profile-related error alerts.
      d7ae3a46
    • Alex Catarineu's avatar
      Add TorStrings module for localization · 643de037
      Alex Catarineu authored and Pier Angelo Vendrame's avatar Pier Angelo Vendrame committed
      643de037