Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2023-11-07T16:50:23Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42154Empty the clipboard on browser shutdown only if content comes from private br...2023-11-07T16:50:23Zcypherpunks1Empty the clipboard on browser shutdown only if content comes from private browsing windowsThe user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.The user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42138Disable apz.overscroll.enabled pref2023-10-09T15:40:51ZrichardDisable apz.overscroll.enabled prefDisable overscroll on all platforms to minimize touch-related fingerprinting entropy.Disable overscroll on all platforms to minimize touch-related fingerprinting entropy.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42133Remove "Total Cookie Protection" popup2023-10-04T18:44:39ZclairehurstRemove "Total Cookie Protection" popup<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
On a fresh install, turn on cookie banner protection and then open a site (I did youtube.com)
### Steps to reproduce...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
On a fresh install, turn on cookie banner protection and then open a site (I did youtube.com)
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Get a fresh install of tor browser for android
2. Connect to tor and visit a site (I did youtube.com, I'm not sure if the site matters)
3. Turn on cookie banner protection
4. Go back to the site, (it should reload)
5. Notice popup near the bottom of the screen about "Total Cookie Protection"
Video of reproduction **Warning: flashing text and icons at the end" https://share.riseup.net/#-UqKADXExnqlAUqdPnpiqg
### What is the current bug behavior?
**What actually happens.**
There is a popup about "Total Cookie Protection"
### What is the expected behavior?
**What you want to see instead**
There should be not be Popup, we do not use this feature.
### Environment
**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.**
**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
macOS Ventura 13.5.2, Pixel 7 Pro API 34 emulator
### Relevant logs and/or screenshots
![image](/uploads/5a1d84296645114eacd380884fe8892d/image.png)
Tapping on "Learn more" results in this
**Warning!! flashing text and Icons**
![Screen_Recording_2023-09-27_at_11.52.38_AM](/uploads/2f417decb380f5a6e78e9d4ce1032fd1/Screen_Recording_2023-09-27_at_11.52.38_AM.mov){width=50%}clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42130Add support for specifying the branch in `tb-dev rebase-on-default`2023-10-03T15:36:02ZhenryAdd support for specifying the branch in `tb-dev rebase-on-default``tb-dev rebase-on-default` is useful when you want to rebase on a new upstream branch. Currently, it only rebases the currently checked-out branch. It would be useful if it could also work on any specified branch.`tb-dev rebase-on-default` is useful when you want to rebase on a new upstream branch. Currently, it only rebases the currently checked-out branch. It would be useful if it could also work on any specified branch.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42121Remove "Open in app" feature2023-10-04T18:45:01ZclairehurstRemove "Open in app" feature<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
There is a feature to open the current site in the relevant already installed app (i.e. youtube.com -> youtube app) whi...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
There is a feature to open the current site in the relevant already installed app (i.e. youtube.com -> youtube app) which is a likability issue, potentially de-anonymizing the user by associating the tor session with the new clear net one. This feature should be removed.
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Open a site (e.g. youtube.com)
2. Go to settings
3. Tap on "Open in app"
4. The app should now open with the current site loaded
### What is the current bug behavior?
**What actually happens.**
The site is loaded into the installed app, potentially de-anonymizing the user
### What is the expected behavior?
**What you want to see instead**
The "Open in app" option removed
### Environment
**Which operating system are you using? For example: Debian GNU/Linux 10.1, Windows 10, Ubuntu Xenial, FreeBSD 12.2, etc.**
**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
macOS Ventura 13.5.2, Pixel 7 pro API 34 emulator, installed from source code via git
### Relevant logs and/or screenshots
![Screenshot_2023-09-21_at_2.47.38_PM](/uploads/35312b271ad52e59a1f20525c558285a/Screenshot_2023-09-21_at_2.47.38_PM.png){width=25%}
![Screenshot_2023-09-21_at_2.47.59_PM](/uploads/dda169366dcc590f0ff6f46caaefbdb5/Screenshot_2023-09-21_at_2.47.59_PM.png){width=25%}![Screenshot_2023-09-21_at_3.24.31_PM](/uploads/04097c0f8e9c0656eb5357f8936366fb/Screenshot_2023-09-21_at_3.24.31_PM.png)clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42114Disable Allow sharing current tab URL from Android's Recents screen in privat...2023-10-03T10:54:03ZrichardDisable Allow sharing current tab URL from Android's Recents screen in private browsing modeSeems to be a pixel-only Android feature. See tor-browser#42006Seems to be a pixel-only Android feature. See tor-browser#42006Dan BallardDan Ballardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42110Add a utility module for shared UI methods needed for several tor browser com...2023-10-03T10:54:05ZhenryAdd a utility module for shared UI methods needed for several tor browser componentsIn https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42091 we want to share the onion domain shortening in several places.
We want to create a shared module for this method, and as a place to share other tor-related ut...In https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42091 we want to share the onion domain shortening in several places.
We want to create a shared module for this method, and as a place to share other tor-related utility methods if we need them in the future.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42095Implement Android application icons2023-10-04T18:44:55ZnicobImplement Android application iconsTor Browser application icons have gotten a refresh from the UX & Design team! Can we push these new assets to TB for **android** as well please? @dan would you mind taking a look at what I'm sharing in this folder for stable and whether...Tor Browser application icons have gotten a refresh from the UX & Design team! Can we push these new assets to TB for **android** as well please? @dan would you mind taking a look at what I'm sharing in this folder for stable and whether this is sufficient or overkill for what assets you need? These are exports directly from an official Google Material 3 template on figma, but last time we tried to do this for another project, we came across some issues on the implementation side. If these look good, I'll go ahead and export for alpha and nightly too :)
android app icons (all releases): [Nextcloud](https://nc.torproject.net/s/BiFJzyTdmf7N8c5)clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42094Disable `media.aboutwebrtc.hist.enabled` as security in-depth2023-10-03T15:37:50ZrichardDisable `media.aboutwebrtc.hist.enabled` as security in-depthNot necessary, but lets ensure history is truly off in case it gets flipped on upstream (currently only enabled in Nightly).Not necessary, but lets ensure history is truly off in case it gets flipped on upstream (currently only enabled in Nightly).richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42092Onion services key table display problems.2023-10-03T13:27:36ZhenryOnion services key table display problems.The table in the "Onion Service Keys" dialog has a few issues:
1. ~~Columns are missing their label.~~ Moved to https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42109
2. Does not grow to fill window width.
3. Does not...The table in the "Onion Service Keys" dialog has a few issues:
1. ~~Columns are missing their label.~~ Moved to https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42109
2. Does not grow to fill window width.
3. Does not grow vertically to fill window height.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42091Onion authorization prompt overflows2023-10-03T13:27:36ZhenryOnion authorization prompt overflowsThe onion auth prompt overflows because the [default notification width](https://searchfox.org/mozilla-esr115/rev/43b43b07ace3b2b222db6c0664d4cc1ec75f42db/toolkit/themes/shared/popupnotification.css#51) is not wide enough for the ".onion...The onion auth prompt overflows because the [default notification width](https://searchfox.org/mozilla-esr115/rev/43b43b07ace3b2b222db6c0664d4cc1ec75f42db/toolkit/themes/shared/popupnotification.css#51) is not wide enough for the ".onion" address.
![Screenshot of overflowing onion authorization prompt](/uploads/d80ec0d7af0c5b1829a64f50cf6d03a3/onion-auth.png)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42088Implement Linux application icons2023-10-03T13:27:37ZnicobImplement Linux application iconsTor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Linux** assets:
* [stable](https://nc.torproject.net/s/GSZJXBJQNBaRWwk)
* [alpha](https://nc.torproject...Tor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Linux** assets:
* [stable](https://nc.torproject.net/s/GSZJXBJQNBaRWwk)
* [alpha](https://nc.torproject.net/s/j2WMeb93LkagoHp)
* [nightly](https://nc.torproject.net/s/fQXY5jc6jxo6x9F)
Note that there is a sub-folder within each of the respective release glyphs that are specific to the linux requirements per the [GNOME hig](https://developer.gnome.org/hig/guidelines/ui-icons.html).henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42087Implement Windows application icons2023-10-03T13:27:38ZnicobImplement Windows application iconsTor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Windows** assets:
* [stable](https://nc.torproject.net/s/4FqccSRweqgt2Wr)
* [alpha](https://nc.torproje...Tor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Windows** assets:
* [stable](https://nc.torproject.net/s/4FqccSRweqgt2Wr)
* [alpha](https://nc.torproject.net/s/zrd9B5H3RKTTA9o)
* [nightly](https://nc.torproject.net/s/fpAyWDfMm9cRtx8)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42079TorConnect: handle switching from Bootstrapped to Configuring state2023-10-03T13:27:40ZhenryTorConnect: handle switching from Bootstrapped to Configuring statehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests/721 is going to enable switching from the "Bootstrapped" state to the "Configuring" state when the underlying tor process exits after bootstrapping has first suc...https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests/721 is going to enable switching from the "Bootstrapped" state to the "Configuring" state when the underlying tor process exits after bootstrapping has first succeeded. The idea is that we can re-bootstrap with the new tor process.
This could probably do with some general testing to see how well we recover in this case.
We also have some UI elements that assumed we would never leave the "Bootstrapped" state once it was reached. We should change them now that this assumption is broken.
/cc @pierov @richardhenryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42076Theme is visible in options, but shouldn't be2023-12-05T22:05:58ZclairehurstTheme is visible in options, but shouldn't be### Summary
Due to anti finger printing, we don't allow the user to change the theme (its always purple, not dark or light). We have a setting to change the theme that doesn't do anything and should be removed.
### Steps to reproduce:
...### Summary
Due to anti finger printing, we don't allow the user to change the theme (its always purple, not dark or light). We have a setting to change the theme that doesn't do anything and should be removed.
### Steps to reproduce:
1. Launch tor browser for android
2. Connect to tor
3. Tap on the ⋮ button in the bottom right, then navigate to > Settings > Customize and notice that there is a Theme option
### What is the current bug behavior?
There is an option to set the theme to Light, Dark, or to follow the device theme (shown in screenshot below)
### What is the expected behavior?
There should not be an option to set the theme, because we don't use it
### Environment
Which operating system are you using? macOS Ventura 13.5.1, apple M2 Max, Pixel 7 pro API 34 (arm 64 emulator)
Which installation method did you use? Git
### Relevant logs and/or screenshots
![Screenshot_2023-09-05_at_4.25.39_PM](/uploads/6a6e64b952649dd74435333e3d2e02a1/Screenshot_2023-09-05_at_4.25.39_PM.png)clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42075Fix link spacing and underline on new homepage2023-10-03T13:27:42ZdonutsFix link spacing and underline on new homepageIn about:preferences for example, there is a standard gap between the string and link of around 10px. The underline style also looks more noticeable in about:preferences too – i.e. it seems to be offset slightly against the text, and is ...In about:preferences for example, there is a standard gap between the string and link of around 10px. The underline style also looks more noticeable in about:preferences too – i.e. it seems to be offset slightly against the text, and is thicker.
Could we update the link style on the new homepage (i.e. new tab page; about:tor) to match please?
(Also, as mentioned previously – the new homepage should be using system fonts like other internal pages rather than Arial/Helvetica – however this may have been fixed since the last macOS Nightly already)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42074YEC 2023 Takeover for Android Stable2023-11-27T14:41:42ZnicobYEC 2023 Takeover for Android StableEach year from <span dir="">\~</span>mid-October through the end of December, the Tor Project runs its year-end fundraising campaign (aka "YEC"). This is the time during which we raise the most money per year from individual donors. A ke...Each year from <span dir="">\~</span>mid-October through the end of December, the Tor Project runs its year-end fundraising campaign (aka "YEC"). This is the time during which we raise the most money per year from individual donors. A key strategy in this campaign is a branded takeover of about:tor (desktop + mobile) that includes the year-end campaign "mini brand," new assets, a fundraising message, and a donate button. cc @richard
Key dates:
* **Monday, October 16** - gated YEC takeover of about:tor appears
* **Monday, November 13** - second gated YEC takeover of about:tor appears
**Please note that the current illustration within these designs is a placeholder**, and the final illustration asset will be shared soon when it's finalized. Aside from that, everything here has been approved to begin implementation:
* Figma files for inspection: [23 Year End Campaign](https://www.figma.com/file/f8KvYdzeZPvs4KpJMLJumD/23-Year-End-Campaign?type=design&node-id=27%3A11557&mode=design&t=DzYvge9oyxXoCu6K-1)
* Illustration:[yec-illustration-android.svg](/uploads/093aeed7ba10b9ae7b3d1675d67c9229/yec-illustration-android.svg)
* heart svg for button:[heart.svg](/uploads/181b77f5cd7abad67379bbf4e27df3f9/heart.svg)
* Font: `Roboto`
* Background color: `#1F0333`
* Text color: `#FBFBFE`
* Button background color: `#FFBD4F`
* Button text color: `#1F0333`
* Can we anchor the donate button to the main content area of donate.torproject.org again like last year? @smith please chime in here if there's a specific redirect URL link you're using for metrics
Last year's ticket for reference: [YEC 2022 Takeover for Android Stable](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41302 "YEC 2022 Takeover for Android Stable")
about:tor android mockup:
![about_tor-android2x.png](/uploads/e6c3555a5d60c503b5ee73d0d49bae43/about_tor-android2x.png){width=298 height=629}
about:tor android LTR mockup:
![about_tor-android-LTR2x.png](/uploads/b811c4ae136bec35bbc0e6a0ecbf321c/about_tor-android-LTR2x.png){width=301 height=636}Year End Campaign 2023Dan BallardDan Ballardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42073Add simplified onion pattern to the new homepage2023-10-03T13:27:43ZdonutsAdd simplified onion pattern to the new homepageSince we never got round to finishing and handing over the wallpaper gallery, let's retain a simplified version of the onion patter on the homepage for the time being instead:
![new-tab-classic](/uploads/fdf07fa8b76f650fbbc52dd392593eb0...Since we never got round to finishing and handing over the wallpaper gallery, let's retain a simplified version of the onion patter on the homepage for the time being instead:
![new-tab-classic](/uploads/fdf07fa8b76f650fbbc52dd392593eb0/new-tab-classic.png)
Like the existing onion pattern, it should repeat horizontally. Here's an SVG exported from Figma:
- [classic-pattern.svg](/uploads/141f3d7139fbfea739f11744f2448814/classic-pattern.svg)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42072YEC 2023 Takeover for Desktop Stable2023-11-27T13:52:36ZnicobYEC 2023 Takeover for Desktop StableEach year from <span dir="">\~</span>mid-October through the end of December, the Tor Project runs its year-end fundraising campaign (aka "YEC"). This is the time during which we raise the most money per year from individual donors. A ke...Each year from <span dir="">\~</span>mid-October through the end of December, the Tor Project runs its year-end fundraising campaign (aka "YEC"). This is the time during which we raise the most money per year from individual donors. A key strategy in this campaign is a branded takeover of about:tor (desktop + mobile) that includes the year-end campaign "mini brand," new assets, a fundraising message, and a donate button. cc @henry
Key dates:
* **Monday, October 16** - gated YEC takeover of about:tor appears
* **Monday, November 13** - second gated YEC takeover of about:tor appears
**Please note that the current illustration within these designs is a placeholder**, and the final illustration asset will be shared soon when it's finalized. Aside from that, everything here has been approved to begin implementation:
* Figma files for inspection: [23 Year End Campaign](https://www.figma.com/file/f8KvYdzeZPvs4KpJMLJumD/23-Year-End-Campaign?type=design&node-id=27%3A11557&mode=design&t=DzYvge9oyxXoCu6K-1)
* Illustration:[yec-illustration-desktop.svg](/uploads/ba0b67262292a53cc67a1fbe02b4003e/yec-illustration-desktop.svg)
* Font: `SF Pro`
* Background color: `#1F0333`
* Can we anchor the donate button to the main content area of donate.torproject.org again like last year? @smith please chime in here if there's a specific redirect URL link you're using for metrics
Last year's ticket for reference: [YEC 2022 Takeover for Desktop Stable](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41303)
about:tor desktop:
![about_tor-desktop2x.png](/uploads/4beb1ed4f74cdcc1a49da980d82c628b/about_tor-desktop2x.png){width="832" height="640"}
about:tor desktop LTR:
![about_tor-desktop-LTR2x.png](/uploads/45646d5f144f8b0cad0d7e93056693b5/about_tor-desktop-LTR2x.png){width="834" height="641"}Year End Campaign 2023henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42057Disable Platform text-recognition functionality2023-10-03T15:38:02ZrichardDisable Platform text-recognition functionalityMozilla's text recognition API is currently macOS only and calls out to these platfoms apis: https://developer.apple.com/documentation/vision/recognizing_text_in_images
In the future this could/should be replaced with local in-process O...Mozilla's text recognition API is currently macOS only and calls out to these platfoms apis: https://developer.apple.com/documentation/vision/recognizing_text_in_images
In the future this could/should be replaced with local in-process OCR system like teseract ( https://github.com/tesseract-ocr/tesseract ). For now let's neuter the global check to hard return false always and prevent all the dependent code paths from being taken.richardrichard