Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2024-03-19T17:46:34Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42467compat: don't mismatch userAgent headers in Mac/Linux2024-03-19T17:46:34ZThorincompat: don't mismatch userAgent headers in Mac/LinuxTB version of https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/234
recap:
- check progress MB
- assuming we want this for TB, decide if we want it for all slider settings or just safest
adding under ~Fingerprinti...TB version of https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/issues/234
recap:
- check progress MB
- assuming we want this for TB, decide if we want it for all slider settings or just safest
adding under ~Fingerprinting although we're not actually addressing thathttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42362"New window" missing from File menu on macOS2024-01-10T07:30:30Zdonuts"New window" missing from File menu on macOSAt some point we seem to have lost the option to open a new window via the File menu on macOS.
[macos-file-menu](/uploads/aa06119db881fb40797f7500c3057e1c/macos-file-menu.png)At some point we seem to have lost the option to open a new window via the File menu on macOS.
[macos-file-menu](/uploads/aa06119db881fb40797f7500c3057e1c/macos-file-menu.png)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42347Add a banner warning users about the upcoming EOL for Win ≤8.1 and macOS ≤10.142024-02-01T14:39:44ZPier Angelo VendrameAdd a banner warning users about the upcoming EOL for Win ≤8.1 and macOS ≤10.1413.5 will be the last Windows version, Mozilla bumped the requirement to Windows 10.
We could add a warning to Windows 7 users somewhere, e.g., in about:tor.
We can check the version of the OS with `Services.sysinfo.getProperty("versio...13.5 will be the last Windows version, Mozilla bumped the requirement to Windows 10.
We could add a warning to Windows 7 users somewhere, e.g., in about:tor.
We can check the version of the OS with `Services.sysinfo.getProperty("version")`. It's `10.0` in my Windows 10 VM, and `6.1` in my Windows 7 VM.
Maybe the first versions of Windows 10 also use 6.1, but if that's the case, they're unsupported too.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42200Command+mouse-scroll no longer Zooms In/Out the text, page, or image size upo...2023-11-01T20:02:14ZjenknessCommand+mouse-scroll no longer Zooms In/Out the text, page, or image size upon update to v13.0 on MacMacOS 10.13
Tor Browser version 13.0
1) Go to any Web page, or open image in separate page or tab.
2) Put mouse pointer over page or image.
3) Hold Command key and use scroll wheel. Text and / or image no longer zooms in or out.
Qui...MacOS 10.13
Tor Browser version 13.0
1) Go to any Web page, or open image in separate page or tab.
2) Put mouse pointer over page or image.
3) Hold Command key and use scroll wheel. Text and / or image no longer zooms in or out.
Quick-fix Solution: Use keyboard shortcut instead, or go back to any version before 13.0 and prevent updates, then mouse-scroll-zoom functionality returns.clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42197TBB 13.0 startup issue on MacOS 13.4 - Cc[aContract] is undefined2023-12-20T20:55:34ZSilvio RhattoTBB 13.0 startup issue on MacOS 13.4 - Cc[aContract] is undefinedAn user reported the following error when opening TBB 1.3 on MacOS Ventura 13.4:
```
Tor exited during startup. This might be due to an error in your torrc file,
a bug in Tor or another program on your system, or faulty hardware.
Until ...An user reported the following error when opening TBB 1.3 on MacOS Ventura 13.4:
```
Tor exited during startup. This might be due to an error in your torrc file,
a bug in Tor or another program on your system, or faulty hardware.
Until you fix the underlying problem and restart Tor, Tor Browser will not start.
```
They also opened the browser console (Ctrl+Shift+J on Windows/Linux) and shared the details:
```
TorProvider: Cannot connect to the control port Error: The tor process exited before the first connection
<anonymous> resource://gre/modules/TorProvider.sys.mjs:613
<anonymous> resource://gre/modules/TorProvider.sys.mjs:488
#processExitedUnexpectedly resource://gre/modules/TorProcess.sys.mjs:215
#watchProcess resource://gre/modules/TorProcess.sys.mjs:197
TorProvider.sys.mjs:196
Error: The tor process exited before the first connection TorProvider.sys.mjs:613:16
TypeError: Cc[aContract] is undefined
XPCOMUtils.sys.mjs:137:9
```https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42154Empty the clipboard on browser shutdown only if content comes from private br...2023-11-07T16:50:23Zcypherpunks1Empty the clipboard on browser shutdown only if content comes from private browsing windowsThe user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.The user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42147Add browser.helperApps.deleteTempFileOnExit to our profile2023-10-31T05:46:31ZThorinAdd browser.helperApps.deleteTempFileOnExit to our profilefrom the almighty AF
```js
/* 2603: remove temp files opened with an external application
* [1] https://bugzilla.mozilla.org/302433 ***/
user_pref("browser.helperApps.deleteTempFileOnExit", true);
```
cc: @pierovfrom the almighty AF
```js
/* 2603: remove temp files opened with an external application
* [1] https://bugzilla.mozilla.org/302433 ***/
user_pref("browser.helperApps.deleteTempFileOnExit", true);
```
cc: @pierovPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42078Implement MacOS application icons2023-10-03T13:27:41ZnicobImplement MacOS application iconsTor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **MacOS** assets:
* [stable](https://nc.torproject.net/s/NzAAoSDsFnzJrin)
* [alpha](https://nc.torproject...Tor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **MacOS** assets:
* [stable](https://nc.torproject.net/s/NzAAoSDsFnzJrin)
* [alpha](https://nc.torproject.net/s/qKppJnTkgMwJRqq)
* [nightly](https://nc.torproject.net/s/MPMCZeyL8WpCc9H)
* [document icons](https://nc.torproject.net/s/QKxtb94Z49DQF4r)Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42057Disable Platform text-recognition functionality2023-10-03T15:38:02ZrichardDisable Platform text-recognition functionalityMozilla's text recognition API is currently macOS only and calls out to these platfoms apis: https://developer.apple.com/documentation/vision/recognizing_text_in_images
In the future this could/should be replaced with local in-process O...Mozilla's text recognition API is currently macOS only and calls out to these platfoms apis: https://developer.apple.com/documentation/vision/recognizing_text_in_images
In the future this could/should be replaced with local in-process OCR system like teseract ( https://github.com/tesseract-ocr/tesseract ). For now let's neuter the global check to hard return false always and prevent all the dependent code paths from being taken.richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42035Update tools/torbrowser/ scripts to support macOS dev environment2023-10-03T13:27:54ZrichardUpdate tools/torbrowser/ scripts to support macOS dev environmentWe have some lovely scripts in `tools/torbrowser` to support building firefox and deploying over a local dev install of Tor Browser. basically They download the latest alpha and deploy local dev builds of firefox over it with proper tor ...We have some lovely scripts in `tools/torbrowser` to support building firefox and deploying over a local dev install of Tor Browser. basically They download the latest alpha and deploy local dev builds of firefox over it with proper tor and PT integration.
The only problem is they assume an x86_64 Linux dev environment!
We should add support for a macOS dev environment.clairehurstclairehursthttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41982Review Mozilla 1762392: Add Cocoa platform support for paste files2023-10-05T17:15:48ZrichardReview Mozilla 1762392: Add Cocoa platform support for paste filesLink: https://bugzilla.mozilla.org/show_bug.cgi?id=1762392
We should review whether we want this feature, and if there are considerations we should take like we did with our other clipboard patches (though those are meant to prevent exf...Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1762392
We should review whether we want this feature, and if there are considerations we should take like we did with our other clipboard patches (though those are meant to prevent exfiltration of data out of the browser, whereas this is meant for copying files into the browser)ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41955Update macOS volume window background2023-10-03T13:28:31ZdonutsUpdate macOS volume window backgroundOnce the new application icons have been finalized in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40417, and since we're also updating the Windows installer icon in https://gitlab.torproject.org/tpo/applications/t...Once the new application icons have been finalized in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40417, and since we're also updating the Windows installer icon in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41658, we should update the volume window background using the layout developed for Mullvad Browser for ~"13.0 stable" too.Dan BallardDan Ballard2023-08-18https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41949Review Mozilla 1782578: Implement a context menu modal for text recognition2023-10-05T12:53:16ZrichardReview Mozilla 1782578: Implement a context menu modal for text recognitionLink: https://bugzilla.mozilla.org/show_bug.cgi?id=1782578
More text recognition (see linked issues)Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1782578
More text recognition (see linked issues)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41948Review Mozilla 1782981: Hide the text recognition context menu if the macOS v...2023-10-05T17:15:48ZrichardReview Mozilla 1782981: Hide the text recognition context menu if the macOS version doesn't support APIsLink: https://bugzilla.mozilla.org/show_bug.cgi?id=1782981
Now this makes me suspicious re privacy/linkability/etc if Firefox is calling out to platform-specific APIs. We should evaluate if we just disable text-recognition outright.Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1782981
Now this makes me suspicious re privacy/linkability/etc if Firefox is calling out to platform-specific APIs. We should evaluate if we just disable text-recognition outright.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41872Make IPC default again on Linux and macOS2024-02-07T09:02:11ZPier Angelo VendrameMake IPC default again on Linux and macOSAt a certain point, Tor Browser switched to Unix sockets both for SOCKS and control where supported (Linux and macOS): #20111.
Then TCP was restored to reuse the same tor daemon for TorBirdy: tor-launcher@485ba9456724e38b661c90dccc90322...At a certain point, Tor Browser switched to Unix sockets both for SOCKS and control where supported (Linux and macOS): #20111.
Then TCP was restored to reuse the same tor daemon for TorBirdy: tor-launcher@485ba9456724e38b661c90dccc90322c74fa405f.
Also, Tor Browser had some problems when `+` and `__` weren't yet a thing for the control port and socks port parameters: #20761.
Now, these aren't problems anymore, amd IPC still seems a good idea (easier to audit for leaks, or less leaks in general - according to @JeremyRand - and allows for multiple Tor Browsers at the same time, since the default branch tries to make a unique filename).
Also, everything is already in place, we just need to flip `extensions.torlauncher.control_port_use_ipc` and `extensions.torlauncher.socks_port_use_ipc`.
**We should make them `sticky`, so that any previous user value is kept in `user.js`.**
The differences in code between Windows and the other OS's are minimal:
- the control port uses `nsISocketTransportService.createUnixDomainTransport` instead of `nsISocketTransportService.createTransport`, but both return the same type of abstraction (`nsISocketTransport`);
- for SOCKS, `network.proxy.socks` is set to `file:///....`, instead of having the IP address/hostname;
- different `+__ControlPort` and `+__SocksPort` are passed to `tor`.
I think it should be pretty safe to use them. I've been doing that on my developer build in these days and everything kept working (but I also have a number of other changes for the torbutton refactor/removal).
So, in today's meeting we decided to prioritize this preference flip ASAP, already for 13.0a1, to have this in test for the 3 months before the 13.0 release.
I will do after !694 is merged.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41839Figure out how to run multiple release channels on MacOS2024-02-08T16:26:56ZdonutsFigure out how to run multiple release channels on MacOSBy default, each Tor Browser release channel has the same app name. This makes it challenging to keep multiple versions installed and running in MacOS' applications folder.
Other browsers use distinct app names based on their release ch...By default, each Tor Browser release channel has the same app name. This makes it challenging to keep multiple versions installed and running in MacOS' applications folder.
Other browsers use distinct app names based on their release channel, e.g.
Firefox:
- Firefox
- Firefox Beta
- Firefox Nightly
Chrome:
- Google Chrome
- Google Chrome Beta
- Google Chrome Canary
Brave:
- Brave Browser
- Brave Browser Beta
- Brave Browser Nightly
So I have two questions:
1. What's a short-term workaround that allows me to keep multiple release channels installed with different library files (e.g. TorBrowser-Data folders), other than renaming the app manually, which seems to break things?
2. Would renaming each release channel to Tor Browser; Tor Browser Alpha and Tor Browser Nightly fix this problem in the long term?https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41685macOS can open links in new tabs when set as default browser (despite remotin...2023-03-21T14:30:03ZrichardmacOS can open links in new tabs when set as default browser (despite remoting being disabled)Haven't had a chance to debug too deeply, but the best guess is that the relevant code path is here:
- https://searchfox.org/mozilla-central/source/toolkit/components/remote/nsMacRemoteServer.mm#34
This code should likely be checking fo...Haven't had a chance to debug too deeply, but the best guess is that the relevant code path is here:
- https://searchfox.org/mozilla-central/source/toolkit/components/remote/nsMacRemoteServer.mm#34
This code should likely be checking for the MOZ_NO_REMOTE env variable or something at that entry point and bailing early if it is present. I'm 90% sure this is an upstream bug so we should uplift once we have a patch.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41638Tor Browser 12.02 checking for update thinks it's current2023-02-17T17:05:14ZPaul Garrett HugelTor Browser 12.02 checking for update thinks it's current<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. open tor browser
2. select ...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
**Summarize the bug encountered concisely.**
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. open tor browser
2. select about tor browser --> checking for updates--> tor browser is up to date
3. Error 12.0.3 is available![tor_browser_update_status](/uploads/5ad252a204476ccaa26c5565ef95b837/tor_browser_update_status.png)
### What is the current bug behavior?
**What actually happens.**
Thinks its running most up to date browser version 12.0.2
### What is the expected behavior?
**What you want to see instead**
Update available 12.0.3--> do you want to update?
### Environment
**Which operating system are you using?
MacOS 11.7.4
**Which installation method did you use? Distribution package (apt, pkg, homebrew), from source tarball, from Git, etc.**
https://www.torproject.org/download/
### Relevant screenshots
attachedhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41573Startup window get letterboxed on MacOS in some screen resolutions (regression)2023-02-15T22:37:05Zma1Startup window get letterboxed on MacOS in some screen resolutions (regression)Startup window (_but not the windows opened after that one_) with some display / resolutions / scaling factors reports a fractional height for the browser container element, causing the content to be unnecessarily letterboxed vertically....Startup window (_but not the windows opened after that one_) with some display / resolutions / scaling factors reports a fractional height for the browser container element, causing the content to be unnecessarily letterboxed vertically.
We introduced subpixel measurements to cope with rounding errors while still using margins to shrink the content, and this is probably the cause of the regression (even though it puzzles me that only the first window gets this weird height, which is the _root_ cause).
However, now that we directly set the size of the browser element we can go back using integer sizes and therefore remove this regression.
/cc @thorin for additional QA on (unlikely) effectiveness regressions (I can check by myself on my MacBook whether this usability regression is fixed).ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41569Launch directly the real tor also on macOS, rather than the shim script2023-01-30T08:35:42ZPier Angelo VendrameLaunch directly the real tor also on macOS, rather than the shim scriptOn macOS, we don't launch `tor`, but we rename it to `tor.real`, and we invoke it through another script.
The script is pretty old, still contains Python stuff for obfs3 and we can do whatever it does in `TorProcess.jsm`.
So, I propose...On macOS, we don't launch `tor`, but we rename it to `tor.real`, and we invoke it through another script.
The script is pretty old, still contains Python stuff for obfs3 and we can do whatever it does in `TorProcess.jsm`.
So, I propose we keep decluttering tor-browser-build.git, and do the needed changes on tor-browser.git.
See also legacy/trac#10030.Pier Angelo VendramePier Angelo Vendrame