Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2024-01-30T13:24:57Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41917Make the appearance of letterboxing look more intentional2024-01-30T13:24:57Zma1Make the appearance of letterboxing look more intentionalCurrent letterboxing appearance looks like a buggy window to some users.
We want to make it look more intentional by:
1. adding a shadow to the content area to make it "pop" from the letterboxing background
2. adding a themed gradient t...Current letterboxing appearance looks like a buggy window to some users.
We want to make it look more intentional by:
1. adding a shadow to the content area to make it "pop" from the letterboxing background
2. adding a themed gradient to the letterboxing backgroundma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41916Letterboxing preferences UI2024-03-21T13:24:49Zma1Letterboxing preferences UIAs discussed [here](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32324#note_2899463) and [here](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32324#note_2925080), some user might prefer to hav...As discussed [here](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32324#note_2899463) and [here](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32324#note_2925080), some user might prefer to have the letterboxing content vertically centered.
It has been suggested that this should be an user-accessible option, under a "Letterboxing" preference section including also an "Always remember last window" toggle.
Backend work:
- Letterboxing centering #41917
- Remember last window option #41918
[Figma Design](https://www.figma.com/file/rWgMwiiFTDFp4ujuP3PKbq/Tor-Browser-13.5?type=design&node-id=202-1221&mode=design&t=W4c43um0jGlUramZ-4)
Initial comments:
@ruihildt
> don't think the letterboxing setting belongs to the "Privacy and security" section: I suggest we move it to "Website and appearance".
@ma1
> 1. would prefer to name the thing to be centered "web content" or "web page" instead of "website"
> 2. What about having a "What's this" tooltip and/or a question mark cursor when hovering the letterbox area, which would open the preference panel if clicked?
Intentionally omitting the release target (the parent issue has 13.5), leaving it to @duncan & @richard .
/cc @thorinma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41915TB13.0a1 alpha: missing icon in change language2023-07-27T19:30:24ZThorinTB13.0a1 alpha: missing icon in change languageTB12
-![Image_3](/uploads/274ec52ae89843265244fc7dddfd731c/Image_3.png)
TB13
- ![Image_2](/uploads/f6b9db503d5a44bee5584c57b2023ab8/Image_2.png)TB12
-![Image_3](/uploads/274ec52ae89843265244fc7dddfd731c/Image_3.png)
TB13
- ![Image_2](/uploads/f6b9db503d5a44bee5584c57b2023ab8/Image_2.png)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41913Add validation and improve the formatting of manually added bridge lines2024-02-27T19:07:40ZdonutsAdd validation and improve the formatting of manually added bridge linesThe updated copy was added in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40552, but not the trickier parts relating to the fancy formatting and validation going on in the text box.
See the Figma file here: [Figm...The updated copy was added in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40552, but not the trickier parts relating to the fancy formatting and validation going on in the text box.
See the Figma file here: [Figma link](https://www.figma.com/file/RS584DcR4emXrw1F8g3l5x/Tor-Browser-12.5?node-id=102%3A13802&t=41hhHGHnJTkIHnmo-1)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41912"Use Current Bridges" is shown for users even when there aren't any current b...2023-10-10T09:14:26ZNah"Use Current Bridges" is shown for users even when there aren't any current bridgesDuring in person testings with users in Mexico, some users were confused by the option `Use Current Briges`. They thought by turning on this switch button, they would have bridges working, even tho they haven't set any bridges yet. Is it...During in person testings with users in Mexico, some users were confused by the option `Use Current Briges`. They thought by turning on this switch button, they would have bridges working, even tho they haven't set any bridges yet. Is it possible to show this option only after bridges are selected?
![Captura_de_Tela_2023-07-25_às_17.20.37](/uploads/f356d26ec993baf7af0ca76ad5529b7d/Captura_de_Tela_2023-07-25_às_17.20.37.png)
For ref: https://gitlab.torproject.org/tpo/ux/research/-/issues/109#note_2899137Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41910Support link regression in 115.1.0esr2023-10-05T20:12:50ZPier Angelo VendrameSupport link regression in 115.1.0esrDuring the rebase of alpha, I've found that Mozilla reworked the way they to assign URLs to support pages.
I think they re-route everything on the server side, and the new logic is just to append a path to a base URL.
We already have a...During the rebase of alpha, I've found that Mozilla reworked the way they to assign URLs to support pages.
I think they re-route everything on the server side, and the new logic is just to append a path to a base URL.
We already have an issue about properly handling the various support URLs, but this is different because this results in a regression for the support button on the bottom-left corner of `about:preferences`.
Maybe the old code still works, but it risks of becoming a fight with upstream.
Probably we should do something more ad-hoc in `toolkit/content/widgets/moz-support-link/moz-support-link.mjs` (check `#setHref`).
In addition, Firefox also appends a `utm-content` as a sort of telemetry to understand where the users click to get to that support page.
Maybe we'll want to clean the generated URL in any case.
This might benefit also Base Browser/Mullvad Browser.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41905Omnibar doesn't epand when clicking on the URL bar2023-07-25T18:09:38ZruihildtOmnibar doesn't epand when clicking on the URL bar
### Summary
When you visit a search engine website, and click on the URL bar, no omnibar appears.
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Go to duckduckgo.com
2. Click on the URL bar
#...
### Summary
When you visit a search engine website, and click on the URL bar, no omnibar appears.
### Steps to reproduce:
**How one can reproduce the issue - this is very important.**
1. Go to duckduckgo.com
2. Click on the URL bar
### What is the current bug behavior?
The URL gets highlighted.
### What is the expected behavior?
The URL gets highlighted and the omnibar appears
## Relevant logs and/or screenshots
https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41835#note_2924059https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41904The log textarea doesn't resize anymore2023-10-03T13:28:51ZPier Angelo VendrameThe log textarea doesn't resize anymoreLeft is current stable, right is a 13.0a1 build:
![Screenshot_from_2023-07-21_10-35-21](/uploads/a539a9998029b478714e117b0e00bb49/Screenshot_from_2023-07-21_10-35-21.png)Left is current stable, right is a 13.0a1 build:
![Screenshot_from_2023-07-21_10-35-21](/uploads/a539a9998029b478714e117b0e00bb49/Screenshot_from_2023-07-21_10-35-21.png)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41903The info icon on the language change prompt is not shown2023-10-04T15:50:04ZPier Angelo VendrameThe info icon on the language change prompt is not shownTested both on Linux and on Windows:
![Screenshot_from_2023-07-21_10-30-51](/uploads/10343b5bdeba167439cce26988b4c13c/Screenshot_from_2023-07-21_10-30-51.png)
But it could be an upstream problem.Tested both on Linux and on Windows:
![Screenshot_from_2023-07-21_10-30-51](/uploads/10343b5bdeba167439cce26988b4c13c/Screenshot_from_2023-07-21_10-30-51.png)
But it could be an upstream problem.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41902Add "New Circuit" to right-click context menu2023-07-20T17:00:02ZdonutsAdd "New Circuit" to right-click context menuSee [this suggestion](https://forum.torproject.org/t/suggestion-right-click-on-tab-and-offer-new-tor-circuit-for-this-site-option/8352) from a forum user.
The natural position would seem to be below "Reload" in the context menu. We shou...See [this suggestion](https://forum.torproject.org/t/suggestion-right-click-on-tab-and-offer-new-tor-circuit-for-this-site-option/8352) from a forum user.
The natural position would seem to be below "Reload" in the context menu. We should probably use the existing string in title case (i.e. "New Tor Circuit For This Site"), however that's very wordy and I think "...For This Site" can be inferred based on the context, so I'd be in favor of slimming it down to "New Circuit" here.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41895flip RFP's prefers-color-scheme to dark2023-11-01T23:10:07ZThorinflip RFP's prefers-color-scheme to darkRFP reduces this binary metric to useless (in our Tor Browser set of users) by always returning `light`. We can achieve the same FPing protection by always returning `dark`.
This is, IMO, not technically an accessibility issue, as the C...RFP reduces this binary metric to useless (in our Tor Browser set of users) by always returning `light`. We can achieve the same FPing protection by always returning `dark`.
This is, IMO, not technically an accessibility issue, as the CSS standard is arbitrary, not universal - i.e only a few websites (but arguably large popular websites) implement it. That said, I am not an accessibility expert, or knowledgeable about or experience light hurting eyes and creating migraines etc. I will say I've never heard of anyone claiming dark sites did the same (but of course the default is light and we enforce light)
In ESR115 as a major milestone, we could change test always returning `dark`. My logic for this is
- entropy is not affected
- accessibility _may_ be helped
- I strongly believe accessibility re colors is best served under existing/upcoming standards that are universal (which we could preset/harden)
- there are degrees of usefulness, and accessibility advocates indicate that this helps (maybe they're lying just to advocate their perference, but I'm inclined to agree that it can't hurt and would likely help)
We currently get RFP users (and tom will confirm), who complain about the _same few_ RFP items: it's _always_ timezone, prefers-color-scheme, and now timing (60FPS). It is my belief that no matter what we do, people will complain, but by returning `dark`, user's complaints are no longer anywhere near the validity of e.g. saying it causes migraines - in fact users who complain they get dark themed sites are just aesthetics (unless someone can prove dark themes are an accessibility problem)
In other words - flipping to dark cannot hurt fingerprinting, and can/would help usability
Class, discuss! cc @donutshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41887Opening an HTML file from download dropdown opens in system's default browser...2023-08-22T19:06:00ZrichardOpening an HTML file from download dropdown opens in system's default browser on LinuxNot sure how off into the weeds this is, but in testing !696 when opening the downloaded poc.html file, it opened the file in my system Firefox 115 install in a default/new profile. Verified my HOME is set correctly via the start-tor-bro...Not sure how off into the weeds this is, but in testing !696 when opening the downloaded poc.html file, it opened the file in my system Firefox 115 install in a default/new profile. Verified my HOME is set correctly via the start-tor-browser script by inspecting `/proc/$pid/environ`
I have not tested other platforms.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41884Linux: set browser.tabs.searchclipboardfor.middleclick to false2023-10-09T08:19:55ZThorinLinux: set browser.tabs.searchclipboardfor.middleclick to falsesimilar to #10089
FF115+ [1418462](https://bugzilla.mozilla.org/show_bug.cgi?id=1418462) Middle clicking on new tab should search or open what's in the selection clipboard on linux
```js
/* 2612: disable middle click on new tab button ...similar to #10089
FF115+ [1418462](https://bugzilla.mozilla.org/show_bug.cgi?id=1418462) Middle clicking on new tab should search or open what's in the selection clipboard on linux
```js
/* 2612: disable middle click on new tab button opening URLs or searches using clipboard [FF115+] [LINUX]
* When true, middle clicks on the new tab button will open the xclipboard contents in a new tab. If the
* xclipboard content is an URL, that URL is opened, and any other text is opened with your default search provider. */
user_pref("browser.tabs.searchclipboardfor.middleclick", false); // [DEFAULT: true Linux]
```
- see https://searchfox.org/mozilla-central/source/browser/app/profile/firefox.js#865
Someone said can you accidentally click a new tab button ...
> The new tab button is specifically designed to be CLICKED .. it's a click magnet ... with multiple results - e.g. right click = containers menu, left click = newtab, and now middle-click (on linux). So it's VERY likely to be magnitudes of order greater as an accidental wrong click-type vs say, some page content. So to answer your question ... YES :)
Do we wish to do anything about this. Note, keyword.enabled = true, so this will leak to search engines. And URLs will go to URLs.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41883Remove Menu > Help > Switching to a new device2023-10-04T15:49:45ZThorinRemove Menu > Help > Switching to a new devicetitle says it alltitle says it allhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41882Update DuckDuckGo icons2023-10-03T13:29:11ZThorinUpdate DuckDuckGo iconsupdate DDG icon(s)
- FF117: [1836958](https://bugzilla.mozilla.org/show_bug.cgi?id=1836958) desktop
- FF117: [1841978](https://bugzilla.mozilla.org/show_bug.cgi?id=1841978) android
the svgs are in the commits
cc @donuts see https://git...update DDG icon(s)
- FF117: [1836958](https://bugzilla.mozilla.org/show_bug.cgi?id=1836958) desktop
- FF117: [1841978](https://bugzilla.mozilla.org/show_bug.cgi?id=1841978) android
the svgs are in the commits
cc @donuts see https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27156#note_2818051richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41935Improve new window & letterboxing dimensions2023-10-03T13:29:12ZrichardImprove new window & letterboxing dimensionsMeta issue for our various letterboxing issues we should fix in ~"13.0 stable":
- [ ] ~~Change the default start window size from 1000x1000 mullvad-browser#175~~ (duplicate of the below ticket)
- [x] Increase max width of new windows to...Meta issue for our various letterboxing issues we should fix in ~"13.0 stable":
- [ ] ~~Change the default start window size from 1000x1000 mullvad-browser#175~~ (duplicate of the below ticket)
- [x] Increase max width of new windows tor-browser#33282
- [x] Re-evaluate letterboxing dimension choices tor-browser#30556
Let's plan on doing this work in base-browser so tor-browser can get these improvements also.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41876Remove Firefox View from title bar2023-10-03T17:15:56ZhenryRemove Firefox View from title barI'm guessing we don't want the `firefox-view-button` in the title bar. We can remove it in the "Bug 41736: Customize toolbar for base-browser." patch.I'm guessing we don't want the `firefox-view-button` in the title bar. We can remove it in the "Bug 41736: Customize toolbar for base-browser." patch.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41875revisit enforce `ask` for downloads | also patch `ask` for other files2023-08-26T04:14:20ZThorinrevisit enforce `ask` for downloads | also patch `ask` for other filesESR115 built from https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fdfcfcf4128fbb99599c464aa05177a85f194d
```
/* 2651: enable user interaction for security by always asking where to download
* [SETUP-CHROME] On And...ESR115 built from https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/33fdfcfcf4128fbb99599c464aa05177a85f194d
```
/* 2651: enable user interaction for security by always asking where to download
* [SETUP-CHROME] On Android this blocks longtapping and saving images
* [SETTING] General>Downloads>Always ask you where to save files ***/
user_pref("browser.download.useDownloadDir", false);
```
this is default false on previous ESRs, so we've regressed something somewhere? @pierov
also, while we're at it
```
/* 2654: enable user interaction for security by always asking how to handle new mimetypes [FF101+]
* [SETTING] General>Files and Applications>What should Firefox do with other files ***/
user_pref("browser.download.always_ask_before_handling_new_types", true);
```
this is default false in earlier releases and I think I opened an issue about this, might as well cover it herehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41866Truncate the onion address in the identity panel2023-08-22T18:40:00ZPier Angelo VendrameTruncate the onion address in the identity panelWith 115 we removed the custom rules to make the identity panel larger.
We might want to do the same thing we do for the circuit display (unless we want to restore the rules to make the panel larger again).
/cc @donutsWith 115 we removed the custom rules to make the identity panel larger.
We might want to do the same thing we do for the circuit display (unless we want to restore the rules to make the panel larger again).
/cc @donutshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41865Use --text-color-deemphasized rather than --panel-description-color2023-10-03T13:29:17ZhenryUse --text-color-deemphasized rather than --panel-description-colorIn the cirucit panel we used `--panel-description-color`, but this has been replaced in [bugzilla bug 1833160](https://bugzilla.mozilla.org/show_bug.cgi?id=1833160).In the cirucit panel we used `--panel-description-color`, but this has been replaced in [bugzilla bug 1833160](https://bugzilla.mozilla.org/show_bug.cgi?id=1833160).richardrichard