Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2023-02-10T23:45:48Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41421about:manual semantic and accessibility problems2023-02-10T23:45:48Zhenryabout:manual semantic and accessibility problemsI didn't look through all the "about:manual" pages, but I noticed a few semantic and accessibility issues which I imagine are common to most pages. A few of these issues would apply to https://tb-manual.torproject.org/ as well https://gi...I didn't look through all the "about:manual" pages, but I noticed a few semantic and accessibility issues which I imagine are common to most pages. A few of these issues would apply to https://tb-manual.torproject.org/ as well https://gitlab.torproject.org/tpo/web/manual/-/issues/132.
1. The top page "about:manual" uses `<h3>` for the "Topics" heading even though it is the top-most heading.
2. The list of links in "about:manual" uses `<li><h4><a></a></h4><p></p></li>`. Using both `<li>`, `<h4>` and `<a>` for the heading makes this noisier than necessary on a screen reader. Plus, this page is less "headings with paragraphs" and more a navigation page.
3. The sub-pages start with a `<h2>` heading, rather than `<h1>`.
4. The `<nav>` element at the top of the page could perhaps use `<ul>` to separate the links. The "»" symbol should be visual only.
5. The alt text for `<img>` elements are not very descriptive of the image. A lot of these are screenshots, but don't describe themselves as screenshots.
6. Some of the text is geared towards users who can see the screenshots.
An example for point 6 would be in the "about:manual#running-tor-browser" page. We have
> ## CONFIGURE
>
> Tor Browser will take you through a series of configuration options.
>
> The Connection Assist informs you about the state of your Internet connection and your connection to the Tor network.
>
> [image]
>
> [image]
>
> The first checkbox is 'Quickstart'. If selected, every time you open Tor Browser, it will try to connect with your previous network settings.
There's no indication that this "configure" is in the settings page, or that "Connection" and "Quickstart" are sections of this page. Using good alt text would help a little, but making the text clearer would help clarify things for all users. Generally, you want something that you could directly read over the phone to help someone on the other end.
Moreover, the use of "Connection Assist" is confusing because the section just before is called "CONNECTION ASSIST", which is something else.Sponsor 131 - Phase 5 - Ongoing Maintenancehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40568about:preference has a "Tor" tab, but confusingly, some Tor settings aren't u...2022-03-29T16:08:41ZRoger Dingledineabout:preference has a "Tor" tab, but confusingly, some Tor settings aren't under that tabI wanted to change my "automatically follow the OnionLocation header" setting in Tor Browser, so I went to about:preferences and clicked on the Tor tab and looked around and didn't find it. Then I typed 'onion' into the preferences searc...I wanted to change my "automatically follow the OnionLocation header" setting in Tor Browser, so I went to about:preferences and clicked on the Tor tab and looked around and didn't find it. Then I typed 'onion' into the preferences search bar, and there *is* a setting for changing it. After some more hunting, I found it hidden in the "Privacy & Security" tab. That's weird, since there is a tab named "Tor" which is where I would expect to find the Tor things.
Does that mean we should rename the Tor tab to something more specific, so I don't assume that all the Tor-Browser-specific settings will be found there?
(Discovered because we just had a user on #tor who had the same confusion).Sponsor 30 - Objective 3.3donutsdonutshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27989about:preferences Change Block List contains an occurrence of "Firefox"2020-06-27T14:34:46ZMark Smithabout:preferences Change Block List contains an occurrence of "Firefox"This is a spinoff from legacy/trac#27905. There is an occurrence of `Firefox` within the about:preferences `Change Block List` "dialog" which was fixed in Firefox 61 to pull the product name from `brandShortName`. Since it will not be ea...This is a spinoff from legacy/trac#27905. There is an occurrence of `Firefox` within the about:preferences `Change Block List` "dialog" which was fixed in Firefox 61 to pull the product name from `brandShortName`. Since it will not be easy to backport the fix to ESR60, we will pick this up with ESR68 (see https://hg.mozilla.org/mozilla-central/rev/8ebf84e9825d).https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/16775about:preferences is broken with security slider set to "High"2020-06-27T14:40:23ZGeorg Koppenabout:preferences is broken with security slider set to "High"If one sets the security slider to "High" there is no way anymore to configure the browser preferences on the `about:preferences` page. First mentioned in https://blog.torproject.org/blog/tor-browser-50-released#comment-100830.If one sets the security slider to "High" there is no way anymore to configure the browser preferences on the `about:preferences` page. First mentioned in https://blog.torproject.org/blog/tor-browser-50-released#comment-100830.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40144about:privatebrowsing Firefox branding2023-02-22T11:40:50ZPassword is "Cypherpunks Write Code" without quotescypherpunks@mailinator.comabout:privatebrowsing Firefox brandingabout:privatebrowsing contains Firefox branding instead of Tor Browser oneabout:privatebrowsing contains Firefox branding instead of Tor Browser oneSponsor 131 - Phase 2 - Privacy BrowserPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41425about:rulesets semantic and accessibility problems2022-12-08T14:57:26Zhenryabout:rulesets semantic and accessibility problemsA few of these issues I noticed:
1. The page is missing a `<title>`.
2. The rule list (`#ruleset-list`) is not focusable and cannot be activated with a keyboard. This element should ideally be a `role="listbox"` or similar widget with f...A few of these issues I noticed:
1. The page is missing a `<title>`.
2. The rule list (`#ruleset-list`) is not focusable and cannot be activated with a keyboard. This element should ideally be a `role="listbox"` or similar widget with focus management. I don't think it should be part of an `<aside>` since it is main content, rather than complementary.
3. The rule title (`#ruleset-title`) should probably be `<h2>` rather than `<h1>` because it is a section title rather than a page title.
4. The use of `<dl>`, `<dt>` and `<dd>` is semantically ok, but I don't think these elements have great screen reader support. Note that the html specification has changed their meaning to be any generic name-value pair https://html.spec.whatwg.org/multipage/grouping-content.html#the-dl-element and the latest ARIA relates these to various "associationlist" roles https://w3c.github.io/aria/#associationlist . But firefox still seems to map to the "definitionlist", "term" and "definition" roles.
5. The edit form (`#edit-ruleset-form`) might benefit from an accessible name. We can probably use `aria-labelledby="ruleset-title"`.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/28201about:support help link directs to Firefox's support rather than Tor Browser's2023-01-05T16:35:22Ztraumschuleabout:support help link directs to Firefox's support rather than Tor Browser'stested in 11.5a13 still going to the Firefox domain (but the in-page branding is correct now)tested in 11.5a13 still going to the Firefox domain (but the in-page branding is correct now)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/24993about:support option strips TBB down to Firefox2022-12-30T15:26:43Zcypherpunksabout:support option strips TBB down to Firefox-go to about:support
-click "Refresh Tor Browser"
-now you're fucked
This option should restore the Tor Browser Bundle to it's default config, meantime as the Tor Browser. Instead it "restores" it to more or less FIrefox.
I used it onc...-go to about:support
-click "Refresh Tor Browser"
-now you're fucked
This option should restore the Tor Browser Bundle to it's default config, meantime as the Tor Browser. Instead it "restores" it to more or less FIrefox.
I used it once where I not only didn't have Tor locally installed, but didn't have safe access to updates or downloads, and suddenly found myself stranded without web access over tor.
I understand some users may need to manually re-install the Tor Browser Button, etc. But at the very least this path needs to be better marked.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41393about:tbupdate semantic and accessibility problems2023-04-03T18:49:04Zhenryabout:tbupdate semantic and accessibility problemsThe about:tbupdate page has no semantic structure: it is just a bunch of `<div>`s.
Moreover, the "bullet points" are just asterisks, rather than `<li>` elements.
As such, this page lacks structure for screen readers.The about:tbupdate page has no semantic structure: it is just a bunch of `<div>`s.
Moreover, the "bullet points" are just asterisks, rather than `<li>` elements.
As such, this page lacks structure for screen readers.Sponsor 131 - Phase 2 - Privacy Browserhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/10606about:tor may fetch the "you're using Tor" page from browser cache2020-06-27T14:42:21ZTracabout:tor may fetch the "you're using Tor" page from browser cacheUsing tor-browser-linux64-3.5_en-US.tar.xz
While doing some tests and having disabled the Tor Launcher browser addon (so the Tor gateway doesn't actually get started with the browser) I noticed:
about:tor
still says
"you're using T...Using tor-browser-linux64-3.5_en-US.tar.xz
While doing some tests and having disabled the Tor Launcher browser addon (so the Tor gateway doesn't actually get started with the browser) I noticed:
about:tor
still says
"you're using Tor"
even if the Tor gateway isn't running at all for whatever reason.
If it's possible that about:tor gets fetched from browser cache, this page doesn't prove anything
**Trac**:
**Username**: konotreahttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/27200about:tor favicon should be the tb icon2020-06-27T14:35:19ZTracabout:tor favicon should be the tb iconabout:tor favicon is non-existent in tb 8.0a10
**Trac**:
**Username**: ProTipGuyFWIWWeLoveARMAabout:tor favicon is non-existent in tb 8.0a10
**Trac**:
**Username**: ProTipGuyFWIWWeLoveARMAhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/32628about:tor is not always localized on Android2022-11-30T16:56:56ZMatthew Finkelabout:tor is not always localized on AndroidSee ticket:32365#comment:8 for background. The locale is not correctly propagated within about:tor.See ticket:32365#comment:8 for background. The locale is not correctly propagated within about:tor.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42475about:tor lacks branding2024-03-25T03:51:14ZThorinabout:tor lacks branding![about-tor](/uploads/1aa737b9f7b5de00b0d3540cf5689521/about-tor.png)
Roger brought up that there's nothing to "say" Tor Browser (excluding when you have the byline that Tor Browser updated)
> - i am trying to show a screenshot of tor ...![about-tor](/uploads/1aa737b9f7b5de00b0d3540cf5689521/about-tor.png)
Roger brought up that there's nothing to "say" Tor Browser (excluding when you have the byline that Tor Browser updated)
> - i am trying to show a screenshot of tor browser and i find myself needed to write "Tor Browser" at the top or nobody will know what it is a screenshot of
> - it looks mainly like a duck duck go browser because that's what gets the real estate
My initial suggestion is add a smaller sized `Tor Browser` byline directly beneath `Explore. Privately`, but inline to the icon, and obviously adjust their vertical alignment
cc: @donuts @armahttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41423about:tor semantic and accessibility problems2023-10-03T13:29:51Zhenryabout:tor semantic and accessibility problemsSome issues with the about:tor page:
1. I'm not sure "About Tor" is the best document title. Wouldn't it be "About Tor Browser", or "Tor Browser Ready" or "Tor Browser Home"?
2. The "New to Tor Browser" button (`#onboarding-overlay-butt...Some issues with the about:tor page:
1. I'm not sure "About Tor" is the best document title. Wouldn't it be "About Tor Browser", or "Tor Browser Ready" or "Tor Browser Home"?
2. The "New to Tor Browser" button (`#onboarding-overlay-button`) has an almost invisible "focus-visible" styling. And the color contrast is poor.
3. The search input (`#search-text`) has no "focus-visible" styling.
4. The search button (`#search-button`) has "focus-visible" outline that isn't consistent with the rest of the page: it has thin dotted outline, whilst the links have a thick blue outline.
5. The search label (`#searchlabel`) has no text content (it is just a background image) so does not work as a label for the search input.
6. All the `<img>` elements (`#onboarding-overlay-button-icon`, `#torcontent-logo`, `#bannerImg`, and `#imageStyle`) do not have an `alt=""` attribute.
7. A lot of the link text ends in the "»" symbol. I'm not sure why we do this, but it does not read well on a screen reader. So it should be removed or visual only.
8. I feel like the `.heading1` text is meant to act as the page's heading, so should be a `<h1>`.
9. The page uses lots of `<div>`s instead of elements with more structural semantics.Sponsor 131 - Phase 2 - Privacy Browserhenryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/16735about:tor should accommodate different fonts/font sizes2020-06-27T14:40:24ZMark Smithabout:tor should accommodate different fonts/font sizesThe about:tor page, which was contributed a long time ago (see legacy/trac#7494), uses some absolutely positioned elements. This causes the page to not layout well if fonts, font metrics, or font sizes are changed. We should fix it.
T...The about:tor page, which was contributed a long time ago (see legacy/trac#7494), uses some absolutely positioned elements. This causes the page to not layout well if fonts, font metrics, or font sizes are changed. We should fix it.
This came up recently; see ticket:16707#comment:1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/14392about:tor should behave more like about:newtab2020-06-27T14:41:16ZMike Perryabout:tor should behave more like about:newtabWe should set browser.newtab.url to about:tor instead of about:newtab for consistency.We should set browser.newtab.url to about:tor instead of about:newtab for consistency.Mike PerryMike Perryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/21218about:tor should use the selected default search engine2023-08-26T04:48:40ZGeorg Koppenabout:tor should use the selected default search engineIt seems there is a feature in Firefox that the search bar gets changed globally if the one in the search bar changes. Tor Browser users might want to have this global search engine change feature as well (i.e. having the search engine o...It seems there is a feature in Firefox that the search bar gets changed globally if the one in the search bar changes. Tor Browser users might want to have this global search engine change feature as well (i.e. having the search engine on about:tor in snyc).https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/17108about:tor UI design improvements2020-06-27T14:40:10ZTracabout:tor UI design improvementsHello,
I've been thinking about making the about:tor page more modern. The main idea was to make small but efficient improvements. Thus, only the css style-sheet has changes. Here are the suggestions :
- #middle div.container :
Add an ...Hello,
I've been thinking about making the about:tor page more modern. The main idea was to make small but efficient improvements. Thus, only the css style-sheet has changes. Here are the suggestions :
- #middle div.container :
Add an inner shadow (box-shadow: inset 0px 0px 3px rgba(0,0,0,0.3);) and delete the border. This makes the implantation of the divs smoother without emphasizing them. To give the impression of a band, space between the two divs needed to be reduced. I suggest to pull the inner borders to the center (changing width to 300px, padding from 10px 10px to 10px 20px and moving div.three to left: 480px). Also, align the bottom of the divs (min-height: 13.5em) for the band illusion.
- Search bar (#sxw) :
Same idea as the middle divs of using shadow to delete the border in order to make the page smoother. But in this case, I think the search bar should be emphasized because it's one of the most important piece of the page. So I thought about deleting border-top/left/right/bottom to erase the border line, add a padding of 3px (and wider the .searchbox form to 402px to make it fits) and put a white background to the #sxw.
A screenshot of what it would looks like is attached to this ticket.
What do you think about it ?
I look forward to hearing from your reactions.
**Trac**:
**Username**: 1941211https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/30605accept-language header leaks browser localization2020-10-23T18:07:13ZMatthew Finkelaccept-language header leaks browser localizationA [blog user](https://blog.torproject.org/comment/281830#comment-281830) mentions each request includes the chosen browser language. Do we normalize this on desktop such that we only send `en-US` regardless of the browser's localization?...A [blog user](https://blog.torproject.org/comment/281830#comment-281830) mentions each request includes the chosen browser language. Do we normalize this on desktop such that we only send `en-US` regardless of the browser's localization?
Using https://wtfismyip.com/headers
With `en-US` as the browser locale:
```
host: wtfismyip.com
connection: close
user-agent: Mozilla/5.0 (Android 6.0; Mobile; rv:60.0) Gecko/20100101 Firefox/60.0
accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
accept-language: en-US,en;q=0.5
accept-encoding: gzip, deflate, br
upgrade-insecure-requests: 1
```
With `ru-RU` as the browser locale:
```
host: wtfismyip.com
connection: close
user-agent: Mozilla/5.0 (Android 6.0; Mobile; rv:60.0) Gecko/20100101 Firefox/60.0
accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
accept-language: ru,ru-RU;q=0.8,en-US;q=0.5,en;q=0.3
accept-encoding: gzip, deflate, br
upgrade-insecure-requests: 1
```Tor Browser: 10.0https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/17879Activating the Flash Player is not working anymore since Tor Browser 5.0.52021-07-13T19:43:06ZGeorg KoppenActivating the Flash Player is not working anymore since Tor Browser 5.0.5There are a bunch of users that are complaining about the Flash Player not working anymore e.g. on sites like www.pandora.com. What is going on, I think, is the *detection* being broken which is very likely due to the fix for legacy/trac...There are a bunch of users that are complaining about the Flash Player not working anymore e.g. on sites like www.pandora.com. What is going on, I think, is the *detection* being broken which is very likely due to the fix for legacy/trac#17207. The Flash Player itself is still working for me, e.g. on Adobe's test site.
It's unfortunate that this did not get caught in our alpha series but here we are. I guess providing a preference allowing to disable the fix for legacy/trac#17207 might be worth it given that a number of users wouldn't be using Tor Browser otherwise or would be trying to shoot themselves in the foot with having different browsers opened simultaneously.