Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2023-04-17T20:28:02Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41702The connection pill needs to be centered vertically2023-04-17T20:28:02ZPier Angelo VendrameThe connection pill needs to be centered vertically<details><summary>So triggering!</summary>
![Screenshot_from_2023-03-29_10-28-05](/uploads/db3d402642be83967c3ebc517fc1bd9d/Screenshot_from_2023-03-29_10-28-05.png)
(`layout.css.devPixelsPerPx` at `1.7`)
</details><details><summary>So triggering!</summary>
![Screenshot_from_2023-03-29_10-28-05](/uploads/db3d402642be83967c3ebc517fc1bd9d/Screenshot_from_2023-03-29_10-28-05.png)
(`layout.css.devPixelsPerPx` at `1.7`)
</details>ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41698Reword the recommendation badges in about:addons2023-07-05T20:59:01ZPier Angelo VendrameReword the recommendation badges in about:addons`about:addons` can show some badges on the extensions, in addition to the one that says that the extension is enabled in incognito.
Should we hide them?
I guess that AMO reviews are better than no reviews, but I think that in case we s...`about:addons` can show some badges on the extensions, in addition to the one that says that the extension is enabled in incognito.
Should we hide them?
I guess that AMO reviews are better than no reviews, but I think that in case we should change the text, because at the moment it says:
> Tor Browser only recommends extensions that meet our standards for security and performance
It's the same message as Firefox, but in our case I think it's misleading.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41691"Firefox Suggest" text appearing in UI2023-10-05T12:47:24Zhenry"Firefox Suggest" text appearing in UI## Steps to reproduce
In 12.0.4:
1. Open example.org in a tab.
2. Open a new tab, and start typing "example.org".
## Result
Below the URL bar you will see "Firefox Suggest", as it suggests switching tabs. Also happens with bookmarks....## Steps to reproduce
In 12.0.4:
1. Open example.org in a tab.
2. Open a new tab, and start typing "example.org".
## Result
Below the URL bar you will see "Firefox Suggest", as it suggests switching tabs. Also happens with bookmarks.
## Expect
No appearance of "Firefox".
## Origin
I think this comes from `-firefox-suggest-brand-name` used for `urlbar-group-firefox-suggest`. I guess "Firefox Suggest" is a product name since, whilst it includes just a local search of tabs and bookmarks, [in the US it also includes](https://support.mozilla.org/en-US/kb/firefox-suggest)
> Top pick - Featured suggestions from Firefox and our partners
I'm guessing we have that last part disabled in Tor Browser, so we're not really using the "Firefox Suggest" part of the product. So maybe we'd be better off changing `urlbar-group-firefox-suggest` to our own string, rather than `-firefox-suggest-brand-name` itself.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41651Use moz-toggle in connection preferences2023-10-03T15:34:25ZhenryUse moz-toggle in connection preferencesOur connection preferences currently use `<checkbox class="toggle-button">` but next ESR release will contain the `<moz-toggle>` ([bugzilla bug 1799466](https://bugzilla.mozilla.org/show_bug.cgi?id=1799466)) which we can use. Basically, ...Our connection preferences currently use `<checkbox class="toggle-button">` but next ESR release will contain the `<moz-toggle>` ([bugzilla bug 1799466](https://bugzilla.mozilla.org/show_bug.cgi?id=1799466)) which we can use. Basically, we want to follow [bugzilla bug 1799471](https://bugzilla.mozilla.org/show_bug.cgi?id=1799471).
Note that it changes the accessible role of the element from a "checkbox" to a "toggle-button".
The main difference in firefox is that they put their `<label>` before the toggle. E.g. see the firefox quick suggestion Address Bar settings when "browser.urlbar.quicksuggest.enabled" is true. Similarly, the addon toggle tends to be end-aligned. We could optionally follow the same style, but I think we'll be ok just placing the `<label>` manually ourselves.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41642Do not hide new PBM in the hamburger menu if auto PBM is not enabled2023-10-03T15:37:43ZPier Angelo VendrameDo not hide new PBM in the hamburger menu if auto PBM is not enabledImprovement for 2a6e497977d8ab4996d8a1c77dbdcb1ae60eb486.Improvement for 2a6e497977d8ab4996d8a1c77dbdcb1ae60eb486.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41623Update connection assist's iconography2023-06-15T10:15:58ZdonutsUpdate connection assist's iconographyWe designed new iconography for connection assist last year, but never handed it over for implementation.
I had planned on waiting until the next major revision of torconnect to ship the new icons (see https://gitlab.torproject.org/tpo/...We designed new iconography for connection assist last year, but never handed it over for implementation.
I had planned on waiting until the next major revision of torconnect to ship the new icons (see https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41621, and this [WIP Figma file](https://www.figma.com/file/gFE1rXBMdbZGJAIdwtZ508/Tor-Browser-13.0?node-id=0%3A1&t=cic5Swm3tv65MX6x-1)), however since the new torconnect icon will be making an appearance in the browser chrome (https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41608) and connection settings (https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41618) sooner than planned, we should ship these at the same time in Tor Browser 12.5 for consistency.Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & TibetDan BallardDan Ballardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41618Update the iconography used in the status strip in connection settings2023-06-08T11:01:40ZdonutsUpdate the iconography used in the status strip in connection settingsWe're introducing a new pair of icons (regular and broken) representing Tor Browser's connection state in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41608. In addition to updating the browser chrome, there are a ...We're introducing a new pair of icons (regular and broken) representing Tor Browser's connection state in https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41608. In addition to updating the browser chrome, there are a small number of changes that will need made to `about:preferences#connection` too.
These include:
- [ ] Removing the "Connect" info bars
- [ ] Removing the check (✔) and warning (⚠️) icons from the Internet and Tor Network statuses
- [ ] Replacing the Tor Network icon with the new torconnect icons (regular when connected, and broken when not)
We could also use a tiny bit more padding between the connection status label and buttons, as per the design pls.
The Figma file's ready for dev handoff here: [Figma link](https://www.figma.com/file/RS584DcR4emXrw1F8g3l5x/Tor-Browser-12.5?node-id=79%3A14487&t=41hhHGHnJTkIHnmo-1)
These fixes will be ran through additional usability testing in March/April as part of ~"Sponsor 30" before they reach stable in 12.5.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41613Skip Drag & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:)2023-06-15T09:47:03Zma1Skip Drag & Drop filtering for DNS-safe URLs (no hostname, e.g. RFC3966 tel:)Some URLs are convenient to drag & drop (e.g. [phone numbers embedded in tel: URLs)](https://forum.torproject.net/t/drag-and-drop-protections-in-tor-browser-12-0/5854/10) and cannot trigger unwanted DNS requests because they've got no ho...Some URLs are convenient to drag & drop (e.g. [phone numbers embedded in tel: URLs)](https://forum.torproject.net/t/drag-and-drop-protections-in-tor-browser-12-0/5854/10) and cannot trigger unwanted DNS requests because they've got no hostname.
Let's avoid filtering them.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41608Improve the UX of the location bar's connection status2023-06-12T16:52:33ZdonutsImprove the UX of the location bar's connection statusAs part of https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41060, we explored beefing up the styling of the connection status in the location bar – and revealing a tiny `Connect` button when the user navigates away fr...As part of https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41060, we explored beefing up the styling of the connection status in the location bar – and revealing a tiny `Connect` button when the user navigates away from `about:torconnect`.
Changes include:
- [ ] Adding the new torconnect icon(s)
- [ ] Revealing an extra tiny button after tabbing away from `about:torconnect`
- [ ] Adding an additional `Potentially Blocked` (which should exist in `about:preferences#connection`'s status strip already)
- [ ] Additional styling updates
The Figma file's ready for dev handoff here: [Figma link](https://www.figma.com/file/RS584DcR4emXrw1F8g3l5x/Tor-Browser-12.5?node-id=2%3A14695&t=JdoAW2xcF87Hqnjd-1)
These fixes will be ran through additional usability testing in March/April as part of ~"Sponsor 30" before they reach stable in 12.5.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41602Designing the User Interface of Conjure in Tor Browser2023-05-30T21:43:51ZrichardDesigning the User Interface of Conjure in Tor BrowserFollowing https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41361 we need to do the UX work for exposing this feature to users.
@cohosh can you reply with a blurb about how conjure works/differs from other bridges, tra...Following https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41361 we need to do the UX work for exposing this feature to users.
@cohosh can you reply with a blurb about how conjure works/differs from other bridges, tradeoffs, etc so we get a string written for the bridge selection UX ( see https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41583#note_2870062 for reference).Sponsor 30 - Objective 2.3https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41598Prevent NoScript from being removed / disabled until core functionality has b...2023-03-27T19:45:38ZrichardPrevent NoScript from being removed / disabled until core functionality has been migrated to Tor BrowserUsers can currently uninstall or disable NoScript, which makes Security Level just silently fail in interesting ways. We should fix this issue.Users can currently uninstall or disable NoScript, which makes Security Level just silently fail in interesting ways. We should fix this issue.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41583Designing the User Interface of WebTunnel in Tor Browser2023-06-12T14:58:50ZshelikhooDesigning the User Interface of WebTunnel in Tor BrowserWe are currently in need of a way to let users interact with webtunnel bridges in Tor Browser.
Currently to use web tunnel, the user will need to input a custom bridge line.
For user's side we could let WebTunnel interact with users in...We are currently in need of a way to let users interact with webtunnel bridges in Tor Browser.
Currently to use web tunnel, the user will need to input a custom bridge line.
For user's side we could let WebTunnel interact with users in the same way as obfs4 to make it easier for user to understand it.
It will need a small change to allow user select type of bridge to request.donutsdonutshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41542Disable the creation of a default profile2023-02-16T08:01:20ZPier Angelo VendrameDisable the creation of a default profileIn _TB3: Tor Browser's official .mozconfigs._, we set
```
imply_option("MOZ_DEDICATED_PROFILES", False)
```
This option makes us use a single profile for all our channels.
Personally, I do not like this option very much (but at this p...In _TB3: Tor Browser's official .mozconfigs._, we set
```
imply_option("MOZ_DEDICATED_PROFILES", False)
```
This option makes us use a single profile for all our channels.
Personally, I do not like this option very much (but at this point it's part of our legacy, for Tor Browser).
But what should we do with Base Browser/S131 browser? Should we move it to the base-browser `mozconfig` commit?
Without it, when we make Firefox create the actual profiles (e.g., with portable mode off), it creates a [default profile for legacy versions](https://searchfox.org/mozilla-central/rev/e6b709df9b93858364f02ab89f40d78762693db8/toolkit/profile/nsToolkitProfileService.cpp#1684), see also [Bug 1770174](https://bugzilla.mozilla.org/show_bug.cgi?id=1770174).
We could put these lines between `ifdef`/`endif` when we don't want this behavior, while keeping the dedicated profiles.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41534Users reporting media hosted by Cloudflare not loading in 12.0.x2022-12-22T13:29:34ZdonutsUsers reporting media hosted by Cloudflare not loading in 12.0.xSee these reports:
- [12.0 release thread comment](https://forum.torproject.net/t/new-release-tor-browser-12-0/5820/17?u=duncan)
- [Image load error (HTTP/2 403 Forbidden) on some websites](https://forum.torproject.net/t/image-load-erro...See these reports:
- [12.0 release thread comment](https://forum.torproject.net/t/new-release-tor-browser-12-0/5820/17?u=duncan)
- [Image load error (HTTP/2 403 Forbidden) on some websites](https://forum.torproject.net/t/image-load-error-http-2-403-forbidden-on-some-websites/5974)
- [Comment on r/TOR](https://old.reddit.com/r/TOR/comments/znn95v/new_release_tor_browser_1201/)richardrichardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41531Unable to update to 12.0.1 on Apple Silicon-based Mac2022-12-17T09:07:38ZdonutsUnable to update to 12.0.1 on Apple Silicon-based MacI'm getting this error when I try to update from 12.0 to 12.0.1 on my Apple Silicon-based Mac:
![apple-silicon-incomatible](/uploads/4f0960b9e1cfc91cdc69dd234f68f4e0/apple-silicon-incomatible.png)
Updating on my Intel machine seems to ...I'm getting this error when I try to update from 12.0 to 12.0.1 on my Apple Silicon-based Mac:
![apple-silicon-incomatible](/uploads/4f0960b9e1cfc91cdc69dd234f68f4e0/apple-silicon-incomatible.png)
Updating on my Intel machine seems to work fine, and I can successfully install 12.0.1 on my Apple Silicon-based mac manually too.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41528Hard-coded English "based on Mozilla Firefox" appears in version in "About" d...2023-10-03T15:38:27ZhenryHard-coded English "based on Mozilla Firefox" appears in version in "About" dialogIn the "about" dialog, we currently [hard-code in the string "based on Mozilla Firefox"](https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/c7a1ca3c77921f744386391daba99a9f3894c2dd/browser/base/content/aboutDialog.js#L60)....In the "about" dialog, we currently [hard-code in the string "based on Mozilla Firefox"](https://gitlab.torproject.org/tpo/applications/tor-browser/-/blob/c7a1ca3c77921f744386391daba99a9f3894c2dd/browser/base/content/aboutDialog.js#L60). We should make this localizable, ideally using fluent since that is what firefox is using here.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41526"Cancel" button when establishing a connection should be grey2023-04-05T13:45:40Zdonuts"Cancel" button when establishing a connection should be grey"Cancel" is currently a purple (i.e. primary) button which is commonly used to denote a recommended action:
![establishing-connection](/uploads/924b6867e722d26dcb355eb91b8e37a7/establishing-connection.png)
In this case however, it sho..."Cancel" is currently a purple (i.e. primary) button which is commonly used to denote a recommended action:
![establishing-connection](/uploads/924b6867e722d26dcb355eb91b8e37a7/establishing-connection.png)
In this case however, it should be a grey (i.e. secondary/default) button.Dan BallardDan Ballardhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41510The "Restore Defaults" doesn't restore the Security Level preferences2023-04-19T11:34:54ZPier Angelo VendrameThe "Restore Defaults" doesn't restore the Security Level preferencesWhile reviewing !464, I've noticed that the "Restore Defaults" link in about:preferences#privacy doesn't do anything (see also https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests/464#note_2860237).
Initially, I t...While reviewing !464, I've noticed that the "Restore Defaults" link in about:preferences#privacy doesn't do anything (see also https://gitlab.torproject.org/tpo/applications/tor-browser/-/merge_requests/464#note_2860237).
Initially, I thought adding an `is="text-link"` was enough, because some telemetry nonsense looks for that attribute, which we're missing and we get an exception that is visible in the console.
However, adding it doesn't seem to be enough, and we might need some additional investigation.
As a workaround, the button in the panel works, so we might release 12.0 with this problem, and add it to known bugs.
/cc @richard @duncanhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41495Clicking on "View Logs" in the "Establishing Connection" page takes you to ab...2022-12-06T10:13:54ZGabagaba@torproject.orgClicking on "View Logs" in the "Establishing Connection" page takes you to about:preferences#connection and not logsTor Browser 11.5.8
It does not show the window with the logs. It opens a new tab with the about:preferences#connection.Tor Browser 11.5.8
It does not show the window with the logs. It opens a new tab with the about:preferences#connection.henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41448User `danger` style for primary button in new identity modal2022-12-06T09:59:57ZdonutsUser `danger` style for primary button in new identity modalWe should use the `danger` (i.e. red) button style for the "Restart Tor Browser" button in the new identity modal dialog, since this is a destructive action. Here's an example of the same button in Firefox:
![modal-dialog-danger-button]...We should use the `danger` (i.e. red) button style for the "Restart Tor Browser" button in the new identity modal dialog, since this is a destructive action. Here's an example of the same button in Firefox:
![modal-dialog-danger-button](/uploads/55cf15f6dacb92fc33d2ac5a4c4c1000/modal-dialog-danger-button.png)
I also noticed there's a rogue line break in the string now, that wasn't there before?
<details><summary>Show screenshot:</summary>
![new-identity-alpha](/uploads/d7614d27617bf8683be845796ded92fe/new-identity-alpha.png)
</details>Sponsor 131 - Phase 3 - Major ESR 102 MigrationPier Angelo VendramePier Angelo Vendrame