Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2024-03-05T14:03:56Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42430Crash with nested XHTML2024-03-05T14:03:56ZcypherpunksCrash with nested XHTMLTor Browser 13.0.10 on Windows crashes when I open `chrome://browser/content/browser.xhtml`, press <kbd>Alt</kbd> and select `Tools > Downloads (Ctrl-J)` (or just press <kbd>Ctrl+J</kbd>). Nothing of importance on its own, but still indi...Tor Browser 13.0.10 on Windows crashes when I open `chrome://browser/content/browser.xhtml`, press <kbd>Alt</kbd> and select `Tools > Downloads (Ctrl-J)` (or just press <kbd>Ctrl+J</kbd>). Nothing of importance on its own, but still indicative of something wrong - possibly even web accessible wrong.cypherpunkscypherpunkshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42422Tor's PDF viewer hides or deletes changes on the PDF file when saved, irregul...2024-02-28T10:10:47ZMattiasbleeda097@gmail.comTor's PDF viewer hides or deletes changes on the PDF file when saved, irregularly<!--
* Use this issue template for reporting a new bug.
-->
### Summary
Tor Version 13.0.9 (64-bit)
Tor security level Standard
The following bug doesn't display the changes made on the PDF by Tor PDF's viewer, the bug sometimes seems ...<!--
* Use this issue template for reporting a new bug.
-->
### Summary
Tor Version 13.0.9 (64-bit)
Tor security level Standard
The following bug doesn't display the changes made on the PDF by Tor PDF's viewer, the bug sometimes seems to "delete" the written data of the changes, so that it did disappear edits made before the last saving by me.
It also hides info because I did open the same file in two different tabs, and in one tab was loading written text while in the another didn't load it at all being incomplete.¹
As far as I'm concerned, I think it hides it rather than deleting because the file size apparent weighter **despite no text added is shown**, unlike a previous version written without the last save which is lighter. This seems reasonable, but not if the weighter file with the last writing doesn't have the content which it's like ghost data lost...
¹: I mean writting text saved, not PDF pages.
### Steps to reproduce:
Unfortunately I can't remember what I did exactly. Incident date 13/2/24 midday. but I remember to overwrite the file PDF in an ordinary folder settled in Onedrive (Microsoft) as I used to do. Here what I was doing
1. Drag the pdf file to Tor's window tabs.
2. Use the tools _Text_ of PDF's viewer
3. Once editing, save the file in the original
4. From time to time it might not show what was written
I must clarify I was using my mobile phone to continue editing what I wrote, this process of displaying destroys the text body each once I save changes from mobile phone, then, displaying it in desktop the extended spaces are taken out, Tor's PDF viewer stills take them into account although, but the damages are irreversible. Odd behavior.
### What is the current bug behavior?
It hides modified txt files or doesn't show it.
### What is the expected behavior?
I expected to see the last changes I saved but there aren't. I wrote until page 80, by PDF's viewer page scrolling, 81 by book index, starting from 61. There was nothing between 61 to 80, and later one time there was nothing between 47 in forward... Later, that fixed itself (61-80) and I opened two tabs, one had until 70 and that one remained currently.
### Environment
**Windows 10 Home Single Language 64 bits (10.0, compilation 19045)**
**From Tor main page**
### Relevant logs and/or screenshots
![marcas-mapa-rojo-Y-latigo-que-corta-viento](/uploads/ad440a8aff645cd7a1ba1628b6811562/marcas-mapa-rojo-Y-latigo-que-corta-viento.png)
![OneDrive_-_Personal_21_02_2024_7_30_28](/uploads/98b56603b37cb70f7520f8aa6a56d926/OneDrive_-_Personal_21_02_2024_7_30_28.png)
Honestly, I don't know what I did specifically, I'd like to provide more information specially with the steps to the bug, these are a custom mine. I can't post the file I'm talking about because it's too big.
By the way, just in case English isn't my first language.Mattiasbleeda097@gmail.comMattiasbleeda097@gmail.comhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42418TorBrowser leave trace on the Windows Event Log by default and there is no wa...2024-03-05T13:50:25ZcypherpunksTorBrowser leave trace on the Windows Event Log by default and there is no way to stop this!To be clear, Mozilla Firefox does same thing.
Steps.
1. Launch Tor Browser latest
2. Open "eventvwr.ms" (The event viewer of Windows)
3. Open "Windows Logs/Application"
You'll see tons of:
```
The description for Event ID 5 from sourc...To be clear, Mozilla Firefox does same thing.
Steps.
1. Launch Tor Browser latest
2. Open "eventvwr.ms" (The event viewer of Windows)
3. Open "Windows Logs/Application"
You'll see tons of:
```
The description for Event ID 5 from source Tor Browser Launcher cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.
If the event originated on another computer, the display information had to be saved with the event.
The following information was included with the event:
```https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42393Suggestion: separate user-specific files or directories from Tor Browser prog...2024-03-05T13:37:41ZevngrpSuggestion: separate user-specific files or directories from Tor Browser program files / resourceCurrently, Tor Browser put user-specific files with program files into same place. This is not a wise option. Because user may accidentally modify or delete important program files or resource, especially for new users.
I would recommen...Currently, Tor Browser put user-specific files with program files into same place. This is not a wise option. Because user may accidentally modify or delete important program files or resource, especially for new users.
I would recommend to make all user-specific file / settings into `~/.torbrowser/` or any other directory under `$HOME`. And make program files and resource frozen and immutable like how other software do.
And this can make Many users on a operating system have their specific settings and files with sharing single tor browser installation possible.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42347Add a banner warning users about the upcoming EOL for Win ≤8.1 and macOS ≤10.142024-02-01T14:39:44ZPier Angelo VendrameAdd a banner warning users about the upcoming EOL for Win ≤8.1 and macOS ≤10.1413.5 will be the last Windows version, Mozilla bumped the requirement to Windows 10.
We could add a warning to Windows 7 users somewhere, e.g., in about:tor.
We can check the version of the OS with `Services.sysinfo.getProperty("versio...13.5 will be the last Windows version, Mozilla bumped the requirement to Windows 10.
We could add a warning to Windows 7 users somewhere, e.g., in about:tor.
We can check the version of the OS with `Services.sysinfo.getProperty("version")`. It's `10.0` in my Windows 10 VM, and `6.1` in my Windows 7 VM.
Maybe the first versions of Windows 10 also use 6.1, but if that's the case, they're unsupported too.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42294Empty/Blank CAPTCHA2024-01-09T13:59:31ZZarko_GjurovEmpty/Blank CAPTCHAIn: Settings-\>Connection-\>Bridges-\>Add a new Bridge, Request a Bridge CAPTCHA that needs to be solved is empty/blank.
### Environment
Windows 7 SP1 Official setup exe version 13.0.5 from Tor Project website.
https://i.ibb.co/GPTpZF...In: Settings-\>Connection-\>Bridges-\>Add a new Bridge, Request a Bridge CAPTCHA that needs to be solved is empty/blank.
### Environment
Windows 7 SP1 Official setup exe version 13.0.5 from Tor Project website.
https://i.ibb.co/GPTpZFD/empty-CAPTCHA.png
![empty-CAPTCHA.png](/uploads/87047b27eb4933f6cadce9018143b20d/empty-CAPTCHA.png)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42282"Tor Browser" entry created in registry Editor under HKLM and HKCR2024-01-09T13:58:23Zcypherpunks"Tor Browser" entry created in registry Editor under HKLM and HKCR"Tor Browser" entry created in registry Editor under HKLM and HKCR"Tor Browser" entry created in registry Editor under HKLM and HKCRcypherpunkscypherpunkshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42281Stop creation attempt of Launcher2024-01-09T13:57:33ZcypherpunksStop creation attempt of LauncherWindows Logs > Application Error
The description for Event ID 5 from source Tor Browser Launcher cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You ...Windows Logs > Application Error
The description for Event ID 5 from source Tor Browser Launcher cannot be found. Either the component that raises this event is not installed on your local computer or the installation is corrupted. You can install or repair the component on the local computer.
If the event originated on another computer, the display information had to be saved with the event.
The following information was included with the event:cypherpunkscypherpunkshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42244New Identity refused2023-11-06T23:32:51ZguenterNew Identity refusedclicking on 'New Identity' results in an error message like this (I
replaced German Anwendung by Application)
-->-a-<--
JavaScript Application
New Identity unexpected error: SyntaxError: JSON.parse: expected
double-quoted proper...clicking on 'New Identity' results in an error message like this (I
replaced German Anwendung by Application)
-->-a-<--
JavaScript Application
New Identity unexpected error: SyntaxError: JSON.parse: expected
double-quoted property name at line 5 column 3 of the JSON data
++<-o-++
The browser seems not to be restarted.
OS-Info: Windows 10 Pro (German locale)
Version 22H2
Build 19045.3636
Tor Browser 13.0.1
Maybe this is an operating system related issue, because on debian 11.8 platform a new identity is created and the browser is restarted.guenterguenterhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42179PTs on Tor Browser 13 do not work with Windows 72024-01-08T17:36:11ZninaPTs on Tor Browser 13 do not work with Windows 7The user shared logs with me:
\[NOTICE\] Opening Socks listener on 127.0.0.1:9150
\[NOTICE\] Opened Socks listener connection (ready) on 127.0.0.1:9150
\[WARN\] Managed proxy "N/A" process terminated with status code 0
\[WARN\] Ma...The user shared logs with me:
\[NOTICE\] Opening Socks listener on 127.0.0.1:9150
\[NOTICE\] Opened Socks listener connection (ready) on 127.0.0.1:9150
\[WARN\] Managed proxy "N/A" process terminated with status code 0
\[WARN\] Managed proxy "TorBrowser\\Tor\\PluggableTransports\\lyrebird.exe" process terminated with status code 3221225477
\[ERR\] tor_assertion_failed\_: Bug: transports.c:519: proxy_prepare_for_restart: Assertion mp-\>conf_state == PT_PROTO_COMPLETED failed; aborting. (on Tor 0.4.8.7 bf5e234d44e73127)
\[ERR\] Bug: Tor 0.4.8.7 (git-bf5e234d44e73127): Assertion mp-\>conf_state == PT_PROTO_COMPLETED failed in proxy_prepare_for_restart at transports.c:519: . (Stack trace not available) (on Tor 0.4.8.7 bf5e234d44e73127)
After restart the user got the message the program lyrebird.exe has stopped working Error code BEX64
Downgrade to previous version of TB helpedPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42171windows: 13.0 shortcut not using new icon2023-10-13T03:45:54ZThorinwindows: 13.0 shortcut not using new iconSo I added 12.5.6 in advance and updated via app update check. I added my own shortcut (after updating to 13). See pics. I am lacking a few tools (newish pc) but clearly the new icon is there
Note: see the alpha shortcuts - they were al...So I added 12.5.6 in advance and updated via app update check. I added my own shortcut (after updating to 13). See pics. I am lacking a few tools (newish pc) but clearly the new icon is there
Note: see the alpha shortcuts - they were all OLD ones, and they automagically changed to the new one - so what gives
![shortcuts](/uploads/dc3ced1e449573fd9f42d967133675b4/shortcuts.png)
![properties](/uploads/9c27e5e8a3451d2b34b65424d5b763a5/properties.png)https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42163Make the 3rd party DLL blocklist obey portable mode2023-12-06T17:21:32ZThorinMake the 3rd party DLL blocklist obey portable modecontext: https://forum.torproject.org/t/how-remove-third-party-modules/9626
- ~~note for mullvad browser: allowing bonjour (in the link above) in windows 7 enabled mDNS for webrtc~~
We could/should tighten this up, if it isn't already
...context: https://forum.torproject.org/t/how-remove-third-party-modules/9626
- ~~note for mullvad browser: allowing bonjour (in the link above) in windows 7 enabled mDNS for webrtc~~
We could/should tighten this up, if it isn't already
cc: @pierovPier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42154Empty the clipboard on browser shutdown only if content comes from private br...2023-11-07T16:50:23Zcypherpunks1Empty the clipboard on browser shutdown only if content comes from private browsing windowsThe user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.The user may not expect or need this feature (#42019) and maybe it should additionally be disabled for non-private browsing mode.
One issue is that the clipboard is emptied even if its contents did not originate from a browser.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42105Mullvad Browser (maybe tor browser) on win11 with Desktop on Onedrive becomes...2023-10-11T21:40:15ZDan BallardMullvad Browser (maybe tor browser) on win11 with Desktop on Onedrive becomes unrunnableWill need more testing to reproduce, but a new laptop I was helping setup defaulted to Desktop on OneDrive. Mullvad Browser installed to desktop, ran, but shortly later could not be run. The `Start Mullvad Browser` link lined to Mullvard...Will need more testing to reproduce, but a new laptop I was helping setup defaulted to Desktop on OneDrive. Mullvad Browser installed to desktop, ran, but shortly later could not be run. The `Start Mullvad Browser` link lined to Mullvard Browser/Browser which was gone.
A little checking, OneDrive is case insensitive, I believe the fact we have a `Browser` executable and `browser` directory caused some collision cus sure enough, a bit after installing the `Browser` executable disappeared and Mullvad Browser was unrunnable. We've just unlinked OneDrive from the computer and it seems this is no longer happening.https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42098Implement Windows installer icons2023-10-03T13:27:35ZnicobImplement Windows installer iconsInstaller icons with refreshed browser icons ready to implement!
All release versions here in 256, 48, 32, and 16px: [installer icons](https://nc.torproject.net/s/ZFWk9yoCNJjSWmA)Installer icons with refreshed browser icons ready to implement!
All release versions here in 256, 48, 32, and 16px: [installer icons](https://nc.torproject.net/s/ZFWk9yoCNJjSWmA)Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42087Implement Windows application icons2023-10-03T13:27:38ZnicobImplement Windows application iconsTor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Windows** assets:
* [stable](https://nc.torproject.net/s/4FqccSRweqgt2Wr)
* [alpha](https://nc.torproje...Tor Browser application icons have gotten a refresh from the UX & Design team - this ticket will serve to track implementation for **Windows** assets:
* [stable](https://nc.torproject.net/s/4FqccSRweqgt2Wr)
* [alpha](https://nc.torproject.net/s/zrd9B5H3RKTTA9o)
* [nightly](https://nc.torproject.net/s/fpAyWDfMm9cRtx8)henryhenryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42010Review Mozilla 1810641: Enable overscroll on Windows on all channels2023-10-05T12:57:01ZrichardReview Mozilla 1810641: Enable overscroll on Windows on all channelsLink: https://bugzilla.mozilla.org/show_bug.cgi?id=1810641
@thorin is overscroll something we need to consider re ~Fingerprinting or is it a case where so-long as everyone has it it's fine. Skimming the ticket suggests the overscroll on...Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1810641
@thorin is overscroll something we need to consider re ~Fingerprinting or is it a case where so-long as everyone has it it's fine. Skimming the ticket suggests the overscroll only happens when scrolling via touch.
EDIT: fwiw enabling the provided pref on Linux did not enable any new functionality on my laptop, but libinput is kind of a shitshow w/ regards to touchpad support/functionality so it may just be seeing it a mouse+scroll wheel.
/cc @donutshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42008Review Mozilla 1808146: Copying images from Pixiv and pasting them in certain...2023-10-05T17:15:48ZrichardReview Mozilla 1808146: Copying images from Pixiv and pasting them in certain programs is brokenLink: https://bugzilla.mozilla.org/show_bug.cgi?id=1808146
So in some instances on Windows when you copy an image to paste in another app, what is actually copied is the URL (and now including referrer) and the image is then resolved wi...Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1808146
So in some instances on Windows when you copy an image to paste in another app, what is actually copied is the URL (and now including referrer) and the image is then resolved with a separate web request; unclear where the web request happens whether in Firefox, in some OS clipboard service, or from the target application.
Could be a big deal or nothing depending.ma1ma1https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41995Generated headers on Windows aren't reproducible2023-10-03T15:38:10ZPier Angelo VendrameGenerated headers on Windows aren't reproducibleOn of the two reproducibility problems of 13.0a1 was that the Windows generated headers weren't equal (but only on x86_64, and only for Tor Browser, not for Mullvad Browser).
This was the diff:
```diff
diff '--color=auto' -rupN debug-r...On of the two reproducibility problems of 13.0a1 was that the Windows generated headers weren't equal (but only on x86_64, and only for Tor Browser, not for Mullvad Browser).
This was the diff:
```diff
diff '--color=auto' -rupN debug-richard/include/mozilla/WindowsDllBlocklistLauncherDefs.h debug-pierov/include/mozilla/WindowsDllBlocklistLauncherDefs.h
--- debug-richard/include/mozilla/WindowsDllBlocklistLauncherDefs.h 2023-08-08 07:11:00.000000000 +0200
+++ debug-pierov/include/mozilla/WindowsDllBlocklistLauncherDefs.h 2023-08-08 07:11:00.000000000 +0200
@@ -13,7 +13,7 @@ DLL_BLOCKLIST_DEFINITIONS_BEGIN
DLL_BLOCKLIST_ENTRY("activedetect32.dll", DllBlockInfo::UNVERSIONED)
DLL_BLOCKLIST_ENTRY("activedetect64.dll", DllBlockInfo::UNVERSIONED)
DLL_BLOCKLIST_ENTRY("asuswsshellext64.dll", MAKE_VERSION(1, 1, 0, 27), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
- DLL_BLOCKLIST_ENTRY("aswhook.dll", DllBlockInfo::ALL_VERSIONS, mozilla::DllBlockInfoFlags::UTILITY_PROCESSES_ONLY | mozilla::DllBlockInfoFlags::BLOCK_WIN7_AND_OLDER)
+ DLL_BLOCKLIST_ENTRY("aswhook.dll", DllBlockInfo::ALL_VERSIONS, mozilla::DllBlockInfoFlags::BLOCK_WIN7_AND_OLDER | mozilla::DllBlockInfoFlags::UTILITY_PROCESSES_ONLY)
DLL_BLOCKLIST_ENTRY("aswjsflt.dll", MAKE_VERSION(18, 0, 1473, 0), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
DLL_BLOCKLIST_ENTRY("atkdx11disp.dll", DllBlockInfo::ALL_VERSIONS)
DLL_BLOCKLIST_ENTRY("audiodevprops2.dll", MAKE_VERSION(2, 6, 14, 0), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
diff '--color=auto' -rupN debug-richard/include/mozilla/WindowsDllBlocklistLegacyDefs.h debug-pierov/include/mozilla/WindowsDllBlocklistLegacyDefs.h
--- debug-richard/include/mozilla/WindowsDllBlocklistLegacyDefs.h 2023-08-08 07:11:00.000000000 +0200
+++ debug-pierov/include/mozilla/WindowsDllBlocklistLegacyDefs.h 2023-08-08 07:11:00.000000000 +0200
@@ -13,7 +13,7 @@ DLL_BLOCKLIST_DEFINITIONS_BEGIN
DLL_BLOCKLIST_ENTRY("activedetect32.dll", DllBlockInfo::UNVERSIONED)
DLL_BLOCKLIST_ENTRY("activedetect64.dll", DllBlockInfo::UNVERSIONED)
DLL_BLOCKLIST_ENTRY("asuswsshellext64.dll", MAKE_VERSION(1, 1, 0, 27), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
- DLL_BLOCKLIST_ENTRY("aswhook.dll", DllBlockInfo::ALL_VERSIONS, mozilla::DllBlockInfoFlags::UTILITY_PROCESSES_ONLY | mozilla::DllBlockInfoFlags::BLOCK_WIN7_AND_OLDER)
+ DLL_BLOCKLIST_ENTRY("aswhook.dll", DllBlockInfo::ALL_VERSIONS, mozilla::DllBlockInfoFlags::BLOCK_WIN7_AND_OLDER | mozilla::DllBlockInfoFlags::UTILITY_PROCESSES_ONLY)
DLL_BLOCKLIST_ENTRY("aswjsflt.dll", MAKE_VERSION(18, 0, 1473, 0), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
DLL_BLOCKLIST_ENTRY("atkdx11disp.dll", DllBlockInfo::ALL_VERSIONS)
DLL_BLOCKLIST_ENTRY("audiodevprops2.dll", MAKE_VERSION(2, 6, 14, 0), mozilla::DllBlockInfoFlags::BROWSER_PROCESS_ONLY)
```
It isn't a very big deal: the include are human readable.
PDBs, that are binary, were exactly the same.
I think the main problem is that it forces us to check the contents of the hashes files, but it's not so bad that we'll need to block the release.
In case we can even decide to omit the debug zip file either from the release or from the hashfile.
However, it'd be nice of we can understand why the files aren't exactly the same, and fix this problem.
Notice that I decided to include header files because I remember that when debugging with Visual Studio I was prompted for them.Pier Angelo VendramePier Angelo Vendramehttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/41944Review Mozilla 1774083: Add Surrogate COM Server to handle native Windows not...2023-10-05T17:15:48ZrichardReview Mozilla 1774083: Add Surrogate COM Server to handle native Windows notifications when Firefox is closed.Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1774083
On windows COM servers are registered in the registy (if i recall correctly). We should make sure any such registration is gated behind w/e pref is used to disable notifications.Link: https://bugzilla.mozilla.org/show_bug.cgi?id=1774083
On windows COM servers are registered in the registy (if i recall correctly). We should make sure any such registration is gated behind w/e pref is used to disable notifications.