Tor Browser issueshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues2020-08-18T16:54:34Zhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40085Review update flow2020-08-18T16:54:34ZAntonelaantonela@torproject.orgReview update flowWe should check if Tor Browser is up-to-date and suggest updating if is not.We should check if Tor Browser is up-to-date and suggest updating if is not.Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40024Go over rebased patches again and reorder pieces where needed after rebase to...2020-08-08T10:53:00ZGeorg KoppenGo over rebased patches again and reorder pieces where needed after rebase to esr78 is doneWe've reordered/squashed bits of our patch set during #31918. We should do this again once we have the rebasing to esr78 done and are happy with the results.
@acat noted in #33533: One example that comes to my mind for this is the secur...We've reordered/squashed bits of our patch set during #31918. We should do this again once we have the rebasing to esr78 done and are happy with the results.
@acat noted in #33533: One example that comes to my mind for this is the security level patch, which introduces a localization mecanism which is later replaced by `TorStrings.jsm` in the #31286 patch.
Additionally, there are `firefox-branding.js` changes that moved to the updater related patch. We might want to think about something that's less surprising. :slight_smile:
---
- [x] #40047Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/40017Audit Firefox 68-78 diff for proxy issues2020-10-13T21:13:06ZMike PerryAudit Firefox 68-78 diff for proxy issuesThis audit is for the code in gecko-dev.
The fenix component/UI audit is https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34177This audit is for the code in gecko-dev.
The fenix component/UI audit is https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34177Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsMike PerryMike Perry2020-08-25https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/34178Implement new UI changes as determined in O2.12020-11-12T14:46:54ZMatthew FinkelImplement new UI changes as determined in O2.1Update the Tor Browser for Android codebase to use Fenix instead of Fennec.
- [x] ["Only Private Browsing Mode" on Android](tpo/applications/fenix#40006)
- [x] [Modify Fenix menu items](tpo/applications/fenix#40007)
- [x] fenix#40026
...Update the Tor Browser for Android codebase to use Fenix instead of Fennec.
- [x] ["Only Private Browsing Mode" on Android](tpo/applications/fenix#40006)
- [x] [Modify Fenix menu items](tpo/applications/fenix#40007)
- [x] fenix#40026
- [x] fenix#40028Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33962Uplift patch for 5741 (dns leak protection)2020-11-19T23:31:51ZAlex CatarineuUplift patch for 5741 (dns leak protection)This should probably be under the `--enable-proxy-bypass-protection` flag.This should probably be under the `--enable-proxy-bypass-protection` flag.Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsMike PerryMike Perryhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33867Disable password manager and password generation2020-07-14T18:13:36ZrichardDisable password manager and password generationDisable the integrated password manager and password generation feature as part of disk avoidance.
Feature documentation: https://wiki.mozilla.org/Toolkit:Password_Manager/Password_Generation
Set preferences:
- signon.generation.avail...Disable the integrated password manager and password generation feature as part of disk avoidance.
Feature documentation: https://wiki.mozilla.org/Toolkit:Password_Manager/Password_Generation
Set preferences:
- signon.generation.available=false
- signon.generation.enabled=falseSponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33852Clean up about:logins (LockWise) to avoid mentioning sync, etc.2020-07-24T18:32:19ZrichardClean up about:logins (LockWise) to avoid mentioning sync, etc.LockWise is a new built-in password manager in firefox with Sync integration
For now can currently be disabled by (fallsback to old password storage UI):
- signon.management.overrideURI = ""LockWise is a new built-in password manager in firefox with Sync integration
For now can currently be disabled by (fallsback to old password storage UI):
- signon.management.overrideURI = ""Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33851Patch out Parental Controls detection and logging2020-07-28T17:39:16ZrichardPatch out Parental Controls detection and loggingWe should remove the per-OS implementations of nsIParentalControlsService in `/toolkit/components/parentalcontrols` and always use the stubbed-out `nsParentalControlsServiceDefault.cpp` implementation.
When an implementation is present,...We should remove the per-OS implementations of nsIParentalControlsService in `/toolkit/components/parentalcontrols` and always use the stubbed-out `nsParentalControlsServiceDefault.cpp` implementation.
When an implementation is present, URIs are sent to an `isAllowed(...` function that parental control software presumably can hook in the OS to filter content, and a `log(...)` method also takes in URIs.Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33664Sponsor 58: Tor Browser Security, Performance, & Usability Improvements2020-12-21T18:02:27ZPili GuerraSponsor 58: Tor Browser Security, Performance, & Usability ImprovementsProject Period: 4/1/2020 - 9/31/2020
With this project we are completing the migration of Tor Browser for Android from [Fennec](https://wiki.mozilla.org/Mobile/Fennec) to [Fenix](https://github.com/mozilla-mobile/fenix).
[Progress ...Project Period: 4/1/2020 - 9/31/2020
With this project we are completing the migration of Tor Browser for Android from [Fennec](https://wiki.mozilla.org/Mobile/Fennec) to [Fenix](https://github.com/mozilla-mobile/fenix).
[Progress milestone](https://gitlab.torproject.org/groups/tpo/-/milestones/11).
Objective 1: Build the infrastructure and processes to enable us to migrate Tor Browser for Android away from Fennec (on the Firefox Extended Support Release cycle) and onto Fenix (on the Firefox regular release cycle).
* [x] [O1.1 - Set up QA and regression test infrastructure](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33654)
* [ ] [O1.2 - Update infrastructure to automatically rebase tor-browser.git patches onto Firefox-beta so they can be used in nightly builds](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33656)
Objective 2: Migrate Tor Browser for Android onto Fenix and away from Fennec.
* [x] [O2.1: Evaluate and address Fennec vs. Fenix UI changes](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33658)
* [x] [O2.2: Update build system for Fenix migration](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33659)
* [ ] [O2.3: Update existing QA and regression test infrastructure for Fenix](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33660)
* [ ] [O2.4: Migrate Tor Browser for Android from ESR68 to Fenix](https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33661)
Old wiki page: https://trac.torproject.org/projects/tor/wiki/org/sponsors/Sponsor58Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGabagaba@torproject.orgGabagaba@torproject.org2020-12-23https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33661[S58] O2.4: Migrate Tor Browser for Android from ESR68 to Fenix.2021-06-25T19:33:44ZPili Guerra[S58] O2.4: Migrate Tor Browser for Android from ESR68 to Fenix.- Audit Fenix code for tracking, fingerprintability, and Tor safety features in relation to various known attacks.
- Audit code changes since last audit for proxy bypass bugs, following our audit procedure.
- Review all Mozilla devel...- Audit Fenix code for tracking, fingerprintability, and Tor safety features in relation to various known attacks.
- Audit code changes since last audit for proxy bypass bugs, following our audit procedure.
- Review all Mozilla developer documentation since the last audit for major changes that could impact our tracking and fingerprinting defenses.
- Review all closed bugs in Mozilla's bug tracker to find changes not mentioned in the developer documentation that still affect our users and their threat model.
- Update the Tor Browser for Android codebase to use Fenix instead of Fennec.
- Implement new UI changes as determined in O2.2.
- Integrate tor into Fenix.
- Integrate necessary webextensions into Fenix.
- Rewrite patches from Fennec into Fenix.
- Implement and test migration logic to allow users to seamlessly upgrade from Tor Browser for Android based on Gecko to Tor Browser for Android based on Fenix.
- Release a new version of Tor Browser for Android based on Fenix.
- Document and report in a retrospective on the success of our migration process from Fennec to Fenix
* [x] [Rebase Tor Browser esr68 patches on top of mozilla-central](#33533)
* [x] [Review FF release notes from FF69 to latest (FF75)](#33534)
* [x] [Investigate new Search Engine configuration](#33697)
* [x] [Decide which components of Fenix to rip out, disable, or use](fenix#33939)
* [x] [Audit Fenix code for tracking, fingerprintability, and safety features](fenix#34177)
* [x] [Implement new UI changes as determined in O2.1](#34178)
* [x] [Test migration logic from Fennec to Fenix](fenix#34179)
* [x] [Release a new version of Tor Browser for Android based on Fenix](#33808)
* [x] [Publish Fenix-based testing versions on Google Play](#40027)Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33660[S58] O2.3: Update existing QA and regression test infrastructure for Fenix.2020-12-21T17:52:09ZPili Guerra[S58] O2.3: Update existing QA and regression test infrastructure for Fenix.* [x] [Add support for Fenix into existing Tor Browser regression and integration tests](#34180)
* [ ] [Fix broken Fenix tests](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34181)
* [ ] [Write new integration tests for T...* [x] [Add support for Fenix into existing Tor Browser regression and integration tests](#34180)
* [ ] [Fix broken Fenix tests](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34181)
* [ ] [Write new integration tests for Tor Browser based on Fenix based on O1.2](https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite/-/issues/34182)Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33659[S58] O2.2: Update build system for Fenix migration.2020-10-08T22:22:06ZPili Guerra[S58] O2.2: Update build system for Fenix migration.- Integrate Fenix and necessary dependencies into our reproducible builds system.
- Add new toolchains for targeted Fenix release.
- Verify that bundles are still reproducible after toolchain updates.- Integrate Fenix and necessary dependencies into our reproducible builds system.
- Add new toolchains for targeted Fenix release.
- Verify that bundles are still reproducible after toolchain updates.Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33658[S58] O2.1: Evaluate and address Fennec vs. Fenix UI changes.2020-10-21T15:33:55ZPili Guerra[S58] O2.1: Evaluate and address Fennec vs. Fenix UI changes.- Review changes to Fenix UI and evaluate their impact in the context of Tor Browser for Android and its users using the Tor Personas tool as a guide.
- Iterate on any necessary UI changes.
* [x] [Re-design Connect screen on Android](h...- Review changes to Fenix UI and evaluate their impact in the context of Tor Browser for Android and its users using the Tor Personas tool as a guide.
- Iterate on any necessary UI changes.
* [x] [Re-design Connect screen on Android](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34401)
* [x] [Re-design Network Settings Screen on Android](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34402)
* [x] [UI changes for "Only Private Browsing Mode" on Android](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34403)
* [x] [Re-design about:tor on Android](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34405)
* [x] [Re-design onion indicators for Android](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34406)
* [x] [Review all Fenix menu items](https://gitlab.torproject.org/tpo/applications/fenix/-/issues/34407)Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33657[S58] Objective 2: Migrate Tor Browser for Android onto Fenix and away from F...2020-06-27T14:31:53ZPili Guerra[S58] Objective 2: Migrate Tor Browser for Android onto Fenix and away from FennecThe work under this Objective involves utilizing the infrastructure and groundwork created in Objective 1 to complete the migration of Tor Browser for Android onto Fenix and the regular Firefox release cycle.The work under this Objective involves utilizing the infrastructure and groundwork created in Objective 1 to complete the migration of Tor Browser for Android onto Fenix and the regular Firefox release cycle.Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGabagaba@torproject.orgGabagaba@torproject.orghttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33656[S58] O1.2: Update infrastructure to automatically rebase tor-browser.git pat...2020-12-21T17:50:05ZPili Guerra[S58] O1.2: Update infrastructure to automatically rebase tor-browser.git patches onto Firefox-beta so they can be used in nightly builds.- Implement tooling, (e.g. quilt, gbp-pq) that similar projects (e.g., Tails) use to automate these kinds of code rebase tasks.
- Work with Mozilla to identify any infrastructure we can set up together to help us to automate our rebase p...- Implement tooling, (e.g. quilt, gbp-pq) that similar projects (e.g., Tails) use to automate these kinds of code rebase tasks.
- Work with Mozilla to identify any infrastructure we can set up together to help us to automate our rebase process.
- Configure alerts to notify the Tor Browser team when automatic rebasing of patches fails.
- Experiment with and adjust cycle length for automatic rebasing procedures (e.g daily versus weekly versus fortnightly) depending on fallout results of this process.
- Manually fix fallout from automatic rebase process.
* [x] [Rebase and squash mobile and desktop patches](#31918)
* [ ] [Implement auto-rebasing tooling](#34183)
* [ ] [Deploy notifications for auto-rebasing failures](#34184)Sponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33654[S58] O1.1 - Set up QA and regression test infrastructure2020-10-08T22:22:06ZPili Guerra[S58] O1.1 - Set up QA and regression test infrastructure- Work with Mozilla to identify if any existing Firefox testing infrastructure can be used to run automated tests on our rebased codebase.
- Evaluate Firefox tests and Try builds to identify any currently broken functionality.
- Audit e...- Work with Mozilla to identify if any existing Firefox testing infrastructure can be used to run automated tests on our rebased codebase.
- Evaluate Firefox tests and Try builds to identify any currently broken functionality.
- Audit existing Tor Browser tests to identify which tests are missing and need to be written; audit existing Firefox tests to determine which tests need to be disabled because they test undesired behavior in Tor Browser.
- Configure integration testing infrastructure.
- Fix existing regression tests that are currently failing after testing and audits.
* [x] [Fix Tor Browser testsuite](https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite/-/issues/27105)
* [x] [Fix tor-browser tbb-tests](#30832)
* [x] [Evaluate Firefox tests](#33791)Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGabagaba@torproject.orgGabagaba@torproject.org2020-06-30https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33653[S58] Objective 1: Build the infrastructure and processes to enable us to mig...2020-06-27T14:31:54ZPili Guerra[S58] Objective 1: Build the infrastructure and processes to enable us to migrate Tor Browser for Android away from Fennec and onto FenixThis Objective and all of its Activities lay the groundwork necessary to complete the migration of both Tor Browser for Android and Tor Browser for desktop onto the regular release cycles.This Objective and all of its Activities lay the groundwork necessary to complete the migration of both Tor Browser for Android and Tor Browser for desktop onto the regular release cycles.Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGabagaba@torproject.orgGabagaba@torproject.orghttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33565Upgrade LZMA to use Android NDK 202020-06-27T14:31:55ZShane IsbellUpgrade LZMA to use Android NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 20.
Make standalone toolchain is not longer supported in NDK 20 so need to configure to use new locationsThis is based of the current work done in branch for android support. We need to upgrade to build with NDK 20.
Make standalone toolchain is not longer supported in NDK 20 so need to configure to use new locationsSponsor 58 - Tor Browser Security, Performance, & Usability Improvementshttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33562Upgrade libevent to use NDK 202020-06-27T14:31:56ZShane IsbellUpgrade libevent to use NDK 20This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations.This is based of the current work done in branch for android support. We need to upgrade to build with NDK 21.
Make standalone toolchain is not longer supported in NDK 21 so need to configure to use new locations.Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsGeorg KoppenGeorg Koppenhttps://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/33534Review FF release notes from FF69 to latest (FF78)2022-11-10T16:33:52ZrichardReview FF release notes from FF69 to latest (FF78)Release Notes: https://www.mozilla.org/en-US/firefox/releases/
Developer release notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases
Also, diff prefs.js between latest and esr 68.
Also look at the bugs from 69 to 7...Release Notes: https://www.mozilla.org/en-US/firefox/releases/
Developer release notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases
Also, diff prefs.js between latest and esr 68.
Also look at the bugs from 69 to 78 (update target_milestone param for each version)
Mozilla fixed: https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=mozilla69&order=priority%2Cbug_severity&limit=0
Mozilla reponed: https://bugzilla.mozilla.org/buglist.cgi?resolution=---&query_format=advanced&target_milestone=mozilla69
Firefox fixed: https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&resolution=FIXED&target_milestone=Firefox%2069&order=priority%2Cbug_severity&limit=0Sponsor 58 - Tor Browser Security, Performance, & Usability ImprovementsMike PerryMike Perry