Update #16940 patch for e10s (about:tbupdate)

+  // When electrolysis is enabled we will need to adopt an architecture that is
+  // more similar to the one that is used for about:home (see AboutHomeListener
+  // in this file and browser/modules/AboutHome.jsm).

added TorBrowserTeam201803R in Legacy / Trac component::applications/tor browser in Legacy / Trac ff52-esr in Legacy / Trac owner::tbb-team in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-7.0-must in Legacy / Trac tbb-e10s in Legacy / Trac type::defect in Legacy / Trac labels

Getting this on our radar for alpha release in less than two weeks.

Trac:
Keywords: tbb-7.0-must deleted, tbb-7.0-must-alpha added

Moving our tickets to May 2017.

Trac:
Keywords: TorBrowserTeam201704 deleted, TorBrowserTeam201705 added

We are beyond the alpha testing. Moving tickets for tbb-7.0-must.

Trac:
Keywords: tbb-7.0-must-alpha deleted, tbb-7.0-must added

Trac:
Keywords: N/A deleted, tbb-e10s added

Moving our tickets to June.

Trac:
Keywords: TorBrowserTeam201705 deleted, TorBrowserTeam201706 added

Trac:
Summary: Update legacy/trac#16940 (moved) patch for e10s to Update legacy/trac#16940 (moved) patch for e10s (about:tbupdate)

Moving Tickets to July 2017.

Trac:
Keywords: TorBrowserTeam201706 deleted, TorBrowserTeam201707 added

Moving our Tickets to August.

Trac:
Keywords: TorBrowserTeam201707 deleted, TorBrowserTeam201708 added

https://blog.torproject.org/comment/270354#comment-270354 ff. had some discussion relevant to this bug. Leading to https://developer.mozilla.org/en-US/Firefox/Multiprocess_Firefox/Which_URIs_load_where and https://bugzilla.mozilla.org/show_bug.cgi?id=1257201.

Items for September 2017.

Trac:
Keywords: TorBrowserTeam201708 deleted, TorBrowserTeam201709 added

Items for October 2017

Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201710 added

Moving tickets over to November.

Trac:
Keywords: TorBrowserTeam201710 deleted, TorBrowserTeam201711 added

Moving tickets to December 2017

Moving tickets to December 2017, for realz.

Trac:
Keywords: TorBrowserTeam201711 deleted, TorBrowserTeam201712 added

Moving tickets to 2018.

Trac:
Keywords: TorBrowserTeam201712 deleted, TorBrowserTeam201801 added

While the existing code functions correctly with or without electrolysis enabled, we improved it (see the check in comment for details). The fixup patch is here: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug21850-01&id=3d3272e7b56ed23c18f3ba1f3fbb1821118e164c

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201801 deleted, TorBrowserTeam201801R added

We forgot about comment:9. Here is an additional fixup patch that forces about:tbupdate to always be loaded in a content process: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug21850-01&id=7a7c6b380c95a00f3091aa8f79c24bd76a0a2cbc

It seems safer to do this and should not cause any harm (we already force the same behavior for about:tor).

Moving reviews to February.

Trac:
Keywords: TorBrowserTeam201801R deleted, TorBrowserTeam201802R added

Moving our reviews to March 2018

Trac:
Keywords: TorBrowserTeam201802R deleted, TorBrowserTeam201803R added

Nice work! One thing I don't understand: why do you have

+if (AppConstants.TOR_BROWSER_UPDATE) {
+  XPCOMUtils.defineLazyModuleGetter(this, "AboutTBUpdate",
+    "re[//modules/AboutTBUpdate.jsm");](//modules/AboutTBUpdate.jsm");)
+}

in browser.js? It seems you don't use anything from that module there.

Trac:
Status: needs_review to needs_information

Replying to gk:

Nice work! One thing I don't understand: why do you have {{{ +if (AppConstants.TOR_BROWSER_UPDATE) {

• XPCOMUtils.defineLazyModuleGetter(this, "AboutTBUpdate",
• "re//modules/AboutTBUpdate.jsm");;) +} }}} in browser.js? It seems you don't use anything from that module there.

You are correct; that part of the patch is not needed. Here is a revised (and rebased) patch: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug21850-02

Trac:
Status: needs_information to needs_review

Thanks, looks good now. \o/ Applied to tor-browser-52.7.3esr-8.0-1 (commit 7719a132).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue legacy/trac#24578 (moved)

moved from legacy/trac#21850 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label