TBB Size 1000x610 Mac

The browser size is 1000x610 on my Mac running 10.12.6 (16G29) TBB 7.0.2 and TBB 7.5a2

Trac:
Username: Dbryrtfbcbhgf

added TorBrowserTeam201708R in Legacy / Trac component::applications/tor browser in Legacy / Trac owner::tbb-team in Legacy / Trac priority::high in Legacy / Trac reporter::Dbryrtfbcbhgf in Legacy / Trac resolution::fixed in Legacy / Trac severity::major in Legacy / Trac status::closed in Legacy / Trac tbb-7.0-issues in Legacy / Trac tbb-fingerprinting-resolution in Legacy / Trac tbb-regression in Legacy / Trac tbb-torbutton in Legacy / Trac type::defect in Legacy / Trac labels

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Test site I used. http://whatsmy.browsersize.com/

Trac:
Username: Dbryrtfbcbhgf

Trac:
Keywords: N/A deleted, tbb-fingerprinting-resolution added
Cc: N/A to arthuredelstein

I wonder if that's a new problem with Tor Browser 7. Could you test with an older one (e.g. 6.5.2)? See: https://archive.torproject.org/tor-package-archive/torbrowser/6.5.2/ for bundles. Make sure your test session starts without the security-slider-hint-notification bar which you see on the very first start.

Trac:
Status: new to needs_information

Replying to gk:

I wonder if that's a new problem with Tor Browser 7. Could you test with an older one (e.g. 6.5.2)? See: https://archive.torproject.org/tor-package-archive/torbrowser/6.5.2/ for bundles. Make sure your test session starts without the security-slider-hint-notification bar which you see on the very first start. I tested version 6.5.2 and attached a photo of the results. Browser window width: 1000 Browser window height: 609

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Interesting. Do you feel like you could test a vanilla Firefox beta (55b10) which is containing the same patches we ship. You can find it on https://ftp.mozilla.org/pub/firefox/releases/55.0b10/mac/en-US/. After first start you need to enable fingerprinting resistance by setting privacy.resistFingerprinting to true. After restarting could you make your test again and share the results in this ticket?

Replying to gk:

Interesting. Do you feel like you could test a vanilla Firefox beta (55b10) which is containing the same patches we ship. You can find it on https://ftp.mozilla.org/pub/firefox/releases/55.0b10/mac/en-US/. After first start you need to enable fingerprinting resistance by setting privacy.resistFingerprinting to true. After restarting could you make your test again and share the results in this ticket? I followed all the above directions and here are my results. Browser window width: 1000 Browser window height: 597

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf

Hm. Where does that "startpages" item come from? Is that a toolbar that is on by default? I wonder whether an older Firefox you had on your computer could cause this and thus interfere with the test.

I had the stable version of Firefox installed before a test at the Beta, I can retry to test by first deleting all of Firefox preference files,

Trac:
Username: Dbryrtfbcbhgf

Replying to Dbryrtfbcbhgf:

I had the stable version of Firefox installed before a test at the Beta, I can retry to test by first deleting all of Firefox preference files,

That might help. Or just creating a new profile via about:profiles and using that one for the test. Thanks!

After I deleted all the Firefox preference files I got these results. Browser window width: 1000 Browser window height: 600 I retested Tor browser bundle 7.0.2 and still got the same results. Browser window width: 1000 Browser window height: 610

Trac:
Username: Dbryrtfbcbhgf

Thanks. Could you test Tor Browser with NoScript and/or HTTPS Everywhere being disabled? Maybe having their toolbar buttons injected into the toolbar is causing this.

Posted below

Trac:
Username: Dbryrtfbcbhgf

Trac:
Username: Dbryrtfbcbhgf
Priority: Medium to High

Trac:
Username: Dbryrtfbcbhgf
Milestone: N/A to Tor: 0.3.2.x-final
Severity: Normal to Major

Replying to gk:

Thanks. Could you test Tor Browser with NoScript and/or HTTPS Everywhere being disabled? Maybe having their toolbar buttons injected into the toolbar is causing this. When I disable the torbutton extension but have HTTPS Everywhere and Noscript extensions enabled I get.

== Browser window width: 1000 == Browser window height: 600

HTTPS Everywhere disabled. Browser window width: 1000 Browser window height: 610 Noscript disabled Browser window width: 1000 Browser window height: 610 Both HTTPS Everywhere and Noscript disabled Browser window width: 1000 Browser window height: 610 When I set the security slider to low I get. Browser window width: 1000 Browser window height: 610 Tested on TBB 7.0.2

Trac:
Username: Dbryrtfbcbhgf

Okay, thanks. So, the Torbutton extension is causing this, interesting. Probably as it inserts the button into the toolbar after the window got rounded which makes it larger. Hrm.

Trac:
Status: needs_information to assigned
Milestone: Tor: 0.3.2.x-final to N/A
Keywords: N/A deleted, tbb-torbutton added

Resolving legacy/trac#23264 (moved) as a duplicate.

Here's a patch for review:

https://github.com/arthuredelstein/torbutton/commit/22989

Trac:
Status: assigned to needs_review
Keywords: N/A deleted, TorBrowserTeam201708R added

Does this also fix legacy/trac#22543 (moved)?

Replying to cypherpunks:

Does this also fix legacy/trac#22543 (moved)?

Yes, my testing indicates that it does fix that ticket as well as the issues in ticket:22543#comment:2 and ticket:22543#comment:3.

Could you split up the patch and do the fullscreen part in a different patch? I know it's just a tiny thing but we have legacy/trac#20375 (moved) for this issue and having a patch just for that one in that bug makes it easier to follow things and back things out if necessary.

And could you note in the commit message for the patch for this bug that legacy/trac#22543 (moved) gets fixed by your patch as well?

Trac:
Keywords: TorBrowserTeam201708R deleted, TorBrowserTeam201708 added
Status: needs_review to needs_revision

Replying to gk:

Good idea. Here are the two patches as requested:

https://github.com/arthuredelstein/torbutton/commits/22989+1

Trac:
Keywords: TorBrowserTeam201708 deleted, TorBrowserTeam201708R added
Status: needs_revision to needs_review

Okay, the patch for this issue looks good and testing on Linux and Windows (I currently don't have a macOS system handy) show no regressions. I applied it to master and maint-1.9.7 (commit 97380447e4ab66a44abed4ec0aeb5eeabf86404e and 6aa6d6ef1355179d7198f0eb09405ac0968ba4e7).

I added a link for the patch for legacy/trac#20375 (moved) to the respective ticket setting it to needs_review.

Trac:
Status: needs_review to closed
Keywords: N/A deleted, tbb-7.0-issues, tbb-regression added
Resolution: N/A to fixed

closed

mentioned in issue legacy/trac#23264 (moved)

moved from legacy/trac#22989 (moved)

added Bug label and removed 1 deleted label

added Fingerprinting label and removed 1 deleted label