Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 680
    • Issues 680
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #31344
Closed
Open
Created Aug 05, 2019 by Richard Pospesel@richardOwner

SecurityLevelPreferences.uninit() never called on exit of about:preferences

Found this while building out a skeleton for legacy/trac#31286 (moved). Looks like I didn't actually register the unload event callback, so the object's observer callback is never removed. Worst case scenario the 'observe' callback will be called for every time the user has entered about:preferences and repeatedly edit the XUL to reflect the changed security_slider value. Not really a problem but I'll have a fixup patch shortly.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking