Address bar auto-complete is broken on Android
When text is typed into the address bar, none of the auto-complete options are shown.
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Matthew Finkel added TorBrowserTeam201909R in Legacy / Trac actualpoints::0.5 in Legacy / Trac component::applications/tor browser in Legacy / Trac ff68-esr in Legacy / Trac owner::tbb-team in Legacy / Trac points::1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-mobile in Legacy / Trac type::defect in Legacy / Trac labels
added TorBrowserTeam201909R in Legacy / Trac actualpoints::0.5 in Legacy / Trac component::applications/tor browser in Legacy / Trac ff68-esr in Legacy / Trac owner::tbb-team in Legacy / Trac points::1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-mobile in Legacy / Trac type::defect in Legacy / Trac labels
- Author
Trac:
Points: N/A to 1 - Author
This looks like it may be the cause:
// Website suggestions for address bar inputs should not be enabled when running in automation. // After the upgrade to support library v.26 it could fail otherwise unrelated Robocop tests // See https://bugzilla.mozilla.org/show_bug.cgi?id=1385464#c3 if (!isInAutomation) { mBrowserToolbar.setOnFilterListener(new BrowserToolbar.OnFilterListener() { @Override public void onFilter(String searchText, AutocompleteHandler handler) { filterEditingMode(searchText, handler); } }); }
- Author
Building and testing
bug31720_00
now. - Author
Okay, setting for review -
bug31720_01
.Trac:
Keywords: TorBrowserTeam201909 deleted, TorBrowserTeam201909R added
Status: new to needs_review - Developer
Looks good, thanks. Cherry-picked onto
tor-browser-68.1.0esr-9.0-2
(commit 683863bc).Trac:
Status: needs_review to closed
Resolution: N/A to fixed - Author
Trac:
Actualpoints: N/A to 0.5 - Trac closed
closed
- Trac changed time estimate to 8h
changed time estimate to 8h
- Trac added 4h of time spent
added 4h of time spent
- Trac moved from legacy/trac#31720 (moved)
moved from legacy/trac#31720 (moved)