reapply window.open() clamping

In alpha we seem to have lost the 10px clamping for new windows (which are opened in a new tab: see legacy/trac#9881 (moved) )

• See https://bugzilla.mozilla.org/show_bug.cgi?id=1556016
• See https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html - click the new window button

Pic to follow: example of a user resizing the browser for more real estate: which we want to encourage for uptake and for the letterboxing buckets to be less FP'able (I assume).

Would be good to upstream it

added component::applications/tor browser in Legacy / Trac ff68-esr in Legacy / Trac owner::tbb-team in Legacy / Trac priority::high in Legacy / Trac severity::normal in Legacy / Trac status::new in Legacy / Trac tbb-fingerprinting-resolution in Legacy / Trac type::defect in Legacy / Trac labels

Trac:

Trac:

10px clamping

I am not sure whether we want to encourage resizing. However, we are good with the defaults, right? I agree, though that this is an important bug to get fixed.

Trac:
Keywords: N/A deleted, ff68-esr added
Priority: Very High to High

However, we are good with the defaults, right?

Sure. I meant that currently LB is not tied to RFP (i.e. separate pref) and there is https://bugzilla.mozilla.org/show_bug.cgi?id=1538130 which suggests removing new window sizing completely. FYI: I think we should keep it (if that's what you mean by "defaults", and also fix it with the toolbar visible where it throws height out by several pixels), but a consensus hasn't been reached.

Just a heads up, I can bypass the old clamping method (I'll email the details), so when/if we do this, we'll have to think of a more robust solution

moved from legacy/trac#31821 (moved)

added Bug label and removed 1 deleted label

added Fingerprinting label and removed 1 deleted label

changed milestone to %Tor Browser: 11.0 Issues with previous release

added Backlog label

added Roadmap::Future label and removed Backlog label

@thorin what's the good news here?

I'm confused. This is still an issue if that's what you're asking

Yeah I assumed as much :p

just to be clear, the old method was bypassable

added Backlog label

removed Roadmap::Future label

changed milestone to %Sponsor 131 - Phase 5 - Ongoing Maintenance

added Sponsor 131 label

added Roadmap::Future label

removed Backlog label

changed milestone to %Sponsor 131 - Phase 2 - Privacy Browser

mentioned in issue #41434 (closed)

@pierov We can close this now we have fixed leaking pre-rendered LBing. Yes?

Yes, it seems everything is good now (the new window is 1000x1000 even if I resize the browser before; am I looking at the correct thing? Otherwise feel free to reopen). Let's close it and forget about it.

closed

marked this issue as related to tor-browser-build#40668 (closed)