letterboxing: backport bugzilla 1546832
https://bugzilla.mozilla.org/show_bug.cgi?id=1546832
Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.
Mozilla's patch also added the findbar, but that seems to already be applied in TB9 [Edit: need moar coffee: that needs fixing too and is in the patch]
[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Thorin added GeorgKoppen201910 in Legacy / Trac TorBrowserTeam201910R in Legacy / Trac actualpoints::0.1 in Legacy / Trac component::applications/tor browser in Legacy / Trac ff68-esr in Legacy / Trac owner::tbb-team in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-9.0.1-can in Legacy / Trac tbb-backported in Legacy / Trac tbb-fingerprinting-resolution in Legacy / Trac type::enhancement in Legacy / Trac labels
added GeorgKoppen201910 in Legacy / Trac TorBrowserTeam201910R in Legacy / Trac actualpoints::0.1 in Legacy / Trac component::applications/tor browser in Legacy / Trac ff68-esr in Legacy / Trac owner::tbb-team in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac tbb-9.0.1-can in Legacy / Trac tbb-backported in Legacy / Trac tbb-fingerprinting-resolution in Legacy / Trac type::enhancement in Legacy / Trac labels
- Developer
We might want to squeeze that into 9.0.1, if not then at least test it in 9.5a2.
Trac:
Keywords: N/A deleted, TorBrowserTeam201910, tbb-9.0.1-can added Trac:
Description: https://bugzilla.mozilla.org/show_bug.cgi?id=1546832Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.
Mozilla's patch also added the findbar, but that seems to already be applied in TB9
[1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html
to
https://bugzilla.mozilla.org/show_bug.cgi?id=1546832
Docked dev tools does not trigger letterboxing resize. Open TZP [1] on desktop and toggle the inspector on/off. Manually resize the inspector. The screen measurements are real-time.
Mozilla's patch also added the findbar,
but that seems to already be applied in TB9[Edit: need moar coffee: that needs fixing too and is in the patch][1] https://ghacksuserjs.github.io/TorZillaPrint/TorZillaPrint.html
There's also https://bugzilla.mozilla.org/show_bug.cgi?id=1556017 from FF69
- Developer
Thanks! I cherry-picked both patches in my
bug_32250
(https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_32250). Not sure yet whether they should make it directly into 9.0.1 or later into 9.0.2 after baking a bit in 9.5a2.Trac:
Actualpoints: N/A to 0.1
Points: N/A to 0.1
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201910R, GeorgKoppen201910 added
Status: new to needs_review r=brade,r=mcs The backported patches look good. Letting this bake a little while in 9.5a2 seems like a good plan to us.
- Developer
Replying to mcs:
r=brade,r=mcs The backported patches look good. Letting this bake a little while in 9.5a2 seems like a good plan to us.
Yeah, agreed, thanks! Cherry-picked onto
tor-browser-68.2.0esr-9.5-1
(commit 8bd51d4e and e10f77aa). Marking for possible backport.Trac:
Status: needs_review to closed
Resolution: N/A to fixed
Keywords: N/A deleted, tbb-backport added - Developer
- Trac closed
closed
- Trac changed time estimate to 48m
changed time estimate to 48m
- Trac added 48m of time spent
added 48m of time spent
- Trac moved from legacy/trac#32250 (moved)
moved from legacy/trac#32250 (moved)
- Trac added Fingerprinting label and removed 1 deleted label
added Fingerprinting label and removed 1 deleted label