Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,322
    • Issues 1,322
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #33737
Closed
Open
Created Mar 26, 2020 by Alex Catarineu@acat

Fix aboutDialog.js error for Firefox nightlies

When opening the about dialog, there's a TypeError: can't access property "hidden", document.getElementById(...) is null ... aboutDialog.js:56:14 error which also prevents checking for updates (gAppUpdater is not initialized). It's looking for an element with id communityDesc, which was removed in patch

    Bug 10760: Integrate TorButton to TorBrowser core
    
    Bug 26321: New Circuit and New Identity menu items

This path is only hit with Firefox versions that match /a\d+$/, so we see this now in legacy/trac#33533 (moved) because of mozilla-central.

Maybe a fixup for the patch hiding communityDesc instead of removing would be enough for this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking