Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
T
Tor Browser
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,533
    • Issues 1,533
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • Operations
    • Operations
    • Incidents
  • Analytics
    • Analytics
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #34250

Closed
Open
Opened May 18, 2020 by Alex Catarineu@acatDeveloper

Fix torbutton noscript-control race condition

While debugging some testsuite tests, I saw some race condition with the noscript initialization which prevents some tests from running correctly.

We currently listen for both startup and pageshow events here, and in some tests, pageshow events are being received before startup, which results in the configuration message being lost and noscript being initialized with the default settings, blocking scripts.

This was originally introduced in legacy/trac#27427 (moved), which added checks for the event types precisely because of these issues. However, "pageshow" in specific situations also seems to trigger those.

In that ticket, "pageshow" was added for a slightly more graceful failure mode in case Torbutton somehow misses NoScript startup. However, I don't think that can really happen, and I suggest we just listen to startup.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: tpo/applications/tor-browser#34250