Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,285
    • Issues 1,285
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #40201
Closed
Open
Created Oct 20, 2020 by Alex Catarineu@acat

Check whether we need to switch any resource:// files to chrome://

Context: #40134 (comment 2711427).

In the 82 bug review I saw some tickets switching resources from resource:// to chrome:// URIs. According to https://phabricator.services.mozilla.com/D85023#2640166 the reason is https://bugzilla.mozilla.org/show_bug.cgi?id=1145314 (and the patch https://hg.mozilla.org/mozilla-central/rev/915aa6a1a0edaeb9d65bc87e7f2ef7c4693cabfc). This seems to be more restrictive about loading "UI resource URIs", so we should check whether we are affected. A quick look at our code shows only resource://onboarding/*, resource://torbutton-assets and resource://torbutton-abouttor as potentially affected by this. It's possible that the changes in torbutton#40012 (closed) were needed because of this.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking