Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,283
    • Issues 1,283
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor Browser
  • Issues
  • #40754

Closed
Open
Created Dec 21, 2021 by notaleg@notaleg

macOS Tor Browser drops code signature on update from 11.0.2

Summary

All components of the macOS version of Tor Browser will become unsigned (e.g. no Apple Notarized Developer ID) when upgrading from 11.0.2 to 11.0.3. This is bad security practice since other applications can now modify Tor Browser without triggering Gatekeeper alerts on launch.

This issue only occurs during such an upgrade. Regular installs to 11.0.3 are unaffected.

Steps to reproduce:

  1. Download and install 11.0.2 (TorBrowser-11.0.2-osx64_en-US.dmg)
  2. Verify its code signatures via spctl --assess --verbose=2 [path to package]
  • /Volumes/Tor Browser/Tor Browser.app: accepted
  • source=Notarized Developer ID
  1. Launch 11.0.2, connect to Tor, and install update to 11.0.3 via the built-in update prompt
  2. Once updated, verify code signatures via spctl --assess --verbose=2 [path to package]
  • /Applications/Tor Browser.app: rejected
  • source=no usable signature

What is the current bug behavior?

Upgrading will cause Tor Browser and all of its components (including bundled executables like tor.real) to lose notarized code signatures. This is not transparent to the user and will trigger no alerts without verifying manually using spctl or codesign for verification, or utilization of third-party software that can monitor such modifications.

What is the expected behavior?

Upgrading should replace old components with new signed components. This is the behaviour for directly installing 11.0.3.

Environment

macOS Catalina 10.15.7, Tor Browser installed from main mirror .dmg images (https://dist.torproject.org)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking