There are a couple of other candidates for the manual in addition to about:tor and bookmarks:
In the Application menu under Help.
"Tor Browser Help" within the About Tor Browser window is currently linking to support.mozilla.org in stable for some reason, but I think at some point it linked to the manual instead?
I think it would be good to point at the bundled manual from any internal link regardless of connection status for consistency (plus it also saves a little bandwidth).
@gus/@championquizzer: What do you think? Bookmarks could be the exception, possibly.
I've already done it in !308 (merged) . But I can revert it if needed.
"Tor Browser Help" within the About Tor Browser window is currently linking to support.mozilla.org in stable for some reason, but I think at some point it linked to the manual instead?
Nice catch! I thought we fixed it!
I'll change it to the manual, either the online or the offline version, as you prefer .
I think that the intention was removing it from the preferences, to avoid users disabling HTTPS-Only (unless they are really stubborn on wanting it, and do it from about:config).
Onion location popups have the same problem with about:... links, too.
So, since we are online when we show them, I think that just showing the online version is the easiest option, rather than start another fight with XUL.
That happens even with the nsIAboutModule::URI_SAFE_FOR_UNTRUSTED_CONTENT flag set!