"Japanese" language menu item is localised in multi-locale testbuild (on mac OS)

As far as I can tell, each locale is getting rendered in its native name except Japanese – which is localized instead, and accompanied by some strange extra info reading (Japan, macos):

changed milestone to %Tor Browser 12.0

added Backlog Localization Q4 UX labels

assigned to @pierov

marked this issue as related to #41369 (closed)

removed the relation with #41369 (closed)

marked this issue as related to #17400 (closed)

added Sponsor 131 label

changed milestone to %Sponsor 131 - Phase 4 - Browser Release Management

added MacOS label

I see 日本語 on Linux, and expect to see the same on Windows.

But we have already seen that Japanese is... special on MacOS (see #17122 (closed), for example, but I am sure we've already discussed this with @richard a few months ago, but cannot find the issue).

We should see if we can get rid of this special treatment once and for all (maybe we should open a second issue on tor-browser-build).

That's... strange, but good to know

I confirm that Windows is okay

Some info

https://searchfox.org/mozilla-central/rev/0a2eba79c24300ce0539f91c1bebac2e75264e58/intl/docs/locale.rst#463-469

https://searchfox.org/mozilla-central/rev/0a2eba79c24300ce0539f91c1bebac2e75264e58/intl/l10n/rust/l10nregistry-ffi/src/source.rs#27-33

https://searchfox.org/mozilla-central/rev/0a2eba79c24300ce0539f91c1bebac2e75264e58/intl/locale/mozILocaleService.idl#77-80

So, for language negotiation firefox uses "language tags", but for Intl uses "BCP47". The only locale where these differ is "ja-JP-macos" whose "language tag" is "ja-JP-mac".

Here, it may just be a case of using one form when the other is expected.

Note this distinction might get fixed in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1726586

Here, it may just be a case of using one form when the other is expected.

Very likely it is:

Note this distinction might get fixed in this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1726586

The problem is indeed upstream, but the issue seems to be much larger, difficult and complicated than ours, so I think Mozilla should solve it themselves.

However, we'll likely want a workaround in the meantime.

I think that I could change the patch I've added on !401 (merged). After all, I'd be a little bit confused by seeing ja-JP-macos.

So, what if we added a special patch to display 日本語 (ja) there?

Yeah, getLocaleDisplayNames seems be confused about what form it expects.

Here

https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/toolkit/components/mozintl/mozIntl.sys.mjs#983

it uses naviteLocaleNames which uses the "language tag" form

https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/toolkit/components/mozintl/mozIntl.sys.mjs#703

but here

https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/toolkit/components/mozintl/mozIntl.sys.mjs#988

it uses Intl, which expects the "BCP47" form.

Given this is on Services.intl, which is meant to be similar to Intl, my guess is that the "BCP47" form is what they expect. This also matches with some of the calling method's expectations as well (e.g. https://searchfox.org/mozilla-central/rev/a64647a2125cf3d334451051491fef6772e8eb57/browser/components/preferences/dialogs/browserLanguages.js#346-356)

So the entry in nativeLocaleNames should be changed from "ja-JP-mac" to "ja-JP-macos", or just added in addition.

I'll open a bug in bugzilla.

I'll open a bug in bugzilla.

Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1796161

added Next label and removed Backlog label

removed Next label

added Doing label

changed title from "Japanese" language menu item is localised in multi-locale testbuild to "Japanese" language menu item is localised in multi-locale testbuild (on mac OS)

removed Doing label

closed

marked this issue as related to tor-browser-build#40627 (closed)

@pierov the ja-JP-mac exception in your patch won't be needed anymore if this is fixed upstream in mozilla (either https://bugzilla.mozilla.org/show_bug.cgi?id=1796161 or https://bugzilla.mozilla.org/show_bug.cgi?id=1726586). Do we have a way to keep track of this?

Depending on the issue we either keep it open and add the next ESR label, or we open a new one.

In this case, I'd say we see if we already have one to track ja-JP-mac (it's a wider problem, after all), and add there.

If we don't have one, we should create one.

mentioned in issue #41402