Update connection assist's iconography

We designed new iconography for connection assist last year, but never handed it over for implementation.

I had planned on waiting until the next major revision of torconnect to ship the new icons (see #41621 (closed), and this WIP Figma file), however since the new torconnect icon will be making an appearance in the browser chrome (#41608 (closed)) and connection settings (#41618 (closed)) sooner than planned, we should ship these at the same time in Tor Browser 12.5 for consistency.

changed milestone to %Sponsor 96: Rapid Expansion of Access to the Uncensored Internet through Tor in China, Hong Kong, & Tibet

added Backlog Brand Desktop Feature UX Team Sponsor 96 Q1 UX labels

assigned to @donuts

added 12.5 stable label

removed Q1 label

added Q2 label

removed Backlog label

added Next label

Could you take this task off my hands please @nicob? We just need to handoff the new icons to dev along with a note about which icons they're supposed to replace.

To be clear: this ticket is about the icons only for Tor Browser 12.5. The rest of the template changes will get queued up separately for Tor Browser 13.0.

assigned to @nicob and unassigned @donuts

mentioned in issue tpo/ux/design#39 (closed)

icons here! cc @henry @richard

• connect.svg
• connect-broken.svg
• browser-location.svg
• globe-broken.svg

Thanks @nicob!

@richard on the torconnect screens these should be using the same grey fill color they currently use, please. This can wait until after the dev meeting too.

@dan an asset swap for you

@donuts: what is the globe-broken.svg asset meant to be used for? (@dan: in your MR you've swapped out onion-slash-fillabl.svg which doesn't seem quite right since it's a globe not an onion)

@richard The “no internet” error :)

@donuts The other thing is that the "onion.svg" is also used for the site identity button for ".onion" sites (instead of the padlock). Do we want to replace that with the "connect.svg" (which is what the current patch does), or keep the old "onion.svg" for those sites?

Nevermind, I just realised we have two different files both called "onion.svg". The site identity should be using the other one.

@dan maybe change the name to something other than "onion.svg" and "onion-slash-fillable.svg" so it is less confusing. Maybe "tor-connect.svg" and "tor-connect-broken.svg".

Sorry, I’m not following you. By onion.svg are you referring to the old onion-glyph?

If so, the new onion-site icons are called "onion-site.svg”, "onion-site-warning.svg” and "onion-site-broken.svg” here: #41749 (closed)

If so, the new onion-site icons are called "onion-site.svg”, "onion-site-warning.svg” and "onion-site-broken.svg”

Oh right, I didn't realise those also changed recently. But they landed named as "onion.svg", "onion-warning.svg" and "onion-slash.svg". So right now in the tor-browser repository we have two different files both called "onion.svg".

It would be nice if they had a different name.

Aha. If it helps, in Figma we say "onion-glyph" for the old onion icon (which has generic Tor-related uses and isn't limited to onion services), and "onion-site" for the new one (as mentioned, which is for onion sites specifically).

Opened also #41809 (closed) so that we don't lose it (and possibly fix it for 12.5a7).

removed Next label

added Backlog label

assigned to @richard and unassigned @nicob

assigned to @dan and unassigned @richard

marked this issue as related to tor-browser-build#40865 (closed)

mentioned in merge request !654 (merged)

removed Q2 label

assigned to @pierov and unassigned @dan

removed Backlog label

added Doing label

assigned to @dan and unassigned @pierov

mentioned in issue #41809 (closed)

marked this issue as related to #41809 (closed)

marked this issue as related to #41815 (closed)

The wrong icons were used and not the right size #41815 (closed)

mentioned in merge request !669 (merged)

closed

Resolved !669 (merged)

mentioned in merge request tor-browser-build!741 (merged)