Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 876
    • Issues 876
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

GitLab has been upgraded GitLab 16, please report any issues!

  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41654
Closed
Open
Issue created Feb 27, 2023 by Pier Angelo Vendrame@pierovMaintainer

UpdateInfo jumped into Data

Reported by a cypherpunk here: tor-browser-build#40724 (comment 2881419).

I think it's a regression from #20497 (closed). We need to decide whether we should move it back to its original position (TorBrowser/UpdateInfo), or keep the new position.

What's the logic for this directory? Should it be treated like data? In case, the new position could be better: if we use the logic to keep the data outside the browser directory, the update will be inside the actual data directory, instead of another directory at the same level of Browser and Data.

Or should the update data be in the same directory as the browser binaries? Any user applying the update should also be able to write to the Browser directory.

macOS is usually the most problematic platform, and has its own case already.

In any case, if we change the update directory, we might want to apply cleanup code for the previous files (but we need to be sure this doesn't break the updater, too).

Finally, we could keep the previous directory as a "don't fix it until it's broken".

Edited Feb 27, 2023 by Pier Angelo Vendrame
Assignee
Assign to
Time tracking