Fix handleProcessReady in TorSettings.init
handleProcessReady is called in TorSettings.init, but it's a callback created in observe.
The error comes from 2df6696d (my bad, sorry).
Other problems don't seem that bad (except maybe for the TorConnect.jsm one, for which we already have an issue)
Full linter report
/home/piero/Tor/tor-browser/browser/components/onionservices/content/authUtil.jsm
7:7 error 'Services' is assigned a value but never used. no-unused-vars (eslint)
/home/piero/Tor/tor-browser/browser/components/search/SearchSERPTelemetry.jsm
13:1 error 'RemoteSettings' is defined but never used. no-unused-vars (eslint)
30:7 error 'TELEMETRY_SETTINGS_KEY' is assigned a value but never used. no-unused-vars (eslint)
/home/piero/Tor/tor-browser/browser/components/uitour/UITourChild.jsm
9:7 error 'PREF_TEST_WHITELIST' is assigned a value but never used. no-unused-vars (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/OnboardingTelemetry.jsm
10:1 error 'XPCOMUtils' is not defined. no-undef (eslint)
13:1 error Use Services.uuid rather than defineLazyServiceGetter. mozilla/use-services (eslint)
13:1 error 'XPCOMUtils' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/content/Onboarding.jsm
273 error Parsing error: Private names are only allowed in property accesses (`obj.#if`) or in `in` expressions (`#if in obj`). (273:0) (eslint)
/home/piero/Tor/tor-browser/browser/modules/TorConnect.jsm
388:31 error Promise executor functions should not be async. no-async-promise-executor (eslint)
423:31 error Promise executor functions should not be async. no-async-promise-executor (eslint)
435:31 error Promise executor functions should not be async. no-async-promise-executor (eslint)
548:31 error Promise executor functions should not be async. no-async-promise-executor (eslint)
/home/piero/Tor/tor-browser/browser/modules/TorSettings.jsm
302:11 error 'handleProcessReady' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/toolkit/modules/QRCode.jsm
246:16 error 'i' is already defined. no-redeclare (eslint)
247:13 error 'mod' is already defined. no-redeclare (eslint)
266:16 error 'i' is already defined. no-redeclare (eslint)
267:13 error 'mod' is already defined. no-redeclare (eslint)
331:14 error 'i' is already defined. no-redeclare (eslint)
381:16 error 'i' is already defined. no-redeclare (eslint)
387:14 error 'i' is already defined. no-redeclare (eslint)
392:14 error 'i' is already defined. no-redeclare (eslint)
393:16 error 'r' is already defined. no-redeclare (eslint)
399:14 error 'i' is already defined. no-redeclare (eslint)
400:16 error 'r' is already defined. no-redeclare (eslint)
616:16 error 'row' is already defined. no-redeclare (eslint)
617:18 error 'col' is already defined. no-redeclare (eslint)
636:16 error 'row' is already defined. no-redeclare (eslint)
637:18 error 'col' is already defined. no-redeclare (eslint)
651:16 error 'col' is already defined. no-redeclare (eslint)
652:18 error 'row' is already defined. no-redeclare (eslint)
667:16 error 'col' is already defined. no-redeclare (eslint)
668:18 error 'row' is already defined. no-redeclare (eslint)
702:12 error 'i' is already defined. no-redeclare (eslint)
709:12 error 'i' is already defined. no-redeclare (eslint)
752:16 error 'i' is already defined. no-redeclare (eslint)
/home/piero/Tor/tor-browser/toolkit/mozapps/update/UpdateService.jsm
2128:1 error Function 'Update' has a complexity of 46. Maximum allowed is 45. complexity (eslint)
/home/piero/Tor/tor-browser/browser/base/content/browser.js
4875:3 error Expected to return a value at the end of method 'updateShareURLMenuItem'. consistent-return (eslint)
4886:7 error Method 'updateShareURLMenuItem' expected a return value. consistent-return (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/api.js
49 error Parsing error: Private names are only allowed in property accesses (`obj.#if`) or in `in` expressions (`#if in obj`). (49:0) (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/content/onboarding-tour-agent.js
30 error Parsing error: Private names are only allowed in property accesses (`obj.#if`) or in `in` expressions (`#if in obj`). (30:0) (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/test/browser/head.js
4:23 error ChromeUtils.import only takes one argument. mozilla/reject-chromeutils-import-params (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/test/unit/head.js
12:1 error 'XPCOMUtils' is not defined. no-undef (eslint)
22:20 error 'Services' is not defined. no-undef (eslint)
32:14 error 'Services' is not defined. no-undef (eslint)
34:17 error 'Services' is not defined. no-undef (eslint)
38:40 error 'Services' is not defined. no-undef (eslint)
48:3 error 'Services' is not defined. no-undef (eslint)
49:3 error 'Services' is not defined. no-undef (eslint)
50:3 error 'Services' is not defined. no-undef (eslint)
55:3 error 'Services' is not defined. no-undef (eslint)
56:3 error 'Services' is not defined. no-undef (eslint)
57:3 error 'Services' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/browser/extensions/onboarding/test/unit/test-onboarding-tour-type.js
12:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
15:5 error 'Preferences' is not defined. no-undef (eslint)
20:5 error 'Preferences' is not defined. no-undef (eslint)
25:5 error 'Preferences' is not defined. no-undef (eslint)
34:3 error 'Preferences' is not defined. no-undef (eslint)
35:3 error 'Preferences' is not defined. no-undef (eslint)
36:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
39:5 error 'Preferences' is not defined. no-undef (eslint)
44:5 error 'Preferences' is not defined. no-undef (eslint)
49:5 error 'Preferences' is not defined. no-undef (eslint)
60:3 error 'Preferences' is not defined. no-undef (eslint)
61:3 error 'Preferences' is not defined. no-undef (eslint)
62:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
65:5 error 'Preferences' is not defined. no-undef (eslint)
70:5 error 'Preferences' is not defined. no-undef (eslint)
75:5 error 'Preferences' is not defined. no-undef (eslint)
86:3 error 'Preferences' is not defined. no-undef (eslint)
87:3 error 'Preferences' is not defined. no-undef (eslint)
88:3 error 'Preferences' is not defined. no-undef (eslint)
89:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
92:5 error 'Preferences' is not defined. no-undef (eslint)
97:5 error 'Preferences' is not defined. no-undef (eslint)
102:5 error 'Preferences' is not defined. no-undef (eslint)
113:3 error 'Preferences' is not defined. no-undef (eslint)
114:3 error 'Preferences' is not defined. no-undef (eslint)
115:3 error 'Preferences' is not defined. no-undef (eslint)
116:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
119:5 error 'Preferences' is not defined. no-undef (eslint)
124:5 error 'Preferences' is not defined. no-undef (eslint)
129:5 error 'Preferences' is not defined. no-undef (eslint)
138:3 error 'OnboardingTourType' is not defined. no-undef (eslint)
141:5 error 'Preferences' is not defined. no-undef (eslint)
146:5 error 'Preferences' is not defined. no-undef (eslint)
151:5 error 'Preferences' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/tbb-tests/browser_tor_TB4.js
19:16 error 'Services' is not defined. no-undef (eslint)
20:18 error 'Services' is not defined. no-undef (eslint)
21:14 error 'Services' is not defined. no-undef (eslint)
23:18 error 'Services' is not defined. no-undef (eslint)
24:14 error 'Services' is not defined. no-undef (eslint)
26:18 error 'Services' is not defined. no-undef (eslint)
27:14 error 'Services' is not defined. no-undef (eslint)
35:5 error 'is' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/tbb-tests/browser_tor_bug2950.js
8:3 error 'waitForExplicitFinish' is not defined. no-undef (eslint)
11:7 error Ci is now defined in global scope, a separate definition is no longer necessary. mozilla/no-define-cc-etc (eslint)
19:5 error 'Services' is not defined. no-undef (eslint)
24:5 error 'SitePermissions' is not defined. no-undef (eslint)
30:5 error 'SitePermissions' is not defined. no-undef (eslint)
34:24 error 'Services' is not defined. no-undef (eslint)
39:5 error 'FileUtils' is not defined. no-undef (eslint)
59:30 error 'SitePermissions' is not defined. no-undef (eslint)
64:5 error 'Assert' is not defined. no-undef (eslint)
75:5 error 'is' is not defined. no-undef (eslint)
81:5 error 'finish' is not defined. no-undef (eslint)
/home/piero/Tor/tor-browser/tbb-tests/browser_tor_omnibox.js
4:1 error 'add_task' is not defined. no-undef (eslint)
6:30 error Use Services.search rather than getService(). mozilla/use-services (eslint)
14:3 error 'is' is not defined. no-undef (eslint)
15:3 error 'is' is not defined. no-undef (eslint)
16:3 error 'is' is not defined. no-undef (eslint)
17:3 error 'is' is not defined. no-undef (eslint)
18:3 error 'is' is not defined. no-undef (eslint)
19:3 error 'is' is not defined. no-undef (eslint)
20:3 error 'is' is not defined. no-undef (eslint)
21:3 error 'is' is not defined. no-undef (eslint)
22:3 error 'is' is not defined. no-undef (eslint)