Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Tor Browser Tor Browser
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 925
    • Issues 925
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • Tor BrowserTor Browser
  • Issues
  • #41924

Small refactors for TorProcess

We could do some small refactors on the TorProcess class:

  • use actual ES private stuff (#)
  • we could move the password hashing in it, since it's used only to start a process
  • we have many calls to this._args.push in two lines: one for the key and one for the value. We could group together, to make them more readable and quicker to understand
  • _torProcessStartTime isn't used (it was intended to be used by TorMonitorService, but it got lost during the rafactor of September)
  • we could export the exit code of the process when it exits
  • onExit and onRestart don't need to be null: they can be empty callbacks, instead
  • we could remove the dependency on TorProtocolService, and take the options in the constructor, instead
Edited Jul 27, 2023 by Pier Angelo Vendrame
Assignee
Assign to
Time tracking