Rename languageNotification.ftl to base-browser.ftl

We want to have two main files for our tor browser strings: base-browser.ftl and tor-browser.ftl.

The current languageNotification.ftl file is only used in base-browser, so we can just rename the file, rather than migrate the strings.

CC @pierov and @emmapeel

assigned to @henry

added Doing Localization labels

mentioned in merge request !720 (merged)

@emmapeel while updating this fluent file, could we also delete the newIdentity.ftl?

IIRC, it's disabled in all the languages, and it's translated only in a few languages, because it was the first experiment.

In any case, the strings for new identity will also be added to base-browser.ftl when we migrate them to Fluent.

Also, at that point I don't know if you'd prefer to use only a single repository for base-browser, and then forget about basebrowser-newidentityftl.

i have moved languageNotification.ftl to base-browser.ftl in the base-browser branch. please review the MR in case i didnt understood: tpo/translation!29 (merged)

@emmapeel this has been merged, so could you please proceed with renaming the file on Weblate? Thank you!

Currently we have a branch for languageNotification.ftl and new-identity.ftl: the branch basebrowser-newidentityftl

I can add languageNotification.ftl to the branch 'base-browser' and rename it to base-browser.ftl.

(I need to create a new component if I want to change the source file)

So, can I remove the component https://hosted.weblate.org/projects/tor/tb-languagenotification/ from weblate? it seems newIdentity.ftl is not a weblate component.

tpo/translation!29 (merged) is good also to me.

So, can I remove the component https://hosted.weblate.org/projects/tor/tb-languagenotification/ from weblate?

Yes, please

it seems newIdentity.ftl is not a weblate component.

We used it to try Weblate's Fluent support, back when it didn't support attributes, so we immediately removed it, but then kept the old name for the other Fluent file.

I don't remember if the reason was that you weren't sure it would have worked as expected, or that the other branch was still on Transifex.

@emmapeel I've just realized that we still need the old Fluent file for the 12.5 series.

However, we're releasing only another 12.5.x version in a couple of weeks if everything goes well.

So, as long as we still have the old languageNotification.ftl in the old branch for it we should be good, even though it stops receiving translations in these two weeks, I hope.

Yes, it is still on the repository and i didnt delete the weblate component yet, so let me know when we can do it more safely

If we're sure we don't remove old strings from the new file, we could also rename it during the build without backporting !720 (merged).

But, keeping the old component for another couple of months would be the safest and easiest path, if it isn't a big deal for you.

We promise we won't add strings to the old one, only to the new one .

I have no problem on leaving it on the repo, but I'd like to remove translations that are not going to be used so translators dont waste their time.

mentioned in merge request tpo/translation!29 (merged)

marked this issue as related to tor-browser-build#40922 (closed)

mentioned in issue tor-browser-build#40922 (closed)

OK, base-browser.ftl in weblate: https://hosted.weblate.org/projects/tor/tb-base-browser/

mentioned in merge request tor-browser-build!784 (merged)

closed

marked this issue as related to tor-browser-build#40915 (closed)

marked this issue as related to tor-browser-build#40914 (closed)

added All Platforms label

marked this issue as related to tor-browser-build#40965 (closed)

marked this issue as related to tor-browser-build#40966 (closed)