When startup window is maximized per letterboxing.rememberSize on startup, the restore button shrinks it to its minimum size

STR

• chose reuse last window size ...
• go maximzed
• close browser
• re-open browser (it opens maximized)
• click restore

expected

• restore should use newwin

what I ended up with

cc: @ma1

changed the description

moved from mullvad-browser#281 (moved)

added Desktop Screensize labels

changed title from when remember maximzed, restore is fubared to when remember maximized, restore is fubared

added 13.5 stable Bug labels

assigned to @ma1

added Next label

I cannot reproduce.

Tried both Mullvad 13.5a6 on a Windows 11 VM and latest TB dev build at 08ed48fa following the STR above.

Just to double check:

1. By Restore you mean the button under the cursor in this screenshot,
2. Reuse last window size is the only non-default preference.

1. yes
2. umm, i do have bookmarks toolbar always show on my setups but that shouldn't make a difference (edit: tested with it set to only show on new tabs, doesn't make a difference)
3. both nightly and alpha exhibit this behavior (OP was about nightly)

edit: and as expected happens in TB as well

1. Could you please capture a screen recording of what happens?
2. Is there anything special about your profile (e.g. a sandbox or some data scrubber)?
3. Does it happen with a completely fresh install / clean profile?

Thank you very much for the recording.

I'm still unable to reproduce on Linux, on MacOS (where rather than "maximize" we've got a hybrid "fullscreen") and on a Windows VM, but I finally (and consistently) could on my wife's Windows 11 notebook.

Therefore I've kidnapped said notebook to try understand what at this moment seems a Windows-only (and maybe timing-related, re: VM non-reproducibility) bug.

@thorin, quick double check: can you still reproduce with a non-default theme (e.g. Alpenglow)? Hopefully you cannot :)

wow, the problem didn't happen with alpenglow - that's just whack

that's just whack

It is, but I definitely know what's happening now and I'm gonna fix it today (thanks to wife's notebook)

added Windows label

changed title from when remember maximized, restore is fubared to When startup window is maximized per letterboxing.rememberSize on startup, the restore button shrinks it to its minimum size

removed Next label

added Doing label

mentioned in merge request !994 (merged)

added Uplift label

marked this issue as related to tor-browser-build#41113 (closed)

marked this issue as related to tor-browser-build#41114 (closed)

closed

removed Doing label