Remove 'Enable beta connection features' menu item in stable release channel

added 13.5 stable label

assigned to @clairehurst

added Android Task labels

Users on the legacy stack should be appropriately migrated to the new stack with native frontend. Alpha+Nightly users should still be able to switch between the HTML and Native frontends.

marked this issue as related to #42568 (closed)

marked this issue as related to tor-browser-build#41125 (closed)

added Doing label

I don't think that the toggle was ever put into stable

Right, but come 13.5 this code will be stable, and 14.0 will be alpha. So we will want the bootstrapping frontend options in alpha (14.0), but not stable (13.5).

...

On May 9, 2024 12:13:39 AM UTC, "clairehurst (@clairehurst)" git@gitlab.torproject.org wrote:

clairehurst commented: #42566 (comment 3028391)

I don't think that the toggle was ever put into stable

-- Reply to this email directly or view it on GitLab: #42566 (comment 3028391) You're receiving this email because of your account on gitlab.torproject.org.

With the removal of the beta connection assist toggle (except for when building in debug firefox-android!95 (diffs)) is this issue taken care of? Is that what you had in mind?

@clairehurst nearly, it looks like we should be able to check BuildConfig.MOZ_UPDATE_CHANNEL which (for us) will be:

• "release" (stable; currently 13.0.x series)
• "beta" (alpha; currently 13.5ax series)
• "nightly" (nightly)

I think checking BuildConfig.MOZ_UPDATE_CHANNEL != "release" should work. I'm not sure how this is populated in local/dev builds but here's the relevant part of the tor-browser-build build script: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/blob/main/projects/firefox-android/build?ref_type=heads#L112

var/variant is populated with value that goes to MOZ_UPDATE_CHANNEL

firefox-android!101 (merged) should satisfy this

mentioned in merge request firefox-android!101 (merged)

closed