Several console errors: Console.maxLogLevelPref used with a non-existing pref:

Browser console:

Console.maxLogLevelPref used with a non-existing pref: browser.onionAuthPrompt.loglevel

added Bug label

added 13.5 stable 14.0 stable labels

added Backport Roadmap::Future labels

added Desktop label

changed title from 13.5a8 after update to Console Error: Console.maxLogLevelPref used with a non-existing pref: browser.onionAuthPrompt.loglevel

New in 13.5a8

marked this issue as related to #42753 (closed)

mentioned in issue #42753 (closed)

There are many errors of this kind in current nightlies, after we've switched to console.createInstance.

Luckily, they aren't exceptions, just console errors.

Maybe we could try to prioritize for 14.0a2.

assigned to @pierov

changed title from Console Error: Console.maxLogLevelPref used with a non-existing pref: browser.onionAuthPrompt.loglevel to Several console errors: Console.maxLogLevelPref used with a non-existing pref:

changed the description

removed Roadmap::Future label

added Next label

removed Next label

added Doing label

In 14.0a1, at the startup we have:

• torbrowser.bootstrap.log_level
• browser.tordomainisolator.loglevel (well, maybe browser. is also wrong for this, since it's toolkit now)
• browser.tor_provider.log_level
• browser.torsettings.log_level
• browser.tor_provider.cp_log_level
• browser.new_identity.log_level
• browser.torcircuitpanel.loglevel

But not one for browser.onionAuthPrompt.loglevel , even though we likely use it. While trying onion auth I found:

• browser.onionalias.log_level
• browser.torRequestWatch.log_level

So, I decided to search for all the console.createInstance entries we have in our patchset (git diff FIREFOX_128_1_0esr_BUILD1..):

• browser/components/newidentity/content/newidentity.js (browser.new_identity.log_level)
• browser/components/onionservices/OnionAliasStore.sys.mjs (browser.onionalias.log_level)
• browser/components/onionservices/TorRequestWatch.sys.mjs (browser.torRequestWatch.log_level)
• browser/components/onionservices/content/authPrompt.js (browser.onionAuthPrompt.loglevel)
• browser/components/torcircuit/content/torCircuitPanel.js (browser.torcircuitpanel.loglevel)
• browser/components/torpreferences/content/connectionPane.js - no preference, should we add one?
• browser/components/torpreferences/content/requestBridgeDialog.js - no preference
• toolkit/actors/FilesFilterChild.sys.mjs - no preference
• toolkit/components/lox/Lox.sys.mjs (lox.log_level)
• toolkit/components/resistfingerprinting/RFPHelper.sys.mjs (privacy.resistFingerprinting.jsmloglevel - not a new one, so upstream should already have added it)
• toolkit/components/securitylevel/SecurityLevel.sys.mjs - no preference, should we add one?
• toolkit/components/tor-launcher/TorBootstrapRequest.sys.mjs - no preference and I don't think we need one, as this class should go away
• toolkit/components/tor-launcher/TorControlPort.sys.mjs (browser.tor_provider.cp_log_level)
• toolkit/components/tor-launcher/TorDomainIsolator.sys.mjs (browser.tordomainisolator.loglevel)
• toolkit/components/tor-launcher/TorProcess.sys.mjs - no preference
• toolkit/components/tor-launcher/TorProcessAndroid.sys.mjs - no preference
• toolkit/components/tor-launcher/TorProvider.sys.mjs (browser.tor_provider.log_level)
• toolkit/components/torconnect/TorConnectParent.sys.mjs - no preference
• toolkit/modules/DomainFrontedRequests.sys.mjs - no preference, and actually the consumer could pass its logger
• toolkit/modules/DragDropFilter.sys.mjs (browser.dragdropfilter.log_level, remove new)
• toolkit/modules/Moat.sys.mjs - no preference
• toolkit/modules/TorAndroidIntegration.sys.mjs (browser.tor_android.log_level)
• toolkit/modules/TorConnect.sys.mjs (torbrowser.bootstrap.log_level)
• toolkit/modules/TorSettings.sys.mjs (browser.torsettings.log_level)

Bonus (DragDropFilter.sys.mjs:17, it has a new):

console.createInstance is not a constructor

Sorted by commit:

• add a comment for log levels in 001
• fb5ea631 Bug 40926: Implemented the New Identity feature browser.new_identity.log_level
• add a comment for log levels in 000
• 77d7fdde Bug 40933: Add tor-launcher functionality browser.tor_provider.log_level, browser.tor_provider.cp_log_level
• d5514e73 Lox integration lox.log_level
• ab9dfad8 Bug 40597: Implement TorSettings module torbrowser.bootstrap.log_level, browser.torsettings.log_level
• ff2de341 Bug 3455: Add DomainIsolator, for isolating circuit by domain. browser.tordomainisolator.loglevel
• d8363a2e Bug 41600: Add a tor circuit display panel. browser.torcircuitpanel.loglevel
• 7a327708 Bug 42247: Android helpers for the TorProvider browser.tor_android.log_level
• 7020bb26 Bug 8324: Prevent DNS proxy bypasses caused by Drag&Drop browser.dragdropfilter.log_level
• 6e6d7c7b Bug 30237: Add v3 onion services client authentication prompt browser.onionAuthPrompt.loglevel
• bd26bd87 Bug 40458: Implement .tor.onion aliases browser.onionalias.log_level, browser.torRequestWatch.log_level

But not one for browser.onionAuthPrompt.loglevel

This is already fixed in 14.0a1! I wonder if I did it when rebasing .

marked this issue as related to tor-browser-build#41186 (closed)

marked this issue as related to tor-browser-build#41187 (closed)