2 buttons displayed onion-available and connect when Tor daemon killed

Go to a site where onion location is shown, then kill the tor daemon (for end user, they will encounter it when they lose connection to Tor due to network error).

/cc @henry

It is not clear what the reporter thinks the issue is. Is it that two buttons are showing, or that they are touching?

In any case, I think UX (@donuts or @felicia) needs to decide on this:

• Do we want to show both buttons? It isn't necessarily an error that both show, since both operations are actionable in this state. Clicking "Connect" will re-open about:torconnect in a new tab to establish a connection for the new tor process. Clicking ".onion available" would request the onion site, which would have to pass through about:torconnect loaded in the same tab. If I had to drop one, I would drop the latter since requesting the onion site will necessarily require a re-connection anyway, and once that operation is complete you can then select the single ".onion available" button.
• If we want both buttons, what should the ordering be?
• If we want both buttons, what should the spacing be? NOTE that usually buttons within the urlbar have no horizontal spacing.

or that they are touching?

That they are touching, they originally wrote the problem on IRC.

I agree that I'd expect some space, like between zoom and the bookmarks star, or our buttons and the star itself.

IIRC, sometimes the connect button is visible also when you don't properly setup the browser to use an external tor daemon.

Clicking "Connect" will re-open about:torconnect in a new tab to establish a connection for the new tor process.

@henry so does that means that the Connect button would work as a way to restart Tor? If that's the case, I think we should keep just this button, but changing its label to "Restart Tor". If Tor daemon was killed, then it doesn't make sense to offer an .onion site option before connecting again. Even though it would include a bootstrap in between, the wording doesn't give a hint of solution.

does that means that the Connect button would work as a way to restart Tor?

@felicia it depends on whether #43186 (moved) is implemented.

Currently, the user will have already seen the "Tor Launcher" dialog, which is where they can restart the tor process. So "Connect" would only perform a bootstrap, so still makes sense.

After #43186 (moved) is implemented, I imagine we would have already opened about:torconnect in a new tab. So pressing the "Connect" button would switch to the about:torconnect page. I'm not sure whether we would want this button to just open the page, or also perform some additional actions. But lets leave that to the discussion in #43186 (moved). Similarly regarding changing the wording to "Restart Tor".

think we should keep just this button

ok. I think that makes sense to me.

added 7m of time spent

added 14.5 stable Desktop labels

assigned to @henry

mentioned in issue #43186 (moved)

added Doing label

mentioned in merge request !1369 (merged)

marked this issue as related to tor-browser-build#41347 (closed)

closed