Remove incorrectly shown "open in app" notification dot on settings button

🐞 Bug Report

With the new UI changes introduced since 140, even though we removed the "Open in app" button and notification within the "main menu" in #44581 (closed), the notification dot still shows on the settings button on the navigation bar when visiting sites that have a corresponding app installed (like youtube or wikipedia)

image.png

User impact

Although this has misleading UI, it does not appear to be a security issue (like removing the underlying "open in app" was)

Bookkeeping

  • Browser version:
  • Browser channel:
    • Release
    • Alpha
    • Nightly
  • Distribution method:
    • Installer/archive from torproject.org
    • tor-browser-launcher
    • homebrew
    • other (please specify):
  • Operating System:
    • Windows
      • Version:
    • macOS
      • Version:
    • Linux
      • Distribution + Version:
      • Desktop Environment + Version:
    • Android
      • Version:
      • Device:
    • Tails
    • Other (please specify):

Edited by clairehurst