Adjust preferences for contrast theme or forced colors

henryrequested to merge
henry/tor-browser:high-contrast-tweaks-tb43130 into tor-browser-128.8.0esr-14.5-1

Merge Info

Issues

Resolves

Related

Merging

Target Branches

  • tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

  • Alpha: esr128-14.5
  • Stable: esr128-14.0
  • Legacy: esr115-13.5

Backporting

Timeline

  • No Backport (preferred): patchset for the next major stable
  • Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

  • Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain

Upstream

  • Patchset is a candidate for uplift to Firefox
  • Patchset is a backport from Firefox
    • Bugzilla link:
    • Upstream commit:

Issue Tracking

Review

Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, morgan
    • localization : henry, pierov
    • macOS : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, morgan
    • security : jwilde, ma1
    • signing : boklm, morgan
    • updater : pierov
    • windows : jwilde, morgan
    • misc/other : pierov, morgan

Change Description

Give the "Your bridges" and "request bridges" boxes an outline for forced-colors since the background color will not show.

Use --border-radius-* instead of fixed px values.

Do not use the accent color for text when in contrast theme or forced colors.

How Tested

Reviewed styling under high contrast system theme (linux), and with forced colors (via "General > Language and Appearance > Colors > Manage Colors" preference dialog).

Edited by henry

Merge request reports

tools/torbrowser/l10n/migrations/bug-43531-bridge-dialog-buttons.py

0 → 100644
+27 −0
Changes for tools/torbrowser/l10n/migrations/bug-43531-bridge-dialog-buttons.py: 27 added lines, 0 removed lines.
Original line number Diff line number Diff line 
from fluent.migrate.helpers import transforms_from





def migrate(ctx):

    # Convert

    #

    # my-button = MY TEXT

    #

    # to

    #

    # my-button2 =

    #   .label = MY TEXT

    ctx.add_transforms(

        "tor-browser.ftl",

        "tor-browser.ftl",

        transforms_from(

            """

bridge-dialog-button-connect2 =

    .label = { COPY_PATTERN(path, "bridge-dialog-button-connect") }

bridge-dialog-button-accept2 =

    .label = { COPY_PATTERN(path, "bridge-dialog-button-accept") }

bridge-dialog-button-submit2 =

    .label = { COPY_PATTERN(path, "bridge-dialog-button-submit") }

""",

            path="tor-browser.ftl",

        ),

    )