tor-launcher issueshttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues2022-03-18T18:30:27Zhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/40005Launcher doesn't adapt to OS dark theme2022-03-18T18:30:27ZMateus MercerLauncher doesn't adapt to OS dark theme# My system
```
OS: Arch Linux x86_64
DE: Xfce 4.16
Theme: Adwaita-dark [GTK2/3]
```
Notice the `dark` suffix.
# Screenshots with example problems:
## Logo has low contrast
![Fig 1](/uploads/a0983e309c205fad6b0ae0fbae5eaa0b/Screens...# My system
```
OS: Arch Linux x86_64
DE: Xfce 4.16
Theme: Adwaita-dark [GTK2/3]
```
Notice the `dark` suffix.
# Screenshots with example problems:
## Logo has low contrast
![Fig 1](/uploads/a0983e309c205fad6b0ae0fbae5eaa0b/Screenshot_2021-02-05_13-41-46.png)
Fig 1. The logo have very low contrast since it expects that the background is white.
## Icons have low contrast
![Fig 2.](/uploads/d6ef5e0ba4e14f071bc852d176a192ff/Screenshot_2021-02-05_13-43-01.png)
Fig 2. Icons that should be white are black.
## Bridge notice
![Fig 3](/uploads/b1b85b1d47776303869b6910a9205c7f/Screenshot_2021-02-05_13-44-10.png)
Fig 3. Some settings can't be read since the background is white and the text too.
## Captcha window
![Fig 4](/uploads/b62e41fcdeed55b4fe7f93c6c1b678fb/Screenshot_2021-02-05_13-45-27.png)
Fig 4. The captcha window has almost unreadable text and an image that doesn't fit the dark theme.
# Possible fixes
## Detect the OS dark mode
You can detect the dark mode of the OS in Javascript with this snippet:
```js
let darkMode = window.matchMedia('(prefers-color-scheme: dark)').matches
```
You can watch for changes with a event listener too:
```js
window.matchMedia('(prefers-color-scheme: dark)')
.addEventListener('change', event => {
if (event.matches) {
//dark mode
} else {
//light mode
}
})
```
[Source](https://flaviocopes.com/javascript-detect-dark-mode/)
Then, we can set a variable to dynamically change the CSS, eg:
js
```js
wizardElem.setAttribute("tor_dark_mode", darkModeMatch.matches);
```
css
```css
wizard[tor_dark_mode="true"] .tbb-logo {
list-style-image: url("chrome://torlauncher/skin/tbb-logo-dark.svg");
}
```https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/40002After rebasing to 80.0b2 moat is broken2020-08-24T12:59:31ZGeorg KoppenAfter rebasing to 80.0b2 moat is brokenWhile testing the rebased work in tor-browser#40023 on desktop I encountered
```
08-17 15:10:06] TorLauncher INFO: The meek client process has been started
[08-17 15:10:06] TorLauncher DBUG: meek client stdout: VERSION 1
CMETHOD meek_li...While testing the rebased work in tor-browser#40023 on desktop I encountered
```
08-17 15:10:06] TorLauncher INFO: The meek client process has been started
[08-17 15:10:06] TorLauncher DBUG: meek client stdout: VERSION 1
CMETHOD meek_lite socks5 127.0.0.1:43279
CMETHODS DONE
[08-17 15:10:06] TorLauncher DBUG: meek client proxy type: socks
[08-17 15:10:06] TorLauncher DBUG: meek client proxy IP: 127.0.0.1
[08-17 15:10:06] TorLauncher DBUG: meek client proxy port: 43279
[08-17 15:10:06] TorLauncher VERB: Moat JSON request:
{"data":[{"version":"0.1.0","type":"client-transports","supported":["obfs4"]}]}
JavaScript error: resource://torlauncher/modules/tl-bridgedb.jsm, line
590: NS_ERROR_FAILURE: Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [nsIChannel.asyncOpen]
```
when trying to use `moat`.
Might be a rebase issue or just the normal need for Tor Launcher
adjustment, I am not sure.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/30473update Tor Browser proposal 102 to account for Tails team feedback2022-03-17T05:47:34ZMark Smithupdate Tor Browser proposal 102 to account for Tails team feedbackWe need to update proposal 102 "Integration of Tor Launcher into Tor Browser Core" to account for feedback we received from the Tails team (intrigeri). See the discussion here:
https://lists.torproject.org/pipermail/tbb-dev/2019-February...We need to update proposal 102 "Integration of Tor Launcher into Tor Browser Core" to account for feedback we received from the Tails team (intrigeri). See the discussion here:
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000962.html
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000963.html
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000964.htmlhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/21542use Subprocess.jsm to launch tor2022-03-16T21:41:58ZMark Smithuse Subprocess.jsm to launch torIn Firefox 49, Mozilla added a new Subprocess.jsm module (they use it to implement the WebExtensions Native Messaging API). Kathy and I have not looked at it closely yet, but this module may provide a better way for Tor Launcher to start...In Firefox 49, Mozilla added a new Subprocess.jsm module (they use it to implement the WebExtensions Native Messaging API). Kathy and I have not looked at it closely yet, but this module may provide a better way for Tor Launcher to start and manage the tor process. In particular, Subprocess.jsm provides access to stderr which would allow Tor Launcher to capture all output produced by tor.
Docs:
https://firefox-source-docs.mozilla.org/toolkit/modules/subprocess/toolkit_modules/subprocess/index.htmlhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/9675Provide feedback mechanism for clock-skew and other bad problems2022-03-30T15:51:10ZLunarProvide feedback mechanism for clock-skew and other bad problemsTBB 3.0 currently has a button to copy Tor logs to the clipboard. It's good enough to enable support by knowledgeable people, but it is also good to enable at least a minimal level of self-support.
One misconfiguration that can prevent ...TBB 3.0 currently has a button to copy Tor logs to the clipboard. It's good enough to enable support by knowledgeable people, but it is also good to enable at least a minimal level of self-support.
One misconfiguration that can prevent Tor from working is clock-skew. Vidalia made a bright red message out of it. Having some feedback mechanism in TBB 3.0 for similar critical issues would be good.