tor-launcher issueshttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues2020-06-27T13:42:10Zhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/34206Tor Launcher button labels are missing (Firefox 76)2020-06-27T13:42:10ZMark SmithTor Launcher button labels are missing (Firefox 76)When running inside a Tor Browser that is based on Firefox 76 or newer, some button labels are missing from Tor Launcher's setup wizard. To fix this, we need to apply the same workaround as Mozilla applied in https://bugzilla.mozilla.org...When running inside a Tor Browser that is based on Firefox 76 or newer, some button labels are missing from Tor Launcher's setup wizard. To fix this, we need to apply the same workaround as Mozilla applied in https://bugzilla.mozilla.org/show_bug.cgi?id=1625938https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/34164Tor Launcher hangs with 33533+5 branch2021-01-03T17:39:27ZAlex CatarineuTor Launcher hangs with 33533+5 branchmcs/brade pointed to me that there seems to be a Tor Launcher deadlock inside a call to writeBytes() for the control port connection, with the latest `33533+5` branch from legacy/trac#33533.
They tested a debug build in macOS, but it al...mcs/brade pointed to me that there seems to be a Tor Launcher deadlock inside a call to writeBytes() for the control port connection, with the latest `33533+5` branch from legacy/trac#33533.
They tested a debug build in macOS, but it also happens to me with a `testbuild-linux-x86_64` build.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/33906Fix Tor-Launcher issues for Firefox 752020-06-27T13:42:10ZAlex CatarineuFix Tor-Launcher issues for Firefox 75Apart from legacy/trac#32174, legacy/trac#33862 and legacy/trac#33890, there seems to be some issues that need to be addressed.
By testing, I found that the "Back" button in the wizard does not have a label and the window used for displ...Apart from legacy/trac#32174, legacy/trac#33862 and legacy/trac#33890, there seems to be some issues that need to be addressed.
By testing, I found that the "Back" button in the wizard does not have a label and the window used for displaying the bridge captcha and errors is not shown.
By looking at the code and console errors I also found that `getAnonymousElementByAttribute` is used, but this was removed in https://bugzilla.mozilla.org/show_bug.cgi?id=1591145. Besides, it seems now the `<wizard>` should not be the root element anymore: https://bugzilla.mozilla.org/show_bug.cgi?id=1584283. The same with `<dialog>` https://bugzilla.mozilla.org/show_bug.cgi?id=1585482.
I did not look in-depth, but these are some issues I found testing a bit after fixing (in principle) legacy/trac#32174, legacy/trac#33862 and legacy/trac#33890.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/32654Torbrowser overides user disabling tor proxy after restart2022-03-16T20:48:17ZTracTorbrowser overides user disabling tor proxy after restartextensions.torlauncher.start_tor false, network.proxy.type 0, and network.proxy.socks_remote_dns false allow a user to disable the tor proxy and still use the security and privacy benefits of the tor browser.
However, after restarting th...extensions.torlauncher.start_tor false, network.proxy.type 0, and network.proxy.socks_remote_dns false allow a user to disable the tor proxy and still use the security and privacy benefits of the tor browser.
However, after restarting the browser, network.proxy.type resets to 1 and network.proxy.socks_remote_dns resets to true.
Tor Browser version: 9.0.1
**Trac**:
**Username**: woyazihttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/32174replace XUL <textbox> with <html:input>2020-07-14T22:23:14ZMark Smithreplace XUL <textbox> with <html:input>Mozilla has removed XUL <textbox>, although only partially in the ESR68 timeframe (see legacy/trac#32154 where we had to replace a multiline usage with <html:textarea>). We need to finish the job and replace our remaining uses of <textbo...Mozilla has removed XUL <textbox>, although only partially in the ESR68 timeframe (see legacy/trac#32154 where we had to replace a multiline usage with <html:textarea>). We need to finish the job and replace our remaining uses of <textbox> with <html:input>.
While we are at it, we should double check that we do not use <textbox> outside of Tor Launcher, either in the Torbutton code or in a Firefox patch.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/32154Tor Launcher's custom bridge field only allows one line of input2020-06-27T13:42:11ZMark SmithTor Launcher's custom bridge field only allows one line of inputIn the ESR68-based Tor Browser, Tor Launcher's custom bridge input field only allows one line of input. Some detective work reveals that Mozilla was in the process of removing XUL `textbox` during the ESR68 cycle and now it has been comp...In the ESR68-based Tor Browser, Tor Launcher's custom bridge input field only allows one line of input. Some detective work reveals that Mozilla was in the process of removing XUL `textbox` during the ESR68 cycle and now it has been completely removed (for Firefox 71):
https://bugzilla.mozilla.org/show_bug.cgi?id=1513325
They have switched everything to use `html:input` and `html:textarea` and we will need to do the same, eventually. Prior to ESR68, they removed support for multiline `textbox` elements, which is the cause of the custom bridge field breakage.
We are working on a fix, although I guess it is too late for Tor Browser 9.0? I wish we would have noticed this sooner.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/31830tor-launcher string.trim()'s string elements in config UX, even passwords2022-03-16T20:49:39Zrichardtor-launcher string.trim()'s string elements in config UX, even passwordsnetwork-settings.js::getElemValue() trims string types, even the password field for proxy configuration.network-settings.js::getElemValue() trims string types, even the password field for proxy configuration.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/31491clean up the old meek http helper browser profiles2020-06-27T13:42:11ZMark Smithclean up the old meek http helper browser profilesNow that we are using obfs4proxy's meek_lite in Tor Browser, we should add code that removes the old meek http helper browser profiles.
This is probably most easily done by Tor Launcher during startup since it already knows the file sys...Now that we are using obfs4proxy's meek_lite in Tor Browser, we should add code that removes the old meek http helper browser profiles.
This is probably most easily done by Tor Launcher during startup since it already knows the file system path for each profile.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/31488moat: support a comma-separated list of transports in Tor config2020-06-27T13:42:11ZMark Smithmoat: support a comma-separated list of transports in Tor configThe enhancement we made for legacy/trac#29627 does not support a list of transports. This means that if the following is used, Tor Launcher will not detect that a PT that supports meek_lite is available:
```
ClientTransportPlugin meek_li...The enhancement we made for legacy/trac#29627 does not support a list of transports. This means that if the following is used, Tor Launcher will not detect that a PT that supports meek_lite is available:
```
ClientTransportPlugin meek_lite,obfs2,obfs3,obfs4,scramblesuit exec ./TorBrowser/Tor/PluggableTransports/obfs4proxy
```
Kathy and I will post a patch soon.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/31487Modify moat client code so it is compatible with ESR682020-06-27T13:42:12ZMark SmithModify moat client code so it is compatible with ESR68While working on legacy/trac#29430, Kathy and I found some incompatibilities in Tor Launcher's moat client code (src/modules/tl-bridgedb.jsm). All of the problems are due to Firefox internal API changes. While working on legacy/trac#3130...While working on legacy/trac#29430, Kathy and I found some incompatibilities in Tor Launcher's moat client code (src/modules/tl-bridgedb.jsm). All of the problems are due to Firefox internal API changes. While working on legacy/trac#31300, we did not exercise this code so we did not find these problems then.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/31300Modify Tor Launcher so it is compatible with ESR682020-06-27T13:42:12ZMark SmithModify Tor Launcher so it is compatible with ESR68In addition to removal of overlays (legacy/trac#29197), we must make other changes in Tor Launcher for ESR68 compatibility. For example, most of the "on" event attributes within XUL wizard elements have been replaced with events.In addition to removal of overlays (legacy/trac#29197), we must make other changes in Tor Launcher for ESR68 compatibility. For example, most of the "on" event attributes within XUL wizard elements have been replaced with events.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/30473update Tor Browser proposal 102 to account for Tails team feedback2022-03-17T05:47:34ZMark Smithupdate Tor Browser proposal 102 to account for Tails team feedbackWe need to update proposal 102 "Integration of Tor Launcher into Tor Browser Core" to account for feedback we received from the Tails team (intrigeri). See the discussion here:
https://lists.torproject.org/pipermail/tbb-dev/2019-February...We need to update proposal 102 "Integration of Tor Launcher into Tor Browser Core" to account for feedback we received from the Tails team (intrigeri). See the discussion here:
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000962.html
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000963.html
https://lists.torproject.org/pipermail/tbb-dev/2019-February/000964.htmlhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/29627Moat: add support for obfsproxy's meek_lite2021-12-27T20:54:13ZMark SmithMoat: add support for obfsproxy's meek_liteWe should improve the Moat client support in Tor Launcher so it will work with obfsproxy's meek_lite implementation (as well as with dcf's meek implementation). The main reason it does not currently work is because the code inside Tor La...We should improve the Moat client support in Tor Launcher so it will work with obfsproxy's meek_lite implementation (as well as with dcf's meek implementation). The main reason it does not currently work is because the code inside Tor Launcher that interacts with the PT program relies on command line parameters instead of SOCKS args to pass info to the PT.
For more background, see ticket:29430#comment:5 and other related comments within legacy/trac#29430.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/29328account for tor 0.4.0.x's revised bootstrap status reporting2020-06-27T13:42:12ZMark Smithaccount for tor 0.4.0.x's revised bootstrap status reportingTor 0.4.0.x includes changes to bootstrap status reporting (see legacy/trac#27167). Tor Launcher should be updated to account for the changes; documentation is here: https://gitweb.torproject.org/torspec.git/commit/?id=27267c579fa9439966...Tor 0.4.0.x includes changes to bootstrap status reporting (see legacy/trac#27167). Tor Launcher should be updated to account for the changes; documentation is here: https://gitweb.torproject.org/torspec.git/commit/?id=27267c579fa943996688a5bbe933c0f8fc7a7ebchttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/29197remove use of overlays from Tor Launcher2020-06-27T13:42:12ZMark Smithremove use of overlays from Tor LauncherXUL overlay support was removed from Firefox beginning with Firefox 63. See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791
Tor Launcher uses an overlay to allow configuration UI elements to be shared between the setup wizard and t...XUL overlay support was removed from Firefox beginning with Firefox 63. See https://bugzilla.mozilla.org/show_bug.cgi?id=1449791
Tor Launcher uses an overlay to allow configuration UI elements to be shared between the setup wizard and the Tor Network Settings dialog. We will need to replace this with a preprocessor #include strategy or just maintain two copies of the XUL.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/28699Tor Browser is not properly shutting down tor2022-03-16T21:06:48ZGeorg KoppenTor Browser is not properly shutting down torWe got a bug report on our blog from a user that can reproduce tor being not shut down during browser shutdown. That leads to a failed Tor Browser start until the old tor process got killed. See: https://blog.torproject.org/comment/27840...We got a bug report on our blog from a user that can reproduce tor being not shut down during browser shutdown. That leads to a failed Tor Browser start until the old tor process got killed. See: https://blog.torproject.org/comment/278400#comment-278400.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/28217Mozzilla number decodificated2020-06-27T13:42:13ZTracMozzilla number decodificatedanonymoustly loves company
**Trac**:
**Username**: mr OPzanonymoustly loves company
**Trac**:
**Username**: mr OPzhttps://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/28044Integrate Tor Launcher into tor-browser2022-01-11T19:25:37ZGeorg KoppenIntegrate Tor Launcher into tor-browserWe need to move away from our XPCOM extensions, Tor Launcher being one of them. As for Tor Browser it might be hard/impossible, if we tried to reimplement everything Tor Launcher does with the WebExtensions API. Instead we plan to integr...We need to move away from our XPCOM extensions, Tor Launcher being one of them. As for Tor Browser it might be hard/impossible, if we tried to reimplement everything Tor Launcher does with the WebExtensions API. Instead we plan to integrate it tighter into the browser itself making use of its capabilities.
This ticket is the parent ticket for this plan.
We need probably a proposal making sure we have the plan right before going to implement it.https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/27469Change the moat service URL2020-06-27T13:42:13ZGeorg KoppenChange the moat service URLWe need to change the Moat service URL one additional time after we switched to azure. All in all we should use the following URLs from now on:
```
extensions.torlauncher.moat_service https://bridges.torproject.org/moat
extensions.torla...We need to change the Moat service URL one additional time after we switched to azure. All in all we should use the following URLs from now on:
```
extensions.torlauncher.moat_service https://bridges.torproject.org/moat
extensions.torlauncher.bridgedb_front ajax.aspnetcdn.com
extensions.torlauncher.bridgedb_reflector https://onionquiche.azureedge.net/
```https://gitlab.torproject.org/tpo/applications/tor-launcher/-/issues/27426"Tor unexpectedly exited." is not clear enough2020-06-27T13:42:13Ztraumschule"Tor unexpectedly exited." is not clear enoughThere are several different issues with the same error message:
- legacy/trac#9541
- legacy/trac#12501
- legacy/trac#13030
- legacy/trac#18939
- legacy/trac#18994
- legacy/trac#19957
- legacy/trac#21053
- legacy/trac#22456
- legacy/trac#...There are several different issues with the same error message:
- legacy/trac#9541
- legacy/trac#12501
- legacy/trac#13030
- legacy/trac#18939
- legacy/trac#18994
- legacy/trac#19957
- legacy/trac#21053
- legacy/trac#22456
- legacy/trac#23380
- legacy/trac#24619
- legacy/trac#25133
- legacy/trac#25868
- legacy/trac#27110
- comment:4:ticket:27351
- comment:7:ticket:27407