Bug 23949: Fix bug in donation banner that prevented display

5feba966 · Arthur Edelstein · Georg Koppen · b35a3e2f · 5feba966
Commit 5feba966 authored Oct 22, 2017 by Arthur Edelstein Committed by Georg Koppen Oct 23, 2017
--- a/src/modules/donation-banner.js
+++ b/src/modules/donation-banner.js
@@ -52,7 +52,8 @@ const gStringBundle = Services.strings.createBundle(kPropertiesURL);
 const shouldShowBanner = function (shortLocale) {
  try {
    // If our override test pref is true, then just show the banner regardless.
-    if (Services.prefs.getBoolPref("extensions.torbutton.testBanner", false)) {
+    if (Services.prefs.prefHasUserValue("extensions.torbutton.testBanner") &&
+        Services.prefs.getBoolPref("extensions.torbutton.testBanner") === true) {
      return true;
    }
    // Don't show a banner if update is needed.