Also, remove the 'extensions.torbutton.resist_fingerprinting' pref
and just use the 'privacy.resistFingerprinting' pref instead. We will
use this to implement a checkbox in the about:preferences#privacy page.

Also, we remove the 'extensions.torbutton.restrict_thirdparty'
and use the 'privacy.thirdparty.isolate' pref. At the same time we
will need to add a checkbox to the about:preferences#privacy page
that toggles 'privacy.thirdparty.isolate'.

Note that 'privacy.thirdparty.isolate' will be renamed to
'privacy.firstparty.isolate' in Firefox 52.

This patch also removes the 'extensions.torbutton.no_tor_plugin'
pref and simply uses the 'plugin.disable' pref instead.

Thanks to our patch for Bug 10280 in tor-browser.git,
buttons on the plugins section of about:addons
already let you "Enable plugins" and "Disable plugins"
(i.e., toggle the 'plugin.disable' pref).

Also it's probably better to remove this footgun in the UI.

An equivalent checkbox, "Always use private browsing mode"
is already available in about:preferences#privacy. Better to leave
it more hidden from the user in any case, as it is inadvisable
to disable private browsing mode.

We remove the 'extensions.torbutton.block_disk' pref and use the
'browser.privatebrowsing.autostart' pref instead, because they
are equivalent.

We'll also use add a patch to disable remote jars in tor-browser.git

arthuredelstein@gmail.com authored Sep 15, 2016 and Georg Koppen committed Sep 26, 2016

If the dialog is too small to show all descriptions, then the
descriptions text area will show a scrollbar.

Call Tor Launcher's new TorGetControlSocketFile() function to determine
if a Unix domain socket is being used for Tor control port communication
and, if it is, use it instead of a TCP connection.

When performing the local Tor check (which compares the configured
Firefox SOCKS proxy to the one reported by GETINFO net/listeners/socks),
correctly handle UNIX domain sockets as well as IPv6 addresses.

Restore previous behavior: do not reset the SOCKS-related preferences when
the TOR_SOCKS_HOST and TOR_SOCKS_PORT environment variables are not set.

We need to clear site security settings (like HSTS) explicitely now
as they don't belong to the permissions manager anymore.

Remove the remains of the Torbutton settings panel (which was hidden
by the fix for bug 14630).

Remove the status bar panel (the status bar was removed in Firefox 4).

Remove the outdated "Disable Torbutton to change these settings"
message from the Firefox proxy settings dialog.

Change the behavior of the "Restore Defaults" button in the Privacy
and Security Settings window to no longer reset the browser's proxy
preferences. Our general philosophy is that if Torbutton does not
provide a GUI for changing a preference, Torbutton should not modify
the preference. The exceptions are that Torbutton still supports the
TOR_SOCKS_PORT and TOR_TRANSPROXY environment variables.

Remove a lot of toggle logic, including extensions.torbutton.tor_enabled
and related preferences.

Remove the dual cookie jar support since Tor can no longer be turned off.

Rename torbutton_close_on_toggle() to torbutton_close_tabs_on_new_identity().

Remove torbutton_check_socks_remote_dns() since SOCKS remote DNS is
supported by all modern versions of Firefox.

Remove torbutton_has_good_socks() since it was testing for Firefox 5
or newer.

Remove unused Firefox version check variables, unused functions, and
commented out code.

Yawning Angel authored Aug 15, 2016 and Georg Koppen committed Aug 19, 2016

Firefox requires being able to load chrome:// and resource:// URLs for
things like the media player, with the origin set to the remote URL
that triggered the load.

This is unfortunate in that there's no way to disambiguate malicious JS
versus someone opening a video file (for example).

See https://trac.torproject.org/projects/tor/ticket/19837#comment:5
for why this is a huge nightmare and will eventually require C++ code.

Do not add another notification if one is already visible.

CHANGELOG update, version bump

Remove remaining things needed for fixing #9901.

Kathleen Brade authored Jun 29, 2016 and Georg Koppen committed Jul 17, 2016

Display the external app confirmation dialog in response to the new
"external-app-requested" observer service notification. Remove
messy overrides of Mozilla components and console log filtering.

Remove obsolete "on-modify-drag-list" observer and pre-Firefox 4.0
module registration code from the External App Handler component.

We are exempting `javascript.options.asmjs` from the Security Slider for
now and set it to `false` by default (which is done by a separate
Tor Browser patch).

This is a stopgap until at least the linkability concerns in #19417 are
addressed.

Kathleen Brade authored Jul 15, 2016 and Georg Koppen committed Jul 17, 2016

When displaying the "Are you sure you want to enable plugins?" prompt,
always use the top-most browser window as the parent window. This avoids
problems caused by using the Privacy and Security Settings dialog, which
is closing, as the parent.

The browser's behavior is different depending on if a given internal
resource is available or not, regardless of the fact that the actual
body will not load due to the various safeguards and checks.

This normalizes the behavior by denying all redirects destined for URLs
with proscribed browser internal schemes (`resource`, `about`, `chrome`).

This patch clears the asmjscache (and the IndexedDB storage) on
New Identity and during start-up. The latter is a suboptimal workaround
we deploy until the asmjscache is Private Browsing Mode aware.
InedxedDB storage is not so urgent as IndexedDB is not working in
Private Browsing Mode anyway.

Most addons do not set `contentaccessible=yes`, however behavior should
be consistent even if such addons are installed.

This does not affect any of the standard addons shipped with Tor Browser, but
will break user installed addons that depend on actually being able to
access `chrome://` URLs in this manner.

Based on ResourceFilter: A direct workaround for https://bugzil.la/863246
https://notabug.org/desktopd/no-resource-uri-leak/src/master/src/resource-filter/content-policy.js

Yawning Angel authored Jun 07, 2016 and Georg Koppen committed Jun 10, 2016

Additionally clear out the domain isolator state on `New Identity`.  In
theory this removes the need to explicitly issue a `NEWNYM` as new
circuits will be used for all subsequent requests, including those made
via the catch-all circuit.

Yawning Angel authored Jun 07, 2016 and Georg Koppen committed Jun 10, 2016

When creating a domain isolation nonce, 128 bits of entropy is drawn
from a cryptographic source and saved on a per-domain basis.  The new
circuit behavior is changed to regenerate the nonce, instead of
incrementing a counter.

This allows the "right thing" to happen when the same tor instance is
used across multiple Tor Browser sessions, for example when using a
system wide tor, or a magic anonymity box.

CHANGELOG update, version bump

Remove default preferences that are not used.

Remove unused property strings.

Remove unused entities.
Remove unused "about.xul" and associated entities.

Thanks to cpwc for the patch.