Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • T torbutton
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Applications
  • torbutton
  • Issues
  • #20102
Closed (moved) (moved)
Open
Issue created Sep 07, 2016 by Mark Smith@mcs

use a data object for control port info

In ticket:14271#comment:16, arthuredelstein said: In torbutton.js, we will now have

var m_tb_control_socket_file = null; // Set if using a UNIX domain socket.
var m_tb_control_port = null;        // Set if not using a socket.
var m_tb_control_host = null;        // Set if not using a socket.
var m_tb_control_pass = null;
var m_tb_control_desc = null;  

I imagine it might be cleaner to collect these into a single data object like

var m_tb_control = { socket_file, host, port, password, descriptor }

Then we could factor out a single factory function from torbutton_init() that generates this object. And we could use this object as a single argument for functions in tor-control-port.js and tor-circuit-display.js as well.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking