Lets start with some best practices to review other people's work:
- Remember that is hard to receive negative feedback. Be kind.
- Be patient. We are all learning here.
- Try to explain why some options are better than others.
- Share resources you use for translation (dictionaries, glossaries, etc)
A good review is done looking at the actual website-application you are reviewing. For example, most of the Tor Project websites have a preview version that publishes languages straight from transifex, even when they are incomplete. See the 'preview' links of each resource at the resource list
The most common errors on our website translations are the links. We have a page that lists the current website broken links. This page is refreshed once a day. Please check your language strings for problems.
If you are not sure how to review links, please read this explanation about links in markdown
- localize - localize_link - no_localize_link: https://www.transifex.com/otf/tor-project-support-community-portal/translate/#ar/$/163988578?q=tags%3Alocalize_link some of the links can be changed to the proper locale, for example https://community.torproject.org/localization/becoming-tor-translator/ can be translated to Spanish as https://community.torproject.org/es/localization/becoming-tor-translator/ . Some other links dont have translation and should stay as on the source string.
- Notranslate: https://www.transifex.com/otf/tor-project-support-community-portal/translate/#ar/$/158007399?q=tags%3Anotranslate - we try to tag all the commands or other non-translatable strings that make it to the translation files. Many users translate for example the extracts of the tor logs, but the logs are always in English so we should leave them as is. You can copy the content from the source file when you see this tag.
- translate_alt: https://www.transifex.com/otf/tor-project-support-community-portal/translate/#ar/$/158007399?q=tags%3Atranslate_alt - images' alt attribute goes usually untranslated, because of the transifex interface, but it is bad for accessibility because user will not understand what the image is about.
There are also some tags to group specific topics or parts of the documentation. This tags cover sections of our websites. They are:
- glossary - the Tor Glossary: http://support.torproject.org/glossary
- localization the l10n section of the community portal: https://community.torproject.org/localization/
- onion-services the onion services section of the community portal: https://community.torproject.org/onion-services/
- outreach the outreach section of the community portal: https://community.torproject.org/outreach/
- relay-slides presentation about tor relays: https://community.torproject.org/training/resources/tor-relay-workshop/