Commit 18115a11 authored by gabi-250's avatar gabi-250 🤸
Browse files

arti, keymgr: s/IDEA/TODO 

It's better to use "TODO" like we do in the rest of Arti, because
otherwise this has a chance of being forgotten (because nobody really
greps for "IDEA").
parent ba7f583e

crates/arti/tests/cli_tests/keys/util.rs

+1 −1
Original line number Diff line number Diff line
@@ -11,7 +11,7 @@ const CFG_PATH: &str = "./tests/testcases/keys/keys.in/keys.toml"; 
const CFG_PATH_WITH_CTOR: &str = "./tests/testcases/keys/conf/keys.toml";



/// A client of an `ArtiNativeKeystore`.

// IDEA: Consider using the

// TODO: Consider using the

// [const_format](https://docs.rs/const_format/latest/const_format/index.html) crate to reduce duplication.

const CLIENT_KEY: &str = "Keystore ID: arti

Role: ks_hsc_desc_enc

crates/tor-keymgr/src/keystore/arti/err.rs

+2 −1
Original line number Diff line number Diff line
@@ -18,7 +18,8 @@ pub(crate) enum ArtiNativeKeystoreError { 
    Filesystem(#[from] FilesystemError),



    /// Found a key with an invalid path.

    // IDEA: Should we expose the underlying MalformedPathError? The current

    //

    // TODO: Should we expose the underlying MalformedPathError? The current

    // message "Key has invalid path" is too vague.

    #[error("Key has invalid path: {path}")]

    MalformedPath {