Skip to content

KeyMgr::list_matching should return the KeystoreSelector too

  • change the return type of KeyMgr::list_matching to KeystoreEntryFooBar (that contains the KeystoreSelector of the entry)
  • replace KeyMgr::remove with KeyMgr::remove_entry(KeystoreEntryFooBar)

Context:

14:39:43                        +Diziet | gabi: KeyMgr::list_matching gets me a vec of (KeyPath, KeyType) but remove (and remove_with_type) want a KeystoreSelector.  Should I pass Default?  That seems wrong.  I want "Any".                                              
14:41:30                           gabi |  I want "Any".> as in, remove from all keystores?                                                                                                                                                                                 
14:41:58                        +Diziet | Well, what I really want is to remove this one I've got list_matching.                                                                                                                                                            
14:43:33                           gabi | ah.. I think we want list_matching to return a vec (KeyPath, KeyType, KeystoreSelector)                                                                                                                                           
14:44:11                        +Diziet | Perhaps it wants to return `KeystoreListingEntry`s.                                                                                                                                                                               
14:44:12                           gabi | for now let's 1) use Default, 2) create a ticket (I'll do that) 3) reference the ticket in the code                                                                                                                               
14:44:21                        +Diziet | tyvm                                                                                                                                                                                                                              
14:44:23                           gabi | KeystoreListingEntry> yes, something like that                                                                                                                                                                                    
14:44:55                        +Diziet | We could have remove_entry that took one and then the caller wouldn't need to get plumbing right.                                                                                                                                 
14:45:51                           gabi | good idea