Skip to content

Channel build task disappeared internal error

Spotted in the arti svc logs from #1280 (comment 2997720):

2024-02-19T11:25:19Z DEBUG tor_circmgr::mgr: While waiting on circuit: Ok(Err(Channel { peer: OwnedChanTarget { addrs: [23.88.75.121:9001], method: Direct([23.88.75.121:9001]), ids: RelayIds { ed_identity: Some(Ed25519Identity { eJ/RzeShStQOHZR2IKO8DY39SiYsAujwWG3XoT5fcWc }), rsa_identity: Some(RsaIdentity { $6ea127366d2dbd8b05bc150fb1b93382a2e29b1f }) } }, cause: Internal(Bug(BugRepr { message: "channel build task disappeared", location: Location { file: "/home/stefani/2024/02/07/arti/crates/tor-chanmgr/src/mgr.rs", line: 229, col: 54 }, backtrace: Captured(   0: tor_error::internal::Bug::new_inner
   1: tor_chanmgr::mgr::AbstractChanMgr<CF>::get_or_launch::{{closure}}
   2: <tor_proto::circuit::ClientCirc as tor_circmgr::build::Buildable>::create_chantarget::{{closure}}
   3: tor_circmgr::build::double_timeout::{{closure}}::{{closure}}
   4: tokio::runtime::task::raw::poll
   5: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
   6: tokio::runtime::task::raw::poll
   7: tokio::runtime::task::UnownedTask<S>::run
   8: std::sys_common::backtrace::__rust_begin_short_backtrace
   9: core::ops::function::FnOnce::call_once{{vtable.shim}}
  10: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/alloc/src/boxed.rs:2007:9
      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/alloc/src/boxed.rs:2007:9
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys/unix/thread.rs:108:17
  11: <unknown>
  12: <unknown>
), source: None, kind: Internal })) })) from circuit we're building
2024-02-19T11:25:19Z DEBUG tor_circmgr::mgr: circuit we're building sent error Channel { peer: OwnedChanTarget { addrs: [23.88.75.121:9001], method: Direct([23.88.75.121:9001]), ids: RelayIds { ed_identity: Some(Ed25519Identity { eJ/RzeShStQOHZR2IKO8DY39SiYsAujwWG3XoT5fcWc }), rsa_identity: Some(RsaIdentity { $6ea127366d2dbd8b05bc150fb1b93382a2e29b1f }) } }, cause: Internal(Bug(BugRepr { message: "channel build task disappeared", location: Location { file: "/home/stefani/2024/02/07/arti/crates/tor-chanmgr/src/mgr.rs", line: 229, col: 54 }, backtrace: Captured(   0: tor_error::internal::Bug::new_inner
   1: tor_chanmgr::mgr::AbstractChanMgr<CF>::get_or_launch::{{closure}}
   2: <tor_proto::circuit::ClientCirc as tor_circmgr::build::Buildable>::create_chantarget::{{closure}}
   3: tor_circmgr::build::double_timeout::{{closure}}::{{closure}}
   4: tokio::runtime::task::raw::poll
   5: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
   6: tokio::runtime::task::raw::poll
   7: tokio::runtime::task::UnownedTask<S>::run
   8: std::sys_common::backtrace::__rust_begin_short_backtrace
   9: core::ops::function::FnOnce::call_once{{vtable.shim}}
  10: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/alloc/src/boxed.rs:2007:9
      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/alloc/src/boxed.rs:2007:9
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/sys/unix/thread.rs:108:17
  11: <unknown>
  12: <unknown>
), source: None, kind: Internal })) }

They're logged at DEBUG level, so I assume these aren't fatal (NB: I haven't looked at the relevant code yet).

The error type (Internal) suggests this is either a) a bug that needs to be fixed, or b) that we need a separate, non-Bug, error type for this sort of failure.