New clippy warnings with Rust 1.83
Initial warnings:
error: the following explicit lifetimes could be elided: 'a
--> crates/tor-basic-utils/src/iter.rs:77:6
|
77 | impl<'a, P, I> Iterator for CountingFilter<'a, P, I>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
77 - impl<'a, P, I> Iterator for CountingFilter<'a, P, I>
77 + impl<P, I> Iterator for CountingFilter<'_, P, I>
|
error: the following explicit lifetimes could be elided: 'a
--> crates/tor-basic-utils/src/iter.rs:145:6
|
145 | impl<'a> std::fmt::Display for DisplayFracRejected<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
145 - impl<'a> std::fmt::Display for DisplayFracRejected<'a> {
145 + impl std::fmt::Display for DisplayFracRejected<'_> {
|
error: the following explicit lifetimes could be elided: 'e
--> crates/tor-error/src/report.rs:62:6
|
62 | impl<'e> AsRef<dyn StdError + 'static> for ReportHelper<'e> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
62 - impl<'e> AsRef<dyn StdError + 'static> for ReportHelper<'e> {
62 + impl AsRef<dyn StdError + 'static> for ReportHelper<'_> {
|
Do we want to suppress clippy::needless_lifetimes
? It seems to affect roughly half of our crates.