SYSTEM_DEFAULT_CONNECT_POINT si not found for windows and behind a unix flag
Summary
Building arti from source
Steps to reproduce:
- Clone the current main(hash:95762c14)
- Run a release build in windows 11
What is the current bug behavior?
tor_rpc_connect does not build correctly failing with SYSTEM_DEFAULT_CONNECT_POINT is not found and being help behind an item which is gated behind unix flag.
What is the expected behavior?
tor_rpc_connect builds correctly allowing the package to compile
Environment
- Version: cargo 1.83.0 (5ffbef321 2024-10-29), rustc 1.83.0 (90b35a623 2024-11-26)
- Operating system: Windows 11 24H2
- Install method: from git master from source
- etc...
Relevant logs and/or screenshots:
Compiling arti-rpc-client-core v0.25.0 (C:\Users\Ahadl\Documents\GitHub\arti\crates\arti-rpc-client-core)
error[E0425]: cannot find value `SYSTEM_DEFAULT_CONNECT_POINT` in crate `tor_rpc_connect`
--> crates\arti-rpc-client-core\src\conn\builder.rs:121:43
|
121 | if let Some(p) = tor_rpc_connect::SYSTEM_DEFAULT_CONNECT_POINT {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a constant with a similar name exists: `USER_DEFAULT_CONNECT_POINT`
|
::: C:\Users\Ahadl\Documents\GitHub\arti\crates\tor-rpc-connect\src\lib.rs:231:1
|
231 | pub const USER_DEFAULT_CONNECT_POINT: &str = {
| ------------------------------------------ similarly named constant `USER_DEFAULT_CONNECT_POINT` defined here
|
note: found an item that was configured out
--> C:\Users\Ahadl\Documents\GitHub\arti\crates\tor-rpc-connect\src\lib.rs:254:11
|
254 | pub const SYSTEM_DEFAULT_CONNECT_POINT: Option<&str> = {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: the item is gated here
--> C:\Users\Ahadl\Documents\GitHub\arti\crates\tor-rpc-connect\src\lib.rs:253:1
|
253 | #[cfg(unix)]
| ^^^^^^^^^^^^
Compiling zstd v0.13.2
Compiling tor-ptmgr v0.25.0 (C:\Users\Ahadl\Documents\GitHub\arti\crates\tor-ptmgr)
For more information about this error, try `rustc --explain E0425`.
error: could not compile `arti-rpc-client-core` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Possible fixes:
Remove the unix cfg requirement in tor_rpc_connect
Edited by LowLandMink543